Skip to content

Commit 7cde244

Browse files
committed
fix: correct Windows settings dark surfaces and search alignment
1 parent 3aa18ed commit 7cde244

4 files changed

Lines changed: 21 additions & 1 deletion

File tree

‎src/features/settings/ProviderSettings.vue‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -670,7 +670,7 @@ onBeforeUnmount(() => {
670670
min-width: 190px;
671671
overflow: hidden;
672672
padding: 18px 12px;
673-
background: var(--paper);
673+
background: var(--chrome-solid);
674674
display: grid;
675675
align-content: start;
676676
grid-template-rows: minmax(0, 1fr) auto;

‎src/features/settings/SettingsWorkspace.vue‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -255,6 +255,7 @@ fluent-button.category-button {
255255
width: 100%;
256256
}
257257
fluent-button.category-button::part(content) {
258+
color: inherit;
258259
display: flex;
259260
box-sizing: border-box;
260261
width: 100%;
@@ -480,6 +481,7 @@ section.settings.settings-workspace.native-settings-window[data-section] {
480481
}
481482
.workspace-actions {
482483
display: flex;
484+
margin-inline-start: auto;
483485
align-items: center;
484486
gap: 12px;
485487
}

‎src/platform/windows/reader.css‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,9 @@
3434
--radius-sm: 6px;
3535
--chrome-solid: #f3f3f3;
3636
}
37+
[data-appearance='dark'] .app[data-platform='win32'] {
38+
--chrome-solid: #28282b;
39+
}
3740

3841
.desktop[data-platform='win32'] .toolbar .title {
3942
font-weight: 600;

‎tests/desktop/windows-controls-smoke.mjs‎

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -218,9 +218,24 @@ export async function verifyWindowsControls(window) {
218218
`document.querySelector('.fluent-kernel-modes fluent-tab[data-kernel-mode=pdf_math_precise]').dataset.state==='on'`,
219219
);
220220
await category('providers');
221+
assert.equal(
222+
await run(
223+
`(()=>{const actions=document.querySelector('.workspace-actions').getBoundingClientRect();const header=document.querySelector('.workspace-heading');const rect=header.getBoundingClientRect();return Math.abs(rect.right-actions.right-parseFloat(getComputedStyle(header).paddingRight))<2;})()`,
224+
),
225+
true,
226+
'Provider search and close controls must align to the trailing edge',
227+
);
221228
await wait(`!!document.querySelector('fluent-button.provider-list-item')`);
222229
await run(`document.querySelector('fluent-button.provider-list-item').click()`);
223230
await wait(`!!document.querySelector('fluent-button.provider-list-item.is-browse')`);
231+
await run(`document.documentElement.dataset.appearance='dark'`);
232+
assert.equal(
233+
await run(
234+
`(()=>{const background=el=>getComputedStyle(el).backgroundColor;const dark=color=>{const channels=color.match(/[\\d.]+/g);return channels&&channels.slice(0,3).every(value=>Number(value)<100)};return ['.workspace-heading','.workspace-page','.provider-browser'].every(selector=>dark(background(document.querySelector(selector))));})()`,
235+
),
236+
true,
237+
'Settings and provider surfaces must use dark backgrounds',
238+
);
224239
window.show();
225240
await new Promise((resolve) => setTimeout(resolve, 350));
226241
await writeFile(

0 commit comments

Comments
 (0)