Skip to content

isOnboarded state is in-memory only — cold app restart loses onboarding state despite the secret still existing in SecureStore #34

Description

@ndii-dev

useWalletStore in src/store/walletStore.ts has no persistence middleware, and app/index.tsx decides the initial route purely from the in-memory isOnboarded flag. Every cold start therefore redirects to /auth/welcome even though secureStorage.ts may still hold a valid secret from a previous session — at best this is a broken UX loop (user must "create" or "import" again every launch), at worst a user re-running create.tsx under this condition triggers the overwrite bug described in a related issue and loses access to their real funded address.

Definition of done:

  • On cold start, check SecureStore (not just in-memory state) for an existing secret and restore publicKey/isOnboarded accordingly before routing
  • No plaintext persistence of the secret itself outside SecureStore to achieve this
  • Regression test simulating a cold start with a pre-existing SecureStore entry

Before opening a PR for this issue, read CONTRIBUTING.md.

This is not a starter-issue. The Definition of done above is the full
acceptance criteria, not a subset to sample from — a PR that addresses part
of it is an unfinished issue, not a smaller one. Your PR must include, in
the PR description itself:

  • Root cause / design-decision rationale in your own words — not a restatement of this issue
  • Every Definition of done bullet above addressed explicitly, with a one-line note on how
  • Evidence the code actually runs: pasted test/build output, a screen recording or before/after screenshots for UI changes, or real (non-mocked) logs for network/contract-facing work
  • New or updated tests included and shown passing (paste the output)
  • Any adjacent/related behavior this issue calls out re-verified, not assumed unaffected

PRs missing these will be sent back before review, not reviewed and rejected — please do this up front.

Metadata

Metadata

Assignees

Labels

GrantFox OSSIssue tracked in GrantFox OSSMaybe RewardedIssue may be eligible for a GrantFox rewardOfficial Campaign | FWC26Campaign: Official Campaign | FWC26

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions