Skip to content

Commit e166dcb

Browse files
refactor(ipc): remove url-based sound playback
1 parent 6597b1b commit e166dcb

1 file changed

Lines changed: 5 additions & 14 deletions

File tree

src/open_wearables/ipc/client.py

Lines changed: 5 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -269,17 +269,15 @@ async def store_sound_file(
269269

270270
async def play_sound(
271271
self,
272-
sound_id: Optional[str] = None,
272+
sound_id: str,
273273
*,
274-
url: Optional[str] = None,
275274
volume: Optional[float] = None,
276275
codec: Optional[str] = None,
277276
sample_rate: Optional[int] = None,
278277
num_channels: Optional[int] = None,
279278
) -> dict[str, Any]:
280279
return await self._client.play_sound(
281280
sound_id=sound_id,
282-
url=url,
283281
volume=volume,
284282
codec=codec,
285283
sample_rate=sample_rate,
@@ -560,24 +558,17 @@ async def store_sound_file(
560558

561559
async def play_sound(
562560
self,
563-
sound_id: Optional[str] = None,
561+
sound_id: str,
564562
*,
565-
url: Optional[str] = None,
566563
volume: Optional[float] = None,
567564
codec: Optional[str] = None,
568565
sample_rate: Optional[int] = None,
569566
num_channels: Optional[int] = None,
570567
) -> dict[str, Any]:
571-
has_sound_id = sound_id is not None and sound_id != ""
572-
has_url = url is not None and url != ""
573-
if has_sound_id == has_url:
574-
raise ValueError("Provide exactly one of sound_id or url.")
568+
if sound_id == "":
569+
raise ValueError("sound_id must not be empty.")
575570

576-
params: dict[str, Any] = {}
577-
if has_sound_id:
578-
params["sound_id"] = sound_id
579-
if has_url:
580-
params["url"] = url
571+
params: dict[str, Any] = {"sound_id": sound_id}
581572
if volume is not None:
582573
params["volume"] = volume
583574
if codec is not None:

0 commit comments

Comments
 (0)