Repository navigation
Commit 94f1198
phase9(ci): unblock Compile & Hygiene -- diff .d.ts + appimage hygiene ignore
Two pre-existing blockers (red on main too, NOT introduced by the branch) made
the "Compile & Hygiene" CI job fail. Both fixed minimally:
1. core-ci/tsgo TS2307: findDiffs.ts imports the GENERATED
../react/out/diff/index.js. CI runs the typecheck BEFORE buildreact, so the
artifact is absent and the module cannot resolve. The 6 sibling react/out
modules already ship committed index.d.ts files (out/ is gitignored, they are
force-added) -- diff/ was the only one missing one. Add a hand-maintained
out/diff/index.d.ts (diffLines + Change) so the import is type-resolvable
without building react, matching the existing pattern. tsup emits .js only
(dts is disabled, clean:false) so a local buildreact will not clobber it.
2. hygiene: scripts/appimage/create_appimage.sh fails on (a) intentional
translated (non-ASCII) desktop-menu names and (b) its own space indentation.
Exclude it from unicodeFilter + indentationFilter in build/filters.ts (the
same treatment build/**/*.sh and the cortexide React tree already get) rather
than stripping the translations.
Verification:
- tsgo with react/out/diff/index.js hidden (exact CI condition: react unbuilt)
-> 0 errors, no findDiffs error. Normal-state tsgo also 0.
- node build/hygiene.ts scripts/appimage/create_appimage.sh -> exit 0 (was 14
errors). hygiene on the new .d.ts -> exit 0.
- cortexide node subset: 551 passing, 0 failing.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>1 parent d929252 commit 94f1198
2 files changed
Lines changed: 27 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
67 | 67 | | |
68 | 68 | | |
69 | 69 | | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
70 | 74 | | |
71 | 75 | | |
72 | 76 | | |
| |||
143 | 147 | | |
144 | 148 | | |
145 | 149 | | |
| 150 | + | |
| 151 | + | |
146 | 152 | | |
147 | 153 | | |
148 | 154 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
0 commit comments