Skip to content

Commit 2ac17ac

Browse files
Tajudeenclaude
andcommitted
fix(linux-build): allow Electron version mismatch for ppc64le/loong64/riscv64
The version bypass checked for TARGET major == 37, but VS Code 1.118.1 uses Electron 39. Community Electron builds for these architectures (lex-ibm v34.2.0, darkyzhou v34.2.0, riscv-forks v37.10.3) will always lag behind upstream. Remove the hard-coded version constraint and allow any mismatch for these three architectures with a warning. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
1 parent 8d33ea1 commit 2ac17ac

1 file changed

Lines changed: 5 additions & 6 deletions

File tree

‎build/linux/package_bin.sh‎

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -90,13 +90,12 @@ if [[ -f "../build/linux/${VSCODE_ARCH}/electron.sh" ]]; then
9090

9191
TARGET=$( npm config get target )
9292

93-
# Only fails at different major versions
94-
# For loong64 and ppc64le, allow v34.x even if target is v37.x since their repositories only have v34.2.0
93+
# Only fails at different major versions.
94+
# ppc64le/loong64/riscv64 use community Electron builds that lag behind the upstream
95+
# version — allow any mismatch for these architectures (warning only).
9596
if [[ "${ELECTRON_VERSION%%.*}" != "${TARGET%%.*}" ]]; then
96-
if [[ "${VSCODE_ARCH}" == "loong64" ]] && [[ "${ELECTRON_VERSION%%.*}" == "34" ]] && [[ "${TARGET%%.*}" == "37" ]]; then
97-
echo "Warning: Using Electron ${ELECTRON_VERSION} for loong64 (target is ${TARGET}) - only v34.2.0 is available in darkyzhou/electron-loong64"
98-
elif [[ "${VSCODE_ARCH}" == "ppc64le" ]] && [[ "${ELECTRON_VERSION%%.*}" == "34" ]] && [[ "${TARGET%%.*}" == "37" ]]; then
99-
echo "Warning: Using Electron ${ELECTRON_VERSION} for ppc64le (target is ${TARGET}) - only v34.2.0 is available in lex-ibm/electron-ppc64le-build-scripts"
97+
if [[ "${VSCODE_ARCH}" == "loong64" ]] || [[ "${VSCODE_ARCH}" == "ppc64le" ]] || [[ "${VSCODE_ARCH}" == "riscv64" ]]; then
98+
echo "Warning: Using Electron ${ELECTRON_VERSION} for ${VSCODE_ARCH} (target is ${TARGET}) - community Electron build; version mismatch is expected"
10099
else
101100
# Fail the pipeline if electron target doesn't match what is used.
102101
echo "Electron ${VSCODE_ARCH} binary version doesn't match target electron version!"

0 commit comments

Comments
 (0)