Skip to content

Commit 9df3583

Browse files
committed
fix: let grid buttons keep their own styles; exact bigint sort; cleanup
- Move the button reset's background and border under :where() so component classes win (AI panel Ask / suggestions / Undo, open toolbar buttons); regenerate the default-theme baseline - Give the AI panel's pills and chips a fixed pill radius - Sort bigints beyond 2^53 exactly - toNumber rejects radix prefixes and non-finite text - Remove unused helpers, an empty module and CSS for classes the grid never sets - Draw infinite-scroll placeholders through a Row prop instead of _isSkeleton - Share the filter value helpers between the filter panel and header filters - Document every package export in API_REFERENCE
1 parent b524ae7 commit 9df3583

32 files changed

Lines changed: 255 additions & 4845 deletions

‎CHANGELOG.md‎

Lines changed: 22 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,28 @@
55

66
---
77

8+
## [Unreleased — 3.8.1]
9+
10+
### Fixed
11+
12+
- **Buttons inside the grid show their own background and border again.** A reset rule from the first release (`.ogx button:not(.ogx-menu-item)`) out-ranked the buttons' own classes and removed their background and border: the AI assistant's Ask button had no fill (dark text on the dark panel in dark mode), its suggestions and the Undo / microphone buttons had no outline, and the open or active states of the toolbar's Columns / Filters buttons and the header filter's operator button had no background. The reset's background and border now have zero specificity (`:where()`); its font and cursor rules are unchanged. The default-theme baseline (`lib/theme/__baseline__/`) was regenerated: the only differences are those three open / active backgrounds.
13+
- **`bigint` values sort exactly.** Values beyond ±2^53 were compared as their nearest double, so neighbours could tie or swap. When a column holds such a value, its numbers are ranked with an exact comparison (other columns are unchanged).
14+
- **Number filters no longer read `0x10`, `0b1`, `0o7`, `Infinity` or `1e999` typed as text as numbers** (`toNumber` in `lib/utils/values.ts`, which number filters, the number column's quick-filter and sorting coercion share).
15+
- The AI assistant's suggestion pills and change chips were drawn as ellipses: they read `--ogx-border-radius-round`, which is `50%`. They use a fixed pill radius now.
16+
17+
18+
### Internal
19+
20+
- Removed code nothing called: seven pinning helpers (`isColumnPinnable`, `pinColumn`, `unpinColumn`, `getPinnedColumnsWidth`, `pinRow`, `unpinRow`, `getPinnedRowsCount`), `isRowMatchingFilter`, `getDefaultOperator`, `compareRowsBySortModel`, `isSingleCellRange` and the empty `lib/theme/defaultStyles.ts` (none were exported from the package). Removed the CSS rules of nine classes the grid never sets: `ogx--dark`, `ogx--density-compact`, `ogx--density-comfortable`, `ogx--dragging`, `ogx--list-auto`, `ogx--loading`, `ogx__cell--editable`, `ogx__header-cell--focus-visible` and `ogx__menu-icon-btn--active`. CSS variables are kept (they are public tokens).
21+
- Infinite-scroll placeholder rows are drawn through a `skeleton` prop on the internal `Row` instead of a `_isSkeleton` field, which is gone from `GridRowModel` (it was marked internal; the type's index signature still accepts any field).
22+
- The filter panel and the header filter row share their value helpers (`lib/utils/filtering/filterInput.ts`) instead of two copies.
23+
24+
### Documentation
25+
26+
- `docs/API_REFERENCE.md` covers every export of the package: the export option types (`CsvExportOptions`, `JsonExportOptions`, `ExcelExportOptions`, `ExcelAdvancedExportOptions`, `ExcelSheetDefinition`, `ExcelColumnStyle`), the theme part types and `DataGridThemeProviderProps`, and `GridAlignment`, `GridSortDirection`, `GridSortModel`, `GridPinnedPosition`.
27+
28+
---
29+
830
## [3.8.0] — 2026-10-13
931

1032
### Performance

‎docs/API_REFERENCE.md‎

Lines changed: 28 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -546,6 +546,21 @@ In every exporter, a non-empty `selectedRows` takes precedence over `groupedRows
546546

547547
Every exporter takes `columns` typed for your rows (`GridColDef<R>[]`) or untyped (`GridColDef[]`), and its options also accept `getRowId?: (row: R) => GridRowId`. Pass the grid's `getRowId` when you use one: `selectedRows` holds those ids, and since v3.0 the grid no longer copies them onto `row.id`.
548548

549+
### Export option types
550+
551+
Each exporter's options are exported as a type. Fields common to all of them: `fileName`, `selectedRows`, `getRowId`, `aggregationResult`, `aggregationModel`, `groupedRows`.
552+
553+
| Type | For | Its own fields |
554+
| :--- | :--- | :--- |
555+
| `CsvExportOptions<R>` | `exportToCsv` | `includeHeaders`, `delimiter`, `escapeFormulas`, `bom` |
556+
| `JsonExportOptions<R>` | `exportToJson` | `pretty` |
557+
| `ExcelExportOptions<R>` | `exportToExcel` (HTML `.xls`) | `sheetName`, `includeHeaders`, `escapeFormulas` |
558+
| `ExcelAdvancedExportOptions<R>` | `exportToExcelAdvanced` (`.xlsx`) | `sheets`, `columnStyles`, `headerFillColor`, `headerTextColor`, `headerFontSize`, `bodyFontSize` |
559+
| `ExcelSheetDefinition` | one entry of `sheets` | `name`, `rows` (`'all'` / `'selected'`), `includeHeaders`, `includeSummary`, `autoFilter`, `frozenHeader`, `alternateRowColor`; `{ type: 'summary', name? }` adds a totals sheet |
560+
| `ExcelColumnStyle` | a value of `columnStyles` (by field) | `numFmt` (e.g. `'$#,##0.00'`), `width`, `alignment`, `embedImage`, `imageWidth`, `imageHeight` |
561+
562+
`PdfExportOptions` and `PrintOptions` are described in [PDF Export](features/pdf-export.md) and the [Export Guide](features/export-guide.md).
563+
549564
---
550565

551566
## 🤖 AI Toolkit (`@opencorestack/opengridx/ai`)
@@ -652,6 +667,10 @@ Context provider for overriding the grid's visual system.
652667
- **`overlays`**: colours (`background`, `text`, `border`, `shadow`, `item*`) and, v3.7, `fontFamily`, `fontWeight`, `fontSize` for menus and panels.
653668
- **`toolbar`**, **`scrollbar`** (`thumbColor`, `trackColor`, `size`), **`skeleton`** (`baseColor`, `highlightColor`), **`transitions`**.
654669

670+
#### Theme types
671+
672+
`DataGridThemeProviderProps`: `theme: GridTheme`, `children`, `className?`, `style?` (both on the wrapper element). Each key of `GridTheme` has its own exported type, for building a theme in parts: `GridThemeColors` (with `GridThemeGrayScale` for `gray`), `GridThemeTypography`, `GridThemeSpacing`, `GridThemeBorders`, `GridThemeShadows`, `GridThemeGrid`, `GridThemeOverlays`, `GridThemeToolbar`, `GridThemeScrollbar`, `GridThemeSkeleton`, `GridThemeTransitions`. Every field is optional.
673+
655674
Presets: `darkTheme`, `roseTheme`, `emeraldTheme`, `amberTheme`, `compactTheme`. See [Theming](customization/theming.md).
656675

657676
---
@@ -836,6 +855,15 @@ If the key can change while the grid stays mounted, remount the grid with it (`<
836855

837856
## ⚙️ Interfaces & Types
838857

858+
### Small shared types
859+
860+
| Type | Definition | Used by |
861+
| :--- | :--- | :--- |
862+
| `GridAlignment` | `'left' \| 'center' \| 'right'` | `GridColDef.align`, `headerAlign` |
863+
| `GridSortDirection` | `'asc' \| 'desc' \| null` | a column's sort state (`null`: unsorted) |
864+
| `GridSortModel` | `{ field: string; sort: GridSortDirection }`: like `GridSortItem`, but `sort` may be `null` | a single column's sort state |
865+
| `GridPinnedPosition` | `'left' \| 'right'` (logical: inline start / end in RTL) | column pinning |
866+
839867
### `GridSortItem`
840868
```typescript
841869
interface GridSortItem {

‎docs/superpowers/plans/2026-10-13-audit-tracker.md‎

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -20,8 +20,8 @@ Release plan:
2020
| B7 | Low–Med | Duplicate row ids silently drop rows (no dev warning) | row store | later | ⬜ | |
2121
| B8 | Low | Quick filter stale on in-place row mutation | quick-filter cache | later | ⏸ | Inherent to the per-row text cache; documented in `docs/features/filtering.md` |
2222
| B9 | Low | Quick filter stale when a formatter closure changes | quick-filter cache | later | ⏸ | Inherent to the cache; documented (pass new column definitions) |
23-
| B10 | Low | `bigint` loses precision in sort | `lib/utils/sorting/index.ts:45` | later | ⬜ | |
24-
| B11 | Low | Number filters accept `0x10`, `Infinity` | `lib/utils/values.ts:96-101` | later | ⬜ | |
23+
| B10 | Low | `bigint` loses precision in sort | `lib/utils/sorting/index.ts:45` | later | ✅ | Exact re-ranking (`rankNumbersExactly`, `compareExact`) when a column has an unsafe bigint; generic path tie-breaks by `big` |
24+
| B11 | Low | Number filters accept `0x10`, `Infinity` | `lib/utils/values.ts:96-101` | later | ✅ | `toNumber` rejects radix prefixes and non-finite text; new `values.test.ts` |
2525

2626
## Performance
2727

@@ -41,14 +41,14 @@ Baselines (Chromium, M1, 1M rows): edit 508 ms · paste/undo/redo ~790 ms · fil
4141

4242
| ID | Item | Effort | Status | Notes |
4343
| :- | :--- | :----- | :----- | :---- |
44-
| R1 | Remove dead code: `lib/theme/defaultStyles.ts`, 12 unused util exports, 9 never-emitted CSS classes, 27 unread CSS vars; decide on `QuickFilter` CSS | S | ⬜ | `ogx__` classes are public API — check before removing |
45-
| R2 | Shared filter-value helper for FilterPanel + HeaderFilterCell (6 valueOptions readers) | S–M | ⬜ | |
46-
| R3 | Stop writing `_isSkeleton` onto rows | M | ⬜ | v3 "never modify rows" rule |
44+
| R1 | Remove dead code: `lib/theme/defaultStyles.ts`, 12 unused util exports, 9 never-emitted CSS classes, 27 unread CSS vars; decide on `QuickFilter` CSS | S | ✅ | 11 dead functions + `defaultStyles.ts` removed; 9 never-set class rules removed; CSS vars kept (public tokens); theme baseline unchanged |
45+
| R2 | Shared filter-value helper for FilterPanel + HeaderFilterCell (6 valueOptions readers) | S–M | ✅ | `lib/utils/filtering/filterInput.ts` (4 helpers) used by FilterPanel + HeaderFilterCell |
46+
| R3 | Stop writing `_isSkeleton` onto rows | M | ✅ | `Row` `skeleton` prop; `_isSkeleton` removed from `GridRowModel` and editing/spanning |
4747
| R4 | Reduce ~41 `as unknown as` casts (internal column type) | L | ⬜ | |
4848
| R5 | Split files >600 lines (`GridToolbar.tsx` 855, …) | M each | ⬜ | |
4949
| R6 | Narrow wide hook interfaces (keyboard nav: 31 params) | L | ⬜ | |
5050
| R7 | Route ~70 hard-coded English strings through `localeText` | M | ⬜ | new public keys → minor release |
51-
| R8 | Document 24 exports missing from `docs/API_REFERENCE.md` | S | ⬜ | |
51+
| R8 | Document 24 exports missing from `docs/API_REFERENCE.md` | S | ✅ | All 23 missing exports documented in `API_REFERENCE.md` |
5252

5353
## Log
5454

@@ -61,3 +61,5 @@ Baselines (Chromium, M1, 1M rows): edit 508 ms · paste/undo/redo ~790 ms · fil
6161
- 2026-10-13 — P2 done (`getRowIndex` cache): 1M edit ~35 ms, paste ~45 ms, fill ~50 ms. P5: group toggle done; select-all left at ~270 ms (array model API). P7 dropped (already per-row). B8/B9 documented. CHANGELOG 3.8.0 entry drafted. Browser suite running.
6262
- 2026-10-13 — Guardrails for the in-place store: doc comment on `GridInternalState.rows`, StrictMode paste/undo/redo test (`DataGrid.storeInPlace.test.tsx`), CLAUDE.md v3.8.0 rules. Browser suite 579/579.
6363
- 2026-10-13 — CI green on `release/3.8.0` (run 38366056106). Released 3.8.0.
64+
- 2026-10-13 — 3.8.0 published. Branch `release/3.8.1`. UI fix first (user report, AI panel in dark mode): reset `.ogx button:not(.ogx-menu-item)` out-ranked component button classes; background/border moved under `:where()`, chips' 50% radius fixed, theme baseline regenerated (3 open/active backgrounds). Next: cleanup B10, B11, R1, R2, R3, R8.
65+
- 2026-10-13 — 3.8.1 batch done locally: B10, B11, R1, R2, R3, R8 (+ the button-reset UI fix). Unit 1953 pass.

‎lib/components/AiAssistant/GridAiAssistantPanel.css‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@
7171
.ogx-ai-panel__suggestion {
7272
padding: 3px 10px;
7373
border: 1px solid var(--ogx-border-color, var(--ogx-grid-border-color));
74-
border-radius: var(--ogx-border-radius-round, 999px);
74+
border-radius: 999px;
7575
background: var(--ogx-grid-header-background);
7676
color: inherit;
7777
font: inherit;
@@ -119,7 +119,7 @@
119119
align-items: center;
120120
gap: 4px;
121121
padding: 2px 4px 2px 10px;
122-
border-radius: var(--ogx-border-radius-round, 999px);
122+
border-radius: 999px;
123123
background: var(--ogx-color-primary-light, #e0e7ff);
124124
color: var(--ogx-color-primary-dark, #1e3a8a);
125125
}

‎lib/components/Cell/Cell.css‎

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -27,9 +27,7 @@
2727
outline: 2px solid var(--ogx-grid-cell-focus-border, var(--ogx-color-primary, #2563eb));
2828
outline-offset: -2px;
2929
}
30-
.ogx__cell--editable {
31-
cursor: text;
32-
}
30+
3331
/*
3432
* Cell range selection (cellSelection, v3.3). The tint is a background image, so it also covers
3533
* pinned cells' own background; the outline is an inset box-shadow, so the layout never shifts.

‎lib/components/ColumnGroupHeader/ColumnGroupHeader.css‎

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,6 @@
6767
}
6868

6969
/* ─── Dark-mode overrides ────────────────────────────────────────────────────*/
70-
[data-theme="dark"] .ogx-col-group-cell__label,
71-
.ogx--dark .ogx-col-group-cell__label {
70+
[data-theme="dark"] .ogx-col-group-cell__label {
7271
color: var(--ogx-color-gray-300, #cbd5e1);
7372
}

‎lib/components/DataGrid/DataGrid.css‎

Lines changed: 1 addition & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -67,24 +67,7 @@
6767
background: var(--ogx-grid-background);
6868
box-shadow: 0 -4px 6px -1px rgba(0, 0, 0, 0.05);
6969
}
70-
.ogx--loading {
71-
opacity: 0.6;
72-
pointer-events: none;
73-
}
74-
.ogx--loading::after {
75-
content: '';
76-
position: absolute;
77-
top: 0;
78-
left: 0;
79-
right: 0;
80-
bottom: 0;
81-
background: color-mix(in srgb, var(--ogx-grid-background) 60%, transparent);
82-
backdrop-filter: blur(2px);
83-
display: flex;
84-
align-items: center;
85-
justify-content: center;
86-
z-index: var(--ogx-z-index-modal);
87-
}
70+
8871
/* No height prop: fill the container, as a block child of a sized box (height: 100%) or as a
8972
flex item (flex: 1 with min-height: 0). In an auto-height parent 100% resolves to auto. */
9073
.ogx--fill {
@@ -312,16 +295,6 @@
312295
text-overflow: ellipsis;
313296
}
314297

315-
.ogx--density-compact .ogx__cell,
316-
.ogx--density-compact .ogx__header-cell {
317-
padding: var(--ogx-spacing-xs) var(--ogx-spacing-sm);
318-
font-size: var(--ogx-font-size-xs);
319-
}
320-
.ogx--density-comfortable .ogx__cell,
321-
.ogx--density-comfortable .ogx__header-cell {
322-
padding: var(--ogx-spacing-md) var(--ogx-spacing-lg);
323-
font-size: var(--ogx-font-size-md);
324-
}
325298
.ogx__group-cell-content {
326299
font-weight: 500;
327300
text-align: start;

‎lib/components/DataGrid/DataGrid.spanning.test.tsx‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -180,7 +180,7 @@ describe('DataGrid cell spanning', () => {
180180
seen.length = 0;
181181
rerender(<Grid page={1} />);
182182
await act(async () => { await vi.advanceTimersByTimeAsync(350); });
183-
expect(seen.filter(r => r._isSkeleton)).toEqual([]);
183+
expect(seen.filter(r => String(r.id).startsWith('__skeleton_'))).toEqual([]);
184184
} finally {
185185
vi.useRealTimers();
186186
}

‎lib/components/DataGrid/GridVirtualRows.tsx‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -228,7 +228,8 @@ export function GridVirtualRows<R extends GridRowModel>({
228228
{Array.from({ length: infiniteScrollSkeletonCount }).map((_, i) => (
229229
<Row<R>
230230
key={`__skeleton_${i}__`}
231-
row={{ id: `__skeleton_${i}__`, _isSkeleton: true } as unknown as R}
231+
row={{ id: `__skeleton_${i}__` } as unknown as R}
232+
skeleton
232233
columns={virtualColumns}
233234
rowIndex={unpinnedRowsLength + i}
234235
rowHeight={rowHeight}

‎lib/components/FilterPanel/FilterPanel.tsx‎

Lines changed: 7 additions & 39 deletions
Original file line numberDiff line numberDiff line change
@@ -7,9 +7,9 @@ import type {
77
GridFilterOperator
88
} from '../../types';
99
import { filterValueToInputText, getOperatorsForType, NO_VALUE_OPERATORS } from '../../utils/filtering';
10+
import { filterValueFromInputText, getFilterValueOptions, isSameFilterValue, matchesFilterValueOption } from '../../utils/filtering/filterInput';
1011
import { Input } from '../ui/Input';
1112

12-
1313
export interface FilterPanelProps {
1414
filterModel: GridFilterModel;
1515
columns: GridColDef[];
@@ -29,17 +29,10 @@ function getActiveFilter(items: readonly FilterEntry[], field: string): GridFilt
2929
return items.find((entry): entry is GridFilterItem => isFilterItem(entry) && entry.field === field);
3030
}
3131

32-
function sameValue(a: unknown, b: unknown): boolean {
33-
if (Object.is(a, b)) return true;
34-
if (a instanceof Date && b instanceof Date) return a.getTime() === b.getTime();
35-
if (Array.isArray(a) && Array.isArray(b)) return a.length === b.length && a.every((v, i) => sameValue(v, b[i]));
36-
return false;
37-
}
38-
3932
function sameEntry(a: FilterEntry, b: FilterEntry): boolean {
4033
if (a === b) return true;
4134
if (isFilterItem(a) && isFilterItem(b)) {
42-
return a.id === b.id && a.field === b.field && a.operator === b.operator && sameValue(a.value, b.value);
35+
return a.id === b.id && a.field === b.field && a.operator === b.operator && isSameFilterValue(a.value, b.value);
4336
}
4437
if (!isFilterItem(a) && !isFilterItem(b)) {
4538
return a.id === b.id && a.logicOperator === b.logicOperator && sameEntries(a.items, b.items);
@@ -52,36 +45,11 @@ function sameEntries(a: readonly FilterEntry[], b: readonly FilterEntry[]): bool
5245
return a.length === b.length && a.every((entry, i) => sameEntry(entry, b[i]));
5346
}
5447

55-
interface ValueOption {
56-
key: string;
57-
value: unknown;
58-
label: string;
59-
}
60-
61-
function getValueOptions(col: GridColDef): ValueOption[] {
62-
return (col.valueOptions ?? []).map((option, index) => (
63-
option !== null && typeof option === 'object'
64-
? { key: String(index), value: option.value, label: option.label }
65-
: { key: String(index), value: option, label: String(option) }
66-
));
67-
}
68-
69-
function matchesOption(option: ValueOption, value: unknown): boolean {
70-
if (Object.is(option.value, value)) return true;
71-
return value != null && String(option.value).toLowerCase() === String(value).toLowerCase();
72-
}
73-
7448
/** Text shown in the value input for a committed value. Never used to emit anything. */
7549
function toInputText(value: unknown, col: GridColDef): string {
7650
return filterValueToInputText(value, col.type);
7751
}
7852

79-
/** The item value for typed text. isAnyOf takes a comma-separated list. */
80-
function fromInputText(text: string, operator: GridFilterOperator): unknown {
81-
if (operator === 'isAnyOf') return text.split(',').map(part => part.trim()).filter(part => part !== '');
82-
return text;
83-
}
84-
8553
/** Carry a value over to a newly picked operator: lists for isAnyOf, scalars for the rest. */
8654
function convertValueForOperator(value: unknown, operator: GridFilterOperator): unknown {
8755
if (NO_VALUE_OPERATORS.has(operator)) return undefined;
@@ -144,7 +112,7 @@ const FilterRow: React.FC<{
144112
const unchanged = current ? text === toInputText(current.value, colRef.current) : text.trim() === '';
145113
if (unchanged) return;
146114
const operator = current?.operator ?? defaultOperator;
147-
onChangeRef.current(buildItem(operator, fromInputText(text, operator)));
115+
onChangeRef.current(buildItem(operator, filterValueFromInputText(text, operator)));
148116
}, [defaultOperator, buildItem]);
149117

150118
// Text still waiting for the debounce; flushed when the panel closes (unmounts) meanwhile.
@@ -172,7 +140,7 @@ const FilterRow: React.FC<{
172140

173141
const handleOperatorChange = (op: GridFilterOperator) => {
174142
// Keep what the user typed even if the debounce has not committed it yet.
175-
const value = draft !== null ? fromInputText(draft, op) : item?.value;
143+
const value = draft !== null ? filterValueFromInputText(draft, op) : item?.value;
176144
setDraft(null);
177145
onChange(buildItem(op, convertValueForOperator(value, op)));
178146
};
@@ -183,7 +151,7 @@ const FilterRow: React.FC<{
183151
};
184152

185153
const showValue = !NO_VALUE_OPERATORS.has(currentOperator);
186-
const valueOptions = getValueOptions(col);
154+
const valueOptions = getFilterValueOptions(col);
187155
const valueClassName = `ogx-filter__value-input${isActive ? ' ogx-filter__value-input--active' : ''}`;
188156
const valueLabel = `Filter value for ${label}`;
189157

@@ -215,7 +183,7 @@ const FilterRow: React.FC<{
215183
className={`${valueClassName} ogx-filter__value-multiselect`}
216184
multiple
217185
size={Math.min(valueOptions.length, 4)}
218-
value={valueOptions.filter(o => selected.some(v => matchesOption(o, v))).map(o => o.key)}
186+
value={valueOptions.filter(o => selected.some(v => matchesFilterValueOption(o, v))).map(o => o.key)}
219187
onChange={(e) => {
220188
const keys = new Set(Array.from(e.target.selectedOptions, option => option.value));
221189
onChange(buildItem('isAnyOf', valueOptions.filter(o => keys.has(o.key)).map(o => o.value)));
@@ -226,7 +194,7 @@ const FilterRow: React.FC<{
226194
</select>
227195
);
228196
} else if (showValue && col.type === 'singleSelect' && valueOptions.length > 0 && (currentOperator === 'is' || currentOperator === 'not')) {
229-
const current = valueOptions.find(o => matchesOption(o, item?.value));
197+
const current = valueOptions.find(o => matchesFilterValueOption(o, item?.value));
230198
valueControl = (
231199
<select
232200
id={`${filterId}-val`}

0 commit comments

Comments
 (0)