You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit 9df3583
Browse filesBrowse the repository at this point in the historyBrowse files
fix: let grid buttons keep their own styles; exact bigint sort; cleanup
- Move the button reset's background and border under :where() so component
classes win (AI panel Ask / suggestions / Undo, open toolbar buttons);
regenerate the default-theme baseline
- Give the AI panel's pills and chips a fixed pill radius
- Sort bigints beyond 2^53 exactly
- toNumber rejects radix prefixes and non-finite text
- Remove unused helpers, an empty module and CSS for classes the grid never sets
- Draw infinite-scroll placeholders through a Row prop instead of _isSkeleton
- Share the filter value helpers between the filter panel and header filters
- Document every package export in API_REFERENCE
Copy file name to clipboardExpand all lines: CHANGELOG.md
+22Lines changed: 22 additions & 0 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -5,6 +5,28 @@
5
5
6
6
---
7
7
8
+
## [Unreleased — 3.8.1]
9
+
10
+
### Fixed
11
+
12
+
-**Buttons inside the grid show their own background and border again.** A reset rule from the first release (`.ogx button:not(.ogx-menu-item)`) out-ranked the buttons' own classes and removed their background and border: the AI assistant's Ask button had no fill (dark text on the dark panel in dark mode), its suggestions and the Undo / microphone buttons had no outline, and the open or active states of the toolbar's Columns / Filters buttons and the header filter's operator button had no background. The reset's background and border now have zero specificity (`:where()`); its font and cursor rules are unchanged. The default-theme baseline (`lib/theme/__baseline__/`) was regenerated: the only differences are those three open / active backgrounds.
13
+
-**`bigint` values sort exactly.** Values beyond ±2^53 were compared as their nearest double, so neighbours could tie or swap. When a column holds such a value, its numbers are ranked with an exact comparison (other columns are unchanged).
14
+
-**Number filters no longer read `0x10`, `0b1`, `0o7`, `Infinity` or `1e999` typed as text as numbers** (`toNumber` in `lib/utils/values.ts`, which number filters, the number column's quick-filter and sorting coercion share).
15
+
- The AI assistant's suggestion pills and change chips were drawn as ellipses: they read `--ogx-border-radius-round`, which is `50%`. They use a fixed pill radius now.
16
+
17
+
18
+
### Internal
19
+
20
+
- Removed code nothing called: seven pinning helpers (`isColumnPinnable`, `pinColumn`, `unpinColumn`, `getPinnedColumnsWidth`, `pinRow`, `unpinRow`, `getPinnedRowsCount`), `isRowMatchingFilter`, `getDefaultOperator`, `compareRowsBySortModel`, `isSingleCellRange` and the empty `lib/theme/defaultStyles.ts` (none were exported from the package). Removed the CSS rules of nine classes the grid never sets: `ogx--dark`, `ogx--density-compact`, `ogx--density-comfortable`, `ogx--dragging`, `ogx--list-auto`, `ogx--loading`, `ogx__cell--editable`, `ogx__header-cell--focus-visible` and `ogx__menu-icon-btn--active`. CSS variables are kept (they are public tokens).
21
+
- Infinite-scroll placeholder rows are drawn through a `skeleton` prop on the internal `Row` instead of a `_isSkeleton` field, which is gone from `GridRowModel` (it was marked internal; the type's index signature still accepts any field).
22
+
- The filter panel and the header filter row share their value helpers (`lib/utils/filtering/filterInput.ts`) instead of two copies.
23
+
24
+
### Documentation
25
+
26
+
-`docs/API_REFERENCE.md` covers every export of the package: the export option types (`CsvExportOptions`, `JsonExportOptions`, `ExcelExportOptions`, `ExcelAdvancedExportOptions`, `ExcelSheetDefinition`, `ExcelColumnStyle`), the theme part types and `DataGridThemeProviderProps`, and `GridAlignment`, `GridSortDirection`, `GridSortModel`, `GridPinnedPosition`.
Copy file name to clipboardExpand all lines: docs/API_REFERENCE.md
+28Lines changed: 28 additions & 0 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -546,6 +546,21 @@ In every exporter, a non-empty `selectedRows` takes precedence over `groupedRows
546
546
547
547
Every exporter takes `columns` typed for your rows (`GridColDef<R>[]`) or untyped (`GridColDef[]`), and its options also accept `getRowId?: (row: R) => GridRowId`. Pass the grid's `getRowId` when you use one: `selectedRows` holds those ids, and since v3.0 the grid no longer copies them onto `row.id`.
548
548
549
+
### Export option types
550
+
551
+
Each exporter's options are exported as a type. Fields common to all of them: `fileName`, `selectedRows`, `getRowId`, `aggregationResult`, `aggregationModel`, `groupedRows`.
|`ExcelSheetDefinition`| one entry of `sheets`|`name`, `rows` (`'all'` / `'selected'`), `includeHeaders`, `includeSummary`, `autoFilter`, `frozenHeader`, `alternateRowColor`; `{ type: 'summary', name? }` adds a totals sheet |
560
+
|`ExcelColumnStyle`| a value of `columnStyles` (by field) |`numFmt` (e.g. `'$#,##0.00'`), `width`, `alignment`, `embedImage`, `imageWidth`, `imageHeight`|
561
+
562
+
`PdfExportOptions` and `PrintOptions` are described in [PDF Export](features/pdf-export.md) and the [Export Guide](features/export-guide.md).
563
+
549
564
---
550
565
551
566
## 🤖 AI Toolkit (`@opencorestack/opengridx/ai`)
@@ -652,6 +667,10 @@ Context provider for overriding the grid's visual system.
652
667
-**`overlays`**: colours (`background`, `text`, `border`, `shadow`, `item*`) and, v3.7, `fontFamily`, `fontWeight`, `fontSize` for menus and panels.
`DataGridThemeProviderProps`: `theme: GridTheme`, `children`, `className?`, `style?` (both on the wrapper element). Each key of `GridTheme` has its own exported type, for building a theme in parts: `GridThemeColors` (with `GridThemeGrayScale` for `gray`), `GridThemeTypography`, `GridThemeSpacing`, `GridThemeBorders`, `GridThemeShadows`, `GridThemeGrid`, `GridThemeOverlays`, `GridThemeToolbar`, `GridThemeScrollbar`, `GridThemeSkeleton`, `GridThemeTransitions`. Every field is optional.
673
+
655
674
Presets: `darkTheme`, `roseTheme`, `emeraldTheme`, `amberTheme`, `compactTheme`. See [Theming](customization/theming.md).
656
675
657
676
---
@@ -836,6 +855,15 @@ If the key can change while the grid stays mounted, remount the grid with it (`<
Copy file name to clipboardExpand all lines: docs/superpowers/plans/2026-10-13-audit-tracker.md
+8-6Lines changed: 8 additions & 6 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -20,8 +20,8 @@ Release plan:
20
20
| B7 | Low–Med | Duplicate row ids silently drop rows (no dev warning) | row store | later | ⬜ ||
21
21
| B8 | Low | Quick filter stale on in-place row mutation | quick-filter cache | later | ⏸ | Inherent to the per-row text cache; documented in `docs/features/filtering.md`|
22
22
| B9 | Low | Quick filter stale when a formatter closure changes | quick-filter cache | later | ⏸ | Inherent to the cache; documented (pass new column definitions) |
23
-
| B10 | Low |`bigint` loses precision in sort |`lib/utils/sorting/index.ts:45`| later |⬜ ||
24
-
| B11 | Low | Number filters accept `0x10`, `Infinity`|`lib/utils/values.ts:96-101`| later |⬜ ||
23
+
| B10 | Low |`bigint` loses precision in sort |`lib/utils/sorting/index.ts:45`| later |✅ | Exact re-ranking (`rankNumbersExactly`, `compareExact`) when a column has an unsafe bigint; generic path tie-breaks by `big`|
24
+
| B11 | Low | Number filters accept `0x10`, `Infinity`|`lib/utils/values.ts:96-101`| later |✅ |`toNumber` rejects radix prefixes and non-finite text; new `values.test.ts`|
25
25
26
26
## Performance
27
27
@@ -41,14 +41,14 @@ Baselines (Chromium, M1, 1M rows): edit 508 ms · paste/undo/redo ~790 ms · fil
41
41
42
42
| ID | Item | Effort | Status | Notes |
43
43
| :- | :--- | :----- | :----- | :---- |
44
-
| R1 | Remove dead code: `lib/theme/defaultStyles.ts`, 12 unused util exports, 9 never-emitted CSS classes, 27 unread CSS vars; decide on `QuickFilter` CSS | S |⬜|`ogx__` classes are public API — check before removing|
| R7 | Route ~70 hard-coded English strings through `localeText`| M | ⬜ | new public keys → minor release |
51
-
| R8 | Document 24 exports missing from `docs/API_REFERENCE.md`| S |⬜ ||
51
+
| R8 | Document 24 exports missing from `docs/API_REFERENCE.md`| S |✅ | All 23 missing exports documented in `API_REFERENCE.md`|
52
52
53
53
## Log
54
54
@@ -61,3 +61,5 @@ Baselines (Chromium, M1, 1M rows): edit 508 ms · paste/undo/redo ~790 ms · fil
61
61
- 2026-10-13 — P2 done (`getRowIndex` cache): 1M edit ~35 ms, paste ~45 ms, fill ~50 ms. P5: group toggle done; select-all left at ~270 ms (array model API). P7 dropped (already per-row). B8/B9 documented. CHANGELOG 3.8.0 entry drafted. Browser suite running.
62
62
- 2026-10-13 — Guardrails for the in-place store: doc comment on `GridInternalState.rows`, StrictMode paste/undo/redo test (`DataGrid.storeInPlace.test.tsx`), CLAUDE.md v3.8.0 rules. Browser suite 579/579.
63
63
- 2026-10-13 — CI green on `release/3.8.0` (run 38366056106). Released 3.8.0.
64
+
- 2026-10-13 — 3.8.0 published. Branch `release/3.8.1`. UI fix first (user report, AI panel in dark mode): reset `.ogx button:not(.ogx-menu-item)` out-ranked component button classes; background/border moved under `:where()`, chips' 50% radius fixed, theme baseline regenerated (3 open/active backgrounds). Next: cleanup B10, B11, R1, R2, R3, R8.
0 commit comments