From 0f28f4ed7abe33cd0b8f8fe165492ea83fd1ed42 Mon Sep 17 00:00:00 2001 From: Alajmah <55954113+Alajmah@users.noreply.github.com> Date: Sat, 21 Nov 2026 02:47:15 +0300 Subject: [PATCH] fix(4): remove self-replacing no-op in custom-rules page URL MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit CodeQL js/identity-replacement #4 remediation (custom-rules/page.tsx:63): .replace("/api/config/", "/api/config/") replaced a value with itself — dead code flagged by the identity-replacement query as an unfinished edit. The generated URL was and remains /api/config/{owner}/{repo}/custom-rules, resolving against the live backend route configRouter.get('/:owner/:repo/custom-rules') (config.js:238). Regression (api-urls.test.ts): pins repoConfig(owner, repo) + '/custom-rules' === '/api/config/o/r/custom-rules' so the URL cannot drift silently when the no-op is removed. Full dashboard suite green. Signed-off-by: Alajmah <55954113+Alajmah@users.noreply.github.com> --- packages/web-dashboard/src/app/custom-rules/page.tsx | 2 +- packages/web-dashboard/tests/api-urls.test.ts | 9 +++++++++ 2 files changed, 10 insertions(+), 1 deletion(-) diff --git a/packages/web-dashboard/src/app/custom-rules/page.tsx b/packages/web-dashboard/src/app/custom-rules/page.tsx index c9bd35bb..d2dcc6fe 100644 --- a/packages/web-dashboard/src/app/custom-rules/page.tsx +++ b/packages/web-dashboard/src/app/custom-rules/page.tsx @@ -60,7 +60,7 @@ export default function CustomRulesPage() { ? API.repoConfig( selectedRepo.split("/")[0], selectedRepo.split("/")[1] - ).replace("/api/config/", "/api/config/") + "/custom-rules" + ) + "/custom-rules" : null, fetcher ); diff --git a/packages/web-dashboard/tests/api-urls.test.ts b/packages/web-dashboard/tests/api-urls.test.ts index 3bbb055d..afd21ea3 100644 --- a/packages/web-dashboard/tests/api-urls.test.ts +++ b/packages/web-dashboard/tests/api-urls.test.ts @@ -15,6 +15,15 @@ describe('API URL builders', () => { expect(API.repos('page=2&limit=10')).toBe('/api/repos?page=2&limit=10'); }); + // CodeQL #4 regression: the custom-rules page constructs its URL as + // API.repoConfig(owner, repo) + '/custom-rules' (a self-replacing no-op + // .replace('/api/config/', '/api/config/') was removed). This pins the + // generated URL against the live backend route + // configRouter.get('/:owner/:repo/custom-rules'). + test('custom-rules page URL: repoConfig + /custom-rules unchanged', () => { + expect(API.repoConfig('o', 'r') + '/custom-rules').toBe('/api/config/o/r/custom-rules'); + }); + test('repo detail path', () => { expect(API.repo('o', 'r')).toBe('/api/repos/o/r'); });