Using setUserField might lead to an unbounded number of keys

[nesro]

Hi Julian,

as I was debugging my changes for #125

I've noticed that this line:

await db.setObjectField(`${payload.name}Id:uid`, payload.oAuthid, uid);

( https://github.com/NodeBB/nodebb-plugin-sso-oauth2-multiple/blob/main/library.js#L251 ) will add a key to a single mongo document for each user.

I'm afraid that when there will be hundreds of thousands users, things might be slow or even break. Is my concern valid, or is it handled somewhere?

Thanks,
Tomas

[barisusakli]

Mongodb has a limit on document size I believe it was 16mb so if the document grows that much it will stop working. A safer approach would be to add them to a zset, with db.sortedSetAdd(${payload.name}Id:uid, oAuthid, uid) as long as uids are integer nodebb uids this will work.

[julianlam]

Ok to refactor, it's a potential concern but one that would take a very very long time to reach...

[nesro]

Thank you both for responding to this issue.

I think it's not impossible to hit this issue in a NodeBB forum where this is used over few years. But I will check it after a while and estimate when the issue will be hit.

Another concern is how much this will slow down mongo as reading would always load the whole document. And whatever WiredTiger will do with an evergrowing document.