Skip to content

Commit cb97159

Browse files
committed
web: timeline notes only for entries that need explaining; sorted verified lists
1 parent 8925ebe commit cb97159

2 files changed

Lines changed: 13 additions & 7 deletions

File tree

shared/compute.ts

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -177,6 +177,9 @@ function verifiedFor(
177177
list.push(pair.toolchainVersion);
178178
}
179179
}
180+
for (const list of Object.values(result)) {
181+
list.sort((a, b) => semver.rcompare(semver.coerce(a) ?? "0.0.0", semver.coerce(b) ?? "0.0.0"));
182+
}
180183
return result;
181184
}
182185

web/src/components/CellDetails.vue

Lines changed: 10 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -31,16 +31,19 @@ const nodes = computed(() => {
3131
});
3232
const hiddenCount = computed(() => Math.max(0, props.summary.breakdown.length - INITIAL_NODES));
3333
34-
/** Only nodes that need an explanation: the plain "declared" and "nothing known" cases speak for themselves. */
34+
/** Only nodes that need an explanation; plain declared, verified and unknown states speak for themselves. */
3535
const notes = computed(() =>
3636
[...nodes.value].reverse().filter((item) => {
37-
if (item.cell.state === "declared") {
38-
return false;
37+
switch (item.cell.state) {
38+
case "declared":
39+
return false;
40+
case "verified":
41+
return item.cell.reason !== "verified by CI";
42+
case "unverified":
43+
return item.cell.reason !== "no requirement published" && item.cell.reason !== "no data";
44+
default:
45+
return true;
3946
}
40-
if (item.cell.state === "unverified") {
41-
return item.cell.reason.startsWith("newer than");
42-
}
43-
return true;
4447
}),
4548
);
4649

0 commit comments

Comments
 (0)