From cc500ed86692e189c45365de55fe770c001d82c9 Mon Sep 17 00:00:00 2001 From: Anil Balireddy Date: Fri, 11 Sep 2026 09:58:24 -0700 Subject: [PATCH] Remove dead document_grounded_sdg registration of GenselectAnswersStage GenselectAnswersStage was registered twice: once for recipe=finance/workflow=template_based_sdg (still used, see template-based-sdg*.yaml), and once for recipe=finance/workflow=document_grounded_sdg. The second registration is unreachable -- every document-grounded-sdg workflow YAML uses gym_genselect_answers instead (a separate stage registered in nvflow/generic_stage/sdg/document_grounded/__init__.py), and document-grounded-sdg.yaml's own comment says gym_genselect_answers "replaces genselect_answers for DG-SDG". No config anywhere references finance.document_grounded_sdg.genselect_answers, and the stage's own docs (docs/recipes/finance/stages/template-based-sdg.md) only document the template_based_sdg registration. Verified via `nflow list-stages --recipe finance --workflow document_grounded_sdg`: the 7 registered stages are unchanged before and after (dg_sdg_preprocess, generate_verified_questions, generate_answers, gym_genselect_answers, evaluate_answers, aggregate_answers, dgsdg_post_process), matching the documented pipeline in docs/development/sdg/document_grounded/ADDING_A_DOMAIN.md. Co-Authored-By: Claude Sonnet 5 Signed-off-by: Anil Balireddy --- nvflow/recipes/finance/stages/sdg/genselect_answers.py | 5 ----- 1 file changed, 5 deletions(-) diff --git a/nvflow/recipes/finance/stages/sdg/genselect_answers.py b/nvflow/recipes/finance/stages/sdg/genselect_answers.py index 58c2da5..54a1182 100644 --- a/nvflow/recipes/finance/stages/sdg/genselect_answers.py +++ b/nvflow/recipes/finance/stages/sdg/genselect_answers.py @@ -22,11 +22,6 @@ @StageRegistry.register(recipe="finance", workflow="template_based_sdg", stage="genselect_answers") -@StageRegistry.register( - recipe="finance", - workflow="document_grounded_sdg", - stage="genselect_answers", -) class GenselectAnswersStage(BaseStage): """Generate and select best answers using parallel thinking."""