Skip to content

Drop nhc_zero_eta_dot workaround in MTK NPT integrator once toolkit-ops > 0.3.1 ships #91

Description

@Ryan-Reese

The MTK NPT integrator carries a nhc_zero_eta_dot permanent-zero buffer that is passed to npt_barostat_half_step to mute the kernel's incorrect −eta_dot · h_dot drag. Canonical MTK has no thermostat coupling in the barostat half-step (cell damping comes from the separate b_scale operator), so the kernel API change in NVIDIA/nvalchemi-toolkit-ops#77 drops the eta_dots argument entirely.

Once nvalchemi-toolkit-ops > 0.3.1 ships:

  • Drop the nhc_zero_eta_dot buffer from _init_state and _make_new_state.
  • Switch both npt_barostat_half_step(...) calls to the eta_dots-free signature.
  • Remove the # Workaround for nvalchemi-toolkit-ops <= 0.3.1 comments and the npt_barostat_half_step op shim in nvalchemi/dynamics/_ops/npt_nph.py.

Introduced in #90.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions