Skip to content

Commit 61b33ea

Browse files
authored
ci(release): fix Ubuntu Snap canary install and registration (#1699)
Install the Snap built by the triggering Release Dev workflow by setting merge-multiple: true on the artifact download. actions/download-artifact otherwise extracts each artifact into its own subdirectory, leaving the package at release/snap-linux-amd64/*.snap, so the install glob ./release/*.snap matched nothing. Merging flattens the artifact's contents directly into release/ where the dangerous local snap install expects it. Harden the Snap canary setup by enabling snapd.socket, waiting for snap seeding (snap wait system seed.loaded), and running every step with strict shell options (set -euo pipefail) so failures surface immediately. Register the snapped gateway with the CLI as the documented local plaintext snap-docker gateway, and print version and snap services, before running openshell status so the canary verifies a configured and reachable gateway instead of only the install. Signed-off-by: Kris Hicks <khicks@nvidia.com>
1 parent 62c421b commit 61b33ea

1 file changed

Lines changed: 13 additions & 1 deletion

File tree

.github/workflows/release-canary.yml

Lines changed: 13 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -153,12 +153,16 @@ jobs:
153153
steps:
154154
- name: Install snapd
155155
run: |
156+
set -euo pipefail
156157
sudo apt-get update
157158
sudo apt-get install -y snapd
159+
sudo systemctl enable --now snapd.socket
158160
sudo systemctl start snapd
161+
sudo snap wait system seed.loaded
159162
160163
- name: Install Docker snap
161164
run: |
165+
set -euo pipefail
162166
sudo snap install docker
163167
164168
- name: Download snap from release-dev artifacts
@@ -167,20 +171,28 @@ jobs:
167171
run-id: ${{ github.event.workflow_run.id }}
168172
pattern: snap-linux-amd64
169173
path: release/
174+
merge-multiple: true
170175

171176
- name: Install snap (dangerous — from release, not store)
172177
run: |
178+
set -euo pipefail
173179
sudo snap install ./release/*.snap --dangerous
174180
175181
- name: Connect interfaces
176182
run: |
183+
set -euo pipefail
177184
sudo snap connect openshell:docker docker:docker-daemon
178185
sudo snap connect openshell:log-observe
179186
sudo snap connect openshell:system-observe
180187
sudo snap connect openshell:ssh-keys
181188
182-
- name: Check status
189+
- name: Register snap gateway and check status
183190
run: |
191+
set -euo pipefail
192+
openshell --version
193+
sudo snap services openshell
194+
openshell gateway add http://127.0.0.1:17670 --local --name snap-docker
195+
openshell gateway select snap-docker
184196
openshell status
185197
186198
kubernetes:

0 commit comments

Comments
 (0)