[bug] Application does not present its version number to macOS

[ashugg]

Describe the bug "Get Info" on Rustcast.app with the Finder shows version "1.0"

To Reproduce Steps to reproduce the behavior:

1. Go to Applications folder
2. Click on Rustcast
3. Right click and select "Get Info", or ⌘I
4. See error

Expected behavior The version of the application (e.g. 0.8.4) would be displayed here

Additional context Please set CFBundleShortVersionString and/or CFBundleGetInfoString keys in Info.plist

I'm not quite sure about how your build process works, as the current release is version 0.8.4 but the version in Cargo.toml is hard-coded to 0.8.3 - what's the source of truth for the application version? In scripts/build-macos.sh I can't see where $APP_VERSION comes from. If it's unset, then build-macos.sh is not going to update the Info.plist file correctly.

[unsecretised]

APP_VERSION comes from the .github/workflows/release.yml (it's the git tag).

But yes i'll fix this as well.

[ashugg]

Oh thanks. I was just clicking around in the web interface and hadn't picked that up.