Skip to content

Latest commit

 

History

History
201 lines (139 loc) · 6.21 KB

File metadata and controls

201 lines (139 loc) · 6.21 KB

Pull Request

📋 Description

What does this PR do?

Why are these changes needed?

🔧 Type of Change

  • 🐛 Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 📚 Documentation (changes to documentation only)
  • 🎨 Code style (formatting, missing semicolons, etc; no code change)
  • ♻️ Code refactoring (refactoring production code)
  • Performance (changes that improve performance)
  • 🧪 Tests (adding missing tests or correcting existing tests)
  • 🔧 Chore (updating grunt tasks, build process, etc; no production code change)

🔗 Related Issues

  • Closes #
  • Related to #

🧪 Testing

How has this been tested?

  • Unit tests pass locally
  • Manual testing completed
  • Integration testing (if applicable)
  • Cross-platform testing (Windows/macOS/Linux)

Test cases covered:

  • Valid temperature conversions
  • Invalid input handling
  • Edge cases (absolute zero, extreme temperatures)
  • User interface behavior
  • Error messages and validation

New tests added:

  • Added unit tests for new functionality
  • Added integration tests
  • Updated existing tests
  • No new tests required

📸 Screenshots (if applicable)

Before:

After:

📝 Checklist

Code Quality

  • Code follows the project's coding standards
  • Self-review of the code has been performed
  • Code is well-commented, particularly in hard-to-understand areas
  • No debugging code or console logs left in the code
  • Variable and method names are descriptive and follow conventions

Testing & Validation

  • All existing tests pass locally
  • New tests have been added for new functionality
  • Manual testing has been performed
  • Input validation works correctly
  • Error handling is appropriate

Documentation

  • Code documentation (XML comments) has been updated
  • README.md updated (if applicable)
  • CHANGELOG.md updated with changes
  • API documentation updated (if applicable)

Dependencies & Compatibility

  • No new dependencies added, or they are justified and documented
  • Backward compatibility maintained (or breaking changes documented)
  • Cross-platform compatibility verified (.NET Core)
  • Performance impact considered and acceptable

🎯 Performance Impact

  • No performance impact
  • Performance improved
  • Minor performance impact (acceptable)
  • Significant performance impact (documented and justified)

Details:

🔄 Breaking Changes

  • No breaking changes
  • Contains breaking changes (described below)

Breaking Changes Description:

📋 Migration Guide (for breaking changes)

For Users:

For Developers:

🧹 Code Review Checklist

Functionality

  • Changes work as described
  • Edge cases are handled
  • Error scenarios are properly managed
  • User experience is intuitive

Code Quality

  • Code is readable and maintainable
  • Follows established patterns
  • No code duplication
  • Appropriate use of design patterns

Security & Best Practices

  • Input validation is thorough
  • No security vulnerabilities introduced
  • Following .NET best practices
  • Resource management is proper

💬 Additional Notes

Implementation Details:

Known Issues:

Future Improvements:

📚 References


🙋‍♂️ Questions for Reviewers


Thank you for your contribution! 🎉


Please ensure you have read and followed the Contributing Guidelines and Code of Conduct before submitting this PR.