bug: All patches are `Enabled: false` by default

[l205306]

Bug description

v1.5.0

Details

...
Index: 39
Name: Hide ads
Description: Adds options to remove general ads.
Enabled: true

Index: 40
Name: Video ads
Description: Adds an option to remove ads in the video player.
Enabled: true

Index: 41
Name: Copy video URL
Description: Adds options to display buttons in the video player to copy video URLs.
Enabled: true

Index: 42
Name: Remove viewer discretion dialog
Description: Adds an option to remove the dialog that appears when opening a video that has been age-restricted by accepting it automatically. This does not bypass the age restriction.
Enabled: true
...

v1.6.0

Details

...
Index: 39
Name: Hide ads
Description: Adds options to remove general ads.
Enabled: false

Index: 40
Name: Video ads
Description: Adds an option to remove ads in the video player.
Enabled: false

Index: 41
Name: Copy video URL
Description: Adds options to display buttons in the video player to copy video URLs.
Enabled: false

Index: 42
Name: Remove viewer discretion dialog
Description: Adds an option to remove the dialog that appears when opening a video that has been age-restricted by accepting it automatically. This does not bypass the age restriction.
Enabled: false
...

Error logs

Solution

Create an option JSON file and update Enabled: true (?)

Additional context

No response

Acknowledgements

• I have checked all open and closed bug reports and this is not a duplicate.
• I have chosen an appropriate title.

[cyberboh]

How it can be? So weird

[LisoUseInAIKyrios]

Are you generating JSON? Or using CLI without any enable/disable arguments?

[l205306]

java -jar morphe-cli-1.6.0-all.jar list-patches -f com.google.android.youtube --patches patches-1.20.0.mpp

In 1.5.0, only these three patches are Enabled: false

INFO: Index: 0
Name: Override certificate pinning
Description: Overrides certificate pinning, allowing to inspect traffic via a proxy.
Enabled: false

Index: 1
Name: Change package name
Description: Appends ".morphe" to the package name by default. Changing the package name of the app can lead to unexpected issues.
Enabled: false

Index: 2
Name: Disable Play Store updates
Description: Disables Play Store updates by setting the version code to the maximum allowed. This patch does not work if the app is installed by mounting and may cause unexpected issues with some apps.
Enabled: false

Usually I use CLI without any enable/disable arguments. Patch them by default.

[cyberboh]

I get same issue.
This did not happen in 1.6.0-dev.8.
After merging to stable 1.6.0 ,then issue appear.

[cyberboh]

MorphePatcher should bumped to 1.3.0 stable not a dev 19c0846#diff-697f70cdd88ba88fe77eebda60c7e143f6ad1286bca75017421e93ad84fb87dfR7

[prateek-who]

MorphePatcher should bumped to 1.3.0 stable not a dev 19c0846#diff-697f70cdd88ba88fe77eebda60c7e143f6ad1286bca75017421e93ad84fb87dfR7

This is most likely it. It just need to be bumped up to 1.3.0

[LisoUseInAIKyrios]

It is on 1.3.0 stable

morphe-cli/gradle/libs.versions.toml

Line 10 in 41842d8

morphe-patcher = "1.3.0"

I think the issue may be something with the use deprecated overload that was added in the use to default refactoring

[cyberboh]

It is on 1.3.0 stable

morphe-cli/gradle/libs.versions.toml

Line 10 in 41842d8

morphe-patcher = "1.3.0"
I think the issue may be something with the use deprecated overload that was added in the use to default refactoring

You mean this commit?MorpheApp/morphe-patcher@68a2c37
I think so, because cli 1.6.0-dev.8 did not contains that commit.

[LisoUseInAIKyrios]

java -jar morphe-cli-1.6.0-all.jar list-patches -f com.google.android.youtube --patches patches-1.20.0.mpp

I am trying now but all patches except universal show the correct value of enabled:

Index: 44
Name: Double tap to seek
Description: Adds additional double-tap to seek values to the YouTube settings menu.
Enabled: true

Index: 45
Name: Downloads
Description: Adds support to download videos with an external downloader app using the in-app download button or a video player action button.
Enabled: true

Index: 46
Name: Disable haptic feedback
Description: Adds an option to disable haptic feedback in the player for various actions.
Enabled: true

Index: 47
Name: Loop video
Description: Adds an option to loop videos and display loop video button in the video player.
Enabled: true

[prateek-who]

What did you do differently?

I think the issue may be something with the use deprecated overload that was added in the use to default refactoring

Was it this?

[LisoUseInAIKyrios]

An overloaded kotlin code level (not bytecode level) constructor was added.

But that's not strictly needed because binary compatibility still exists since the boolean parameter was only renamed, and when third party devs change to patcher 1.3.0 dependency they can rename use to default then.

[LisoUseInAIKyrios]

Try again with CLI 1.6.1-dev.1

[l205306]

java -jar morphe-cli-1.6.1-dev.1-all.jar list-patches -f com.google.android.apps.youtube.music --patches patches-1.20.0.mpp

Index: 21
Name: Enable debugging
Description: Adds options for debugging and exporting Morphe logs to the clipboard.
Enabled: false

Index: 22
Name: Check watch history domain name resolution
Description: Checks if the device DNS server is preventing user watch history from being saved.
Enabled: false

Index: 23
Name: GmsCore support
Description: Allows the app to work without root by using a different package name when patched using a GmsCore instead of Google Play Services.
Enabled: false

Index: 24
Name: Sanitize sharing links
Description: Removes the tracking query parameters from shared links.
Enabled: false

The issue still persists.

[LisoUseInAIKyrios]

Try this patches.mpp file

patches-1.20.0-test.mpp.zip