bug: Cannot patch XAPK files

[LisoUseInAIKyrios]

Bug description

XAPK files fail to patch

Example app (patch with "Disable play store updates")
https://apkpure.com/ru/strava-run-hike-android-exercise-laugh/com.strava/download

Error logs

INFO: Loading patches 
INFO: Reading options from options.json 
SEVERE: An unexpected error occurred: Cannot invoke "com.reandroid.arsc.chunk.xml.AndroidManifestBlock.getPackageName()" because "manifest" is null 
java.lang.NullPointerException: Cannot invoke "com.reandroid.arsc.chunk.xml.AndroidManifestBlock.getPackageName()" because "manifest" is null
	at app.morphe.patcher.resource.coder.ArsclibResourceCoder.lazyPackageInfo$lambda$9(ArsclibResourceCoder.kt:124)

Solution

No response

Additional context

No response

Acknowledgements

• I have checked all open and closed bug reports and this is not a duplicate.
• I have chosen an appropriate title.

[prateek-who]

We'll have to add this logic to the patcher now right? Since apkm logic already lives in the patcher.

[LisoUseInAIKyrios]

Yeah fix can be in patcher. Bug report is here for now because end users will see this in CLI.

Latest Manager pre-release works with xapk, so the fix might be simple.

[prateek-who]

You were right, the change is in cli. Patcher already handles it. The problem was, we were only letting apkm go through. xapk were let through like as if they were apk.