feat: agentic CLI push/in-app notification preferences#30995
Open
grvgoel81 wants to merge 12 commits into
Open
feat: agentic CLI push/in-app notification preferences#30995grvgoel81 wants to merge 12 commits into
grvgoel81 wants to merge 12 commits into
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 35c8212. Configure here.
Contributor
🔍 Smart E2E Test Selection
click to see 🤖 AI reasoning detailsE2E Test Selection: Performance Test Selection: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
This PR adds Agentic CLI as a notification module in Settings → Notifications.
Why
What
New Agentic CLI row on the notifications hub (gated by build flag + remote flag).
Reuses NotificationSettingsSection for Push / In-app toggles.
Helpers for agenticCli prefs + client-side resolution when API responses omit the section (until Core package is bumped).
Feature flag: MM_AGENTIC_CLI_NOTIFICATIONS_UI_ENABLED + agenticCliNotificationsEnabled.
Unit, component-view, E2E mocks, and feature-flag registry updates.
Jira: https://consensyssoftware.atlassian.net/browse/MMAI-446
Changelog
CHANGELOG entry: Added Agentic CLI push and in-app notification preferences in Settings
Related issues
Refs: https://consensyssoftware.atlassian.net/browse/MMAI-446
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Performance checks (if applicable)
trace()for usage andaddTokenfor an exampleFor performance guidelines and tooling, see the Performance Guide.
Pre-merge reviewer checklist
Note
Medium Risk
Touches notification preference read/write and optimistic caching for a new storage section; rollout is gated but wrong merge/override logic could mis-sync user prefs until Core is bumped.
Overview
Adds an Agentic CLI notification module under Settings → Notifications so users can control push and in-app channels like other modules (Perps, Marketing).
The hub shows a new row when
MM_AGENTIC_CLI_NOTIFICATIONS_UI_ENABLEDand remoteagenticCliNotificationsEnabledallow it; detail screens reuseNotificationSettingsSectionwith resolvedagenticCliprefs.useNotificationStoragePreferencesmerges inagenticCliviaresolveAgenticCliPreference, persists the section to Authenticated User Storage, and uses a client-side override when API responses omitagenticCli(until Core ships the field). Build/env, i18n, feature-flag registry, and test mocks are updated accordingly.Reviewed by Cursor Bugbot for commit 35c8212. Configure here.