Skip to content

feat: agentic CLI push/in-app notification preferences#30995

Open
grvgoel81 wants to merge 12 commits into
mainfrom
feat/MMAI-446-agentic-notifications
Open

feat: agentic CLI push/in-app notification preferences#30995
grvgoel81 wants to merge 12 commits into
mainfrom
feat/MMAI-446-agentic-notifications

Conversation

@grvgoel81

@grvgoel81 grvgoel81 commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

Description

This PR adds Agentic CLI as a notification module in Settings → Notifications.

Why

  • Users need per-module control of push and in-app notifications for Agentic CLI (same pattern as Perps / Marketing).
  • Mobile must read/write agenticCli via existing Authenticated User Storage + React Query (no new Redux slice).

What

  • New Agentic CLI row on the notifications hub (gated by build flag + remote flag).

  • Reuses NotificationSettingsSection for Push / In-app toggles.

  • Helpers for agenticCli prefs + client-side resolution when API responses omit the section (until Core package is bumped).

  • Feature flag: MM_AGENTIC_CLI_NOTIFICATIONS_UI_ENABLED + agenticCliNotificationsEnabled.

  • Unit, component-view, E2E mocks, and feature-flag registry updates.

  • Jira: https://consensyssoftware.atlassian.net/browse/MMAI-446

Changelog

CHANGELOG entry: Added Agentic CLI push and in-app notification preferences in Settings

Related issues

Refs: https://consensyssoftware.atlassian.net/browse/MMAI-446

Manual testing steps

Feature: Agentic CLI notification preferences

 Scenario: Agentic CLI row is visible when notifications are enabled
    Given the user has completed onboarding and main notifications are ON
    And build and remote feature flags for Agentic CLI are enabled

    When the user opens Settings → Notifications

    Then an "Agentic CLI" row is visible
    And the status shows "Off" by default

  Scenario: User enables push and in-app for Agentic CLI
    Given the user is on Settings → Notifications
    And the Agentic CLI row is visible

    When the user opens Agentic CLI
    And enables Push notifications
    And enables In-app notifications
    And navigates back to the notifications list

    Then the Agentic CLI status shows Push and In-app
    And opening Agentic CLI again shows both toggles ON

Screenshots/Recordings

Before

After

Screenshot 2026-06-09 at 10 14 55 AM

Pre-merge author checklist

Performance checks (if applicable)

  • I've tested on Android
    • Ideally on a mid-range device; emulator is acceptable
  • I've tested with a power user scenario
    • Use these power-user SRPs to import wallets with many accounts and tokens
  • I've instrumented key operations with Sentry traces for production performance metrics

For performance guidelines and tooling, see the Performance Guide.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Medium Risk
Touches notification preference read/write and optimistic caching for a new storage section; rollout is gated but wrong merge/override logic could mis-sync user prefs until Core is bumped.

Overview
Adds an Agentic CLI notification module under Settings → Notifications so users can control push and in-app channels like other modules (Perps, Marketing).

The hub shows a new row when MM_AGENTIC_CLI_NOTIFICATIONS_UI_ENABLED and remote agenticCliNotificationsEnabled allow it; detail screens reuse NotificationSettingsSection with resolved agenticCli prefs. useNotificationStoragePreferences merges in agenticCli via resolveAgenticCliPreference, persists the section to Authenticated User Storage, and uses a client-side override when API responses omit agenticCli (until Core ships the field). Build/env, i18n, feature-flag registry, and test mocks are updated accordingly.

Reviewed by Cursor Bugbot for commit 35c8212. Configure here.

@github-actions

github-actions Bot commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@mm-token-exchange-service mm-token-exchange-service Bot added the team-onboarding Onboarding team label Jun 3, 2026
@github-actions github-actions Bot added the size-M label Jun 3, 2026

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 35c8212. Configure here.

Comment thread app/util/notifications/agenticCliNotificationPreferences.ts Outdated
@github-actions github-actions Bot added size-L and removed size-M labels Jun 3, 2026
@mm-token-exchange-service mm-token-exchange-service Bot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Jun 5, 2026
@github-actions github-actions Bot added size-XL and removed size-L labels Jun 5, 2026
@github-actions

github-actions Bot commented Jun 5, 2026

Copy link
Copy Markdown
Contributor

🔍 Smart E2E Test Selection

  • Selected E2E tags: SmokeAccounts, SmokeConfirmations, SmokeIdentity, SmokeNetworkAbstractions, SmokeNetworkExpansion, SmokeSwap, SmokeStake, SmokeWalletPlatform, SmokeMoney, SmokePerps, SmokeMultiChainAPI, SmokePredictions, SmokeSeedlessOnboarding, SmokeBrowser, SmokeSnaps
  • Selected Performance tags: @PerformanceAccountList, @PerformanceOnboarding, @PerformanceLogin, @PerformanceSwaps, @PerformanceLaunch, @PerformanceAssetLoading, @PerformancePredict, @PerformancePreps
  • Risk Level: high
  • AI Confidence: %
click to see 🤖 AI reasoning details

E2E Test Selection:
Fallback: AI analysis did not complete successfully. Running all tests.

Performance Test Selection:
Fallback: AI analysis did not complete successfully. Running all performance tests.

View GitHub Actions results

@grvgoel81 grvgoel81 self-assigned this Jun 9, 2026
@grvgoel81 grvgoel81 marked this pull request as ready for review June 9, 2026 02:48
@grvgoel81 grvgoel81 requested review from a team as code owners June 9, 2026 02:48
@github-actions github-actions Bot added the risk:medium AI analysis: medium risk label Jun 9, 2026
@grvgoel81 grvgoel81 removed the INVALID-PR-TEMPLATE PR's body doesn't match template label Jun 9, 2026
@mm-token-exchange-service mm-token-exchange-service Bot added INVALID-PR-TEMPLATE PR's body doesn't match template and removed INVALID-PR-TEMPLATE PR's body doesn't match template labels Jun 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:medium AI analysis: medium risk size-XL team-onboarding Onboarding team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant