From 284562da9193daedecde842f1a393360ad167c9f Mon Sep 17 00:00:00 2001 From: aranega Date: Wed, 27 Aug 2025 08:04:40 -0600 Subject: [PATCH 1/3] CELE-148 Fix missing await for async workspace creation --- .../frontend/src/components/CreateNewWorkspaceDialog.tsx | 4 ++-- .../visualizer/frontend/src/contexts/GlobalContext.tsx | 2 +- applications/visualizer/frontend/src/models/workspace.ts | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/applications/visualizer/frontend/src/components/CreateNewWorkspaceDialog.tsx b/applications/visualizer/frontend/src/components/CreateNewWorkspaceDialog.tsx index b1dd3b82..85e59f26 100644 --- a/applications/visualizer/frontend/src/components/CreateNewWorkspaceDialog.tsx +++ b/applications/visualizer/frontend/src/components/CreateNewWorkspaceDialog.tsx @@ -74,7 +74,7 @@ const CreateNewWorkspaceDialog = ({ onCloseCreateWorkspace, showCreateWorkspaceD return Object.values(workspaces).some((workspace) => workspace.name === name); }; - const handleSubmit = () => { + const handleSubmit = async () => { if (!formValues.workspaceName.trim()) { setErrorMessage("Workspace name is required!"); return; @@ -89,7 +89,7 @@ const CreateNewWorkspaceDialog = ({ onCloseCreateWorkspace, showCreateWorkspaceD const newWorkspaceId = `workspace-${randomNumber}`; const activeNeurons = new Set(formValues.selectedNeurons); const activeDatasets = new Set(formValues.selectedDatasets.map((dataset) => dataset.id)); - createWorkspace(newWorkspaceId, formValues.workspaceName, activeDatasets, activeNeurons); + await createWorkspace(newWorkspaceId, formValues.workspaceName, activeDatasets, activeNeurons); if (isCompareMode) { const updatedWorkspaces = new Set([...Object.keys(workspaces), newWorkspaceId]); diff --git a/applications/visualizer/frontend/src/contexts/GlobalContext.tsx b/applications/visualizer/frontend/src/contexts/GlobalContext.tsx index 8a3d927d..02490e99 100644 --- a/applications/visualizer/frontend/src/contexts/GlobalContext.tsx +++ b/applications/visualizer/frontend/src/contexts/GlobalContext.tsx @@ -27,7 +27,7 @@ export interface GlobalContextType { viewMode: ViewMode; selectedWorkspacesIds: Set; setViewMode: (viewMode: ViewMode) => void; - createWorkspace: (id: string, name: string, activeDatasets?: Set, activeNeurons?: Set) => void; + createWorkspace: (id: string, name: string, activeDatasets?: Set, activeNeurons?: Set) => Promise; updateWorkspace: (workspace: Workspace) => void; removeWorkspace: (workspaceId: string) => void; setCurrentWorkspace: (workspaceId: string) => void; diff --git a/applications/visualizer/frontend/src/models/workspace.ts b/applications/visualizer/frontend/src/models/workspace.ts index d47b96a2..ef5ec322 100644 --- a/applications/visualizer/frontend/src/models/workspace.ts +++ b/applications/visualizer/frontend/src/models/workspace.ts @@ -131,7 +131,7 @@ export class Workspace { // Set EM viewer settings if (!emViewerSettings) { const firstActiveDataset = Object.values(activeDatasets)?.[0]; - const [minSlice, maxSlice] = firstActiveDataset.emData?.sliceRange || [0, 0]; + const [minSlice, maxSlice] = firstActiveDataset?.emData?.sliceRange || [0, 0]; const startSlice = Math.floor((maxSlice + minSlice) / 2); this.emViewerSettings = { showNeurons: true, From e3fdac8cd6e405f175f44dd7df0976cde54115bd Mon Sep 17 00:00:00 2001 From: aranega Date: Wed, 27 Aug 2025 08:12:09 -0600 Subject: [PATCH 2/3] CELE-148 Fix dataset panel height --- .../frontend/src/components/ViewerContainer/DataSets.tsx | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/applications/visualizer/frontend/src/components/ViewerContainer/DataSets.tsx b/applications/visualizer/frontend/src/components/ViewerContainer/DataSets.tsx index dde2cc1d..ebb7d893 100644 --- a/applications/visualizer/frontend/src/components/ViewerContainer/DataSets.tsx +++ b/applications/visualizer/frontend/src/components/ViewerContainer/DataSets.tsx @@ -206,7 +206,7 @@ const DataSets = ({ children }) => { ); return ( - + Datasets @@ -339,7 +339,6 @@ const DataSets = ({ children }) => { Date: Thu, 28 Aug 2025 05:31:05 -0600 Subject: [PATCH 3/3] CELE-148 Update limites for the pod --- applications/visualizer/deploy/values.yaml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/applications/visualizer/deploy/values.yaml b/applications/visualizer/deploy/values.yaml index 19166e0a..4283a28e 100644 --- a/applications/visualizer/deploy/values.yaml +++ b/applications/visualizer/deploy/values.yaml @@ -17,9 +17,9 @@ harness: port: 8080 replicas: 1 resources: - # limits: - # cpu: '0.50' - # memory: 500M + limits: + cpu: "0.50" + memory: 2000M requests: cpu: "0.25" # memory: 2000Mi