Skip to content

guitar hero parsing is completely inaccurate #39

@Rudyrue

Description

@Rudyrue
2026-05-05.19-30-49.mp4
2026-05-05.19-55-24.mp4

guitar hero charts seem to be parsed like completely wrong
(or at least probably just for gh -> fnf)

public static function createDummyFile():Chart {
	return {
		notes: []
	}
}
var file:Chart = createDummyFile();

var fnf:FNFLegacy = new FNFLegacy();
fnf.indexedTypes = false;
fnf.bakedOffset = false;
fnf.offsetHolds = false;
final guitar:GuitarHero = cast new GuitarHero().fromFile(path);
file.format = guitar;
rawChart = cast fnf.fromFormat(guitar).data.song;

for (section in rawChart.notes) {
	for (note in section.sectionNotes) {
		file.notes.push({
			time: Math.max(0, note[0]),
			lane: Std.int(note[1] % 4), // this variable's the problem here
			length: note[2],
			player: note[1] > (Strumline.default_keyCount - 1) != section.mustHitSection ? 1 : 0,
		});
	}
}

it seemes like lanes are parsed as what type the note is
rather than the actual lane of the note

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions