-
Notifications
You must be signed in to change notification settings - Fork 48
Design limitation of read boundaries #327
Copy link
Copy link
Open
Labels
abi-breakbreaks the ABI (e.g. programs linked against the library have to be recompiled)breaks the ABI (e.g. programs linked against the library have to be recompiled)api-breakbreaks the API (e.g. programs using it will have to adjust their source code)breaks the API (e.g. programs using it will have to adjust their source code)
Metadata
Metadata
Assignees
Labels
abi-breakbreaks the ABI (e.g. programs linked against the library have to be recompiled)breaks the ABI (e.g. programs linked against the library have to be recompiled)api-breakbreaks the API (e.g. programs using it will have to adjust their source code)breaks the API (e.g. programs using it will have to adjust their source code)
Type
Fields
Give feedbackNo fields configured for issues without a type.
We recently got a file that has some upper element that violates its size boundaries.
When calling
EbmlElement::FindNextElement()one can pass the limit to which the elements can be found withMaxDataSize. However that value is not used if we read the next upper element. There's a check on the value but if it's a binary or master element with no constraints it will be valid no matter what, and returned becauseUpperLevel > 0.