#446: processed review comments

basmasking · basmasking · commit bfb3ab0716d6 · 2025-11-07T22:34:33.000+01:00
diff --git a/src/webui/designsystem/components/tabs/Tabs.tsx b/src/webui/designsystem/components/tabs/Tabs.tsx
@@ -37,15 +37,15 @@ export default function Component({ separator, selectedId, children, onChange }:
 
     const updateSelected = useEffectEvent((selectedId?: string) =>
     {
-        const firstTabId = tabList[0].props.id;
+        const firstTabId = tabList[0]?.props.id;
 
         setSelected(selectedId ?? firstTabId);
     });
 
     useEffect(() =>
     {
         updateSelected(selectedId);
-    }, [selectedId]);
+    }, [selectedId, tabList]);
 
     const handleChange = (tabId: string) =>
     {

Original file line number	Diff line number	Diff line change
`@@ -37,15 +37,15 @@ export default function Component({ separator, selectedId, children, onChange }:`
`37`	`37`
`38`	`38`	`const updateSelected = useEffectEvent((selectedId?: string) =>`
`39`	`39`	`{`
`40`		`- const firstTabId = tabList[0].props.id;`
	`40`	`+ const firstTabId = tabList[0]?.props.id;`
`41`	`41`
`42`	`42`	`setSelected(selectedId ?? firstTabId);`
`43`	`43`	`});`
`44`	`44`
`45`	`45`	`useEffect(() =>`
`46`	`46`	`{`
`47`	`47`	`updateSelected(selectedId);`
`48`		`- }, [selectedId]);`
	`48`	`+ }, [selectedId, tabList]);`
`49`	`49`
`50`	`50`	`const handleChange = (tabId: string) =>`
`51`	`51`	`{`