Skip to content

Commit c4bcede

Browse files
committed
Report extension package sizes without arbitrary publication caps
1 parent 6bcd40c commit c4bcede

2 files changed

Lines changed: 5 additions & 12 deletions

File tree

‎docs/INSTALLATION.md‎

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,8 +26,9 @@ and run **Extensions: Install from VSIX**.
2626

2727
The VSIX is batteries-included: do not install `splitc`, `splitls`, Rust, Node,
2828
or a WebAssembly toolchain merely to use the extension. Release packaging
29-
rejects a compiler Wasm module larger than 8 MiB or a complete VSIX larger than
30-
12 MiB. The package contains native debugger bridges for Windows x64, Linux x64
29+
checks artifact integrity and reports the compiler Wasm and compressed VSIX
30+
sizes without enforcing fixed size budgets. The package contains native
31+
debugger bridges for Windows x64, Linux x64
3132
and ARM64, and macOS Intel and Apple Silicon; only the bridge for the running
3233
desktop host is loaded.
3334

‎editors/vscode/scripts/probe-package.mjs‎

Lines changed: 2 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -27,8 +27,6 @@ const productionDist = resolve(
2727
);
2828
const vsce = resolve(extension, 'node_modules', '@vscode', 'vsce', 'vsce');
2929
const supportedPlatforms = new Set(supportedNativePlatforms);
30-
const maxCompilerWasmBytes = 8 * 1024 * 1024;
31-
const maxVsixBytes = 12 * 1024 * 1024;
3230
const configuredPlatforms = process.env.SPLITSCRIPT_REQUIRED_NATIVE_PLATFORMS;
3331
const requiredPlatforms = configuredPlatforms === undefined
3432
? process.env.SPLITSCRIPT_NATIVE_ARTIFACTS === undefined
@@ -169,10 +167,6 @@ try {
169167
expectedCompilerWasm,
170168
'the packaged compiler Wasm is stale relative to the max-opt build',
171169
);
172-
assert(
173-
compilerWasm.byteLength <= maxCompilerWasmBytes,
174-
`the optimized compiler Wasm exceeds its ${maxCompilerWasmBytes}-byte package budget`,
175-
);
176170

177171
for (const [entrypoint, localArtifacts] of [
178172
['dist/extension.js', [
@@ -218,10 +212,6 @@ try {
218212
assert.equal(packaged.status, 0, packaged.stderr || packaged.stdout);
219213
const packageSize = (await stat(output)).size;
220214
assert(packageSize > 0);
221-
assert(
222-
packageSize <= maxVsixBytes,
223-
`the VSIX exceeds its ${maxVsixBytes}-byte distribution budget`,
224-
);
225215
const packageBytes = await readFile(output);
226216
assert.deepEqual(await readPackagedRelease(output), {
227217
id: 'LiveSplit.splitscript',
@@ -237,6 +227,8 @@ try {
237227
sourceRef: process.env.GITHUB_REF ?? null,
238228
sha256: createHash('sha256').update(packageBytes).digest('hex'),
239229
}, null, 2)}\n`);
230+
// Sizes are informational, not correctness gates: legitimate compiler
231+
// features must not fail publication because of an arbitrary byte budget.
240232
console.log(
241233
`VSIX packaging probe passed with ${files.length} production files and `
242234
+ `${requiredPlatforms.length} required native bridge artifact(s); `

0 commit comments

Comments
 (0)