Fix remaining 96 ESLint errors across lib and test files

Agent-Logs-Url: https://github.com/LinkedSoftwareDependencies/Components.js/sessions/5baf6678-c4cb-41cb-91d2-eeaff51497c2

Co-authored-by: rubensworks <440384+rubensworks@users.noreply.github.com>

Author: Copilot

eslint.config.js

@@ -37,6 +37,15 @@ module.exports = config([
       'unused-imports/no-unused-vars': [ 'error', { args: 'none' }],
     },
   },
+  {
+    // PrefetchedDocumentLoader imports JSON files which need import/extensions disabled;
+    // the disable comments between imports break the newline-after-import chain detection
+    files: [ 'lib/rdf/PrefetchedDocumentLoader.ts' ],
+    rules: {
+      'import/extensions': 'off',
+      'import/newline-after-import': 'off',
+    },
+  },
   {
     // Specific rules for test files
     files: [ '**/test/**/*.ts' ],

lib/construction/strategy/IConstructionStrategy.ts

@@ -108,6 +108,7 @@ export interface ICreationStrategySupplierOptions<TInstance> {
   supplier: () => Promise<TInstance>;
 }
 
+// eslint-disable-next-line unused-imports/no-unused-vars
 export interface ICreationStrategyPrimitiveOptions<TInstance> {
   /**
    * Creation settings.
@@ -119,6 +120,7 @@ export interface ICreationStrategyPrimitiveOptions<TInstance> {
   value: string | number | any;
 }
 
+// eslint-disable-next-line unused-imports/no-unused-vars
 export interface ICreationStrategyVariableOptions<TInstance> {
   /**
    * Creation settings.

lib/preprocess/overridesteps/OverrideMapEntry.ts

@@ -71,6 +71,8 @@ export class OverrideMapEntry implements IOverrideStep {
    * @param entries - List of key/value map entries.
    * @param key - Key of the entry to find.
    * @param properties - URIs used to link the key and value of a map entry.
+   * @param properties.key - URI used to link the key of a map entry.
+   * @param properties.value - URI used to link the value of a map entry.
    */
   protected findEntryIndex(entries: Resource[], key: Resource, properties: { key: Resource; value: Resource }): number {
     for (const [ i, entry ] of entries.entries()) {

lib/preprocess/parameterproperty/ParameterPropertyHandlerRange.ts

@@ -62,8 +62,8 @@ export class ParameterPropertyHandlerRange implements IParameterPropertyHandler
    *
    * @param value The value.
    * @param type The parameter's range.
-   * @param genericsContext Context for generic types.
    * @param errorContext The context for error reporting.
+   * @param genericsContext Context for generic types.
    * @return IParamValueConflict A conflict value if there was an error, or undefined if there was no error
    */
   public hasValueType(

lib/rdf/PrefetchedDocumentLoader.ts

@@ -2,8 +2,8 @@ import type { IJsonLdContext } from 'jsonld-context-parser';
 import { FetchDocumentLoader } from 'jsonld-context-parser';
 import semverMajor from 'semver/functions/major';
 import type { Logger } from 'winston';
-import contextJson from '../../components/context.json'; // eslint-disable-line import/extensions
-import packageJson from '../../package.json'; // eslint-disable-line import/extensions
+import contextJson from '../../components/context.json';
+import packageJson from '../../package.json';
 
 /**
  * A document loader that first loads from a precomputed set of contexts,

test/integration/instantiateFile-test.ts

@@ -7,6 +7,7 @@ import { IRIS_DOAP, IRIS_OO, IRIS_RDF } from '../../lib/rdf/Iris';
 
 const quad = require('rdf-quad');
 
+// eslint-disable-next-line jest/no-mocks-import
 const Hello = require('../../__mocks__/helloworld').Hello;
 
 jest.mock<typeof import('winston')>('winston', () => ({
@@ -31,10 +32,10 @@ describe('construction with component configs as files', () => {
   let manager: ComponentsManager<any>;
   beforeEach(async() => {
     moduleState = <any> {
-      mainModulePath: `${__dirname}/../../__mocks__`,
+      mainModulePath: Path.join(__dirname, '../../__mocks__'),
       importPaths: {
-        'http://example.org/': `${__dirname}/../`,
-        'https://linkedsoftwaredependencies.org/bundles/npm/example/^1.0.0/config/': `${__dirname}/../assets/`,
+        'http://example.org/': `${Path.join(__dirname, '..')}/`,
+        'https://linkedsoftwaredependencies.org/bundles/npm/example/^1.0.0/config/': `${Path.join(__dirname, '../assets')}/`,
       },
       packageJsons: {},
     };
@@ -403,7 +404,9 @@ describe('construction with component configs as files', () => {
         mainModulePath: __dirname,
         moduleState,
         async moduleLoader(registry) {
-          await registry.registerModule(Path.join(__dirname, '../assets/module-inheritableparams-subclassmapping.jsonld'));
+          await registry.registerModule(
+            Path.join(__dirname, '../assets/module-inheritableparams-subclassmapping.jsonld'),
+          );
         },
       });
     });
@@ -510,7 +513,9 @@ describe('construction with component configs as files', () => {
         mainModulePath: __dirname,
         moduleState,
         async moduleLoader(registry) {
-          await registry.registerModule(Path.join(__dirname, '../assets/module-inheritableparams-subclassmapping-dynamicentries.jsonld'));
+          await registry.registerModule(
+            Path.join(__dirname, '../assets/module-inheritableparams-subclassmapping-dynamicentries.jsonld'),
+          );
         },
       });
     });
@@ -567,7 +572,9 @@ describe('construction with component configs as files', () => {
         mainModulePath: __dirname,
         moduleState,
         async moduleLoader(registry) {
-          await registry.registerModule(Path.join(__dirname, '../assets/module-inheritableparams-dynamicentries.jsonld'));
+          await registry.registerModule(
+            Path.join(__dirname, '../assets/module-inheritableparams-dynamicentries.jsonld'),
+          );
         },
       });
     });

test/integration/instantiateResourceConfigComponent-test.ts

@@ -1,3 +1,4 @@
+import * as Path from 'node:path';
 import { mocked } from 'jest-mock';
 import type { Resource, RdfObjectLoader } from 'rdf-object';
 import { ComponentsManager } from '../../lib/ComponentsManager';
@@ -20,9 +21,9 @@ describe('construction with component configs as Resource', () => {
   let settings: IConstructionSettings;
   beforeEach(async() => {
     manager = await ComponentsManager.build({
-      mainModulePath: `${__dirname}/../../__mocks__`,
+      mainModulePath: Path.join(__dirname, '../../__mocks__'),
       moduleState: <any> {
-        mainModulePath: `${__dirname}/../../__mocks__`,
+        mainModulePath: Path.join(__dirname, '../../__mocks__'),
         packageJsons: {},
       },
       async moduleLoader() {

test/integration/instantiateResourceConfigComponentMapped-test.ts

@@ -1,3 +1,4 @@
+import * as Path from 'node:path';
 import { mocked } from 'jest-mock';
 import type { Resource, RdfObjectLoader } from 'rdf-object';
 import { ComponentsManager } from '../../lib/ComponentsManager';
@@ -13,6 +14,7 @@ jest.mock<typeof import('n3')>('n3', () => ({
   Util: { type: 'UTIL' },
 }));
 
+// eslint-disable-next-line jest/no-mocks-import
 const Hello = require('../../__mocks__/helloworld').Hello;
 
 describe('construction with mapped component configs as Resource', () => {
@@ -22,9 +24,9 @@ describe('construction with mapped component configs as Resource', () => {
   let settings: IConstructionSettings;
   beforeEach(async() => {
     manager = await ComponentsManager.build({
-      mainModulePath: `${__dirname}/../../__mocks__`,
+      mainModulePath: Path.join(__dirname, '../../__mocks__'),
       moduleState: <any> {
-        mainModulePath: `${__dirname}/../../__mocks__`,
+        mainModulePath: Path.join(__dirname, '../../__mocks__'),
         packageJsons: {},
       },
       async moduleLoader() {

test/integration/instantiateResourceConfigRaw-test.ts

@@ -1,3 +1,4 @@
+import * as Path from 'node:path';
 import type { RdfObjectLoader } from 'rdf-object';
 import { ComponentsManager } from '../../lib/ComponentsManager';
 import type { IConfigConstructorPool } from '../../lib/construction/IConfigConstructorPool';
@@ -11,6 +12,7 @@ jest.mock<typeof import('n3')>('n3', () => ({
   Util: { type: 'UTIL' },
 }));
 
+// eslint-disable-next-line jest/no-mocks-import
 const Hello = require('../../__mocks__/helloworld').Hello;
 
 describe('construction with component configs as Resource', () => {
@@ -20,9 +22,9 @@ describe('construction with component configs as Resource', () => {
   let settings: IConstructionSettings;
   beforeEach(async() => {
     manager = await ComponentsManager.build({
-      mainModulePath: `${__dirname}/../../__mocks__`,
+      mainModulePath: Path.join(__dirname, '../../__mocks__'),
       moduleState: <any> {
-        mainModulePath: `${__dirname}/../../__mocks__`,
+        mainModulePath: Path.join(__dirname, '../../__mocks__'),
         packageJsons: {},
       },
       async moduleLoader() {

test/unit/construction/ConfigConstructor-test.ts

@@ -1,4 +1,5 @@
 import * as fs from 'node:fs';
+import * as Path from 'node:path';
 import { DataFactory } from 'rdf-data-factory';
 import { Resource, RdfObjectLoader } from 'rdf-object';
 import { ConfigConstructor } from '../../../lib/construction/ConfigConstructor';
@@ -11,7 +12,6 @@ const DF = new DataFactory();
 
 describe('ConfigConstructor', () => {
   let objectLoader: RdfObjectLoader;
-  let componentResources: Record<string, Resource>;
   let configConstructorPool: jest.Mocked<ConfigConstructorPool<any>>;
   let constructor: ConfigConstructor<any>;
   let constructionStrategy: IConstructionStrategy<any>;
@@ -21,10 +21,9 @@ describe('ConfigConstructor', () => {
   beforeEach(async() => {
     objectLoader = new RdfObjectLoader({
       uniqueLiterals: true,
-      context: JSON.parse(fs.readFileSync(`${__dirname}/../../../components/context.jsonld`, 'utf8')),
+      context: JSON.parse(fs.readFileSync(Path.join(__dirname, '../../../components/context.jsonld'), 'utf8')),
     });
     await objectLoader.context;
-    componentResources = {};
     configConstructorPool = <any> {
       instantiate: jest.fn(() => 'INSTANCE'),
     };
@@ -40,7 +39,7 @@ describe('ConfigConstructor', () => {
     moduleState = <any> {
       mainModulePath: __dirname,
       importPaths: {
-        'http://example.org/': `${__dirname}/`,
+        'http://example.org/': `${Path.resolve(__dirname)}/`,
       },
     };
     constructor = new ConfigConstructor({
@@ -105,7 +104,7 @@ describe('ConfigConstructor', () => {
           undefined: '"true"',
         });
         await expect(constructor.getArgumentValue(resource, settings)).resolves.toBeUndefined();
-        expect(constructionStrategy.createUndefined).toHaveBeenCalled();
+        expect(constructionStrategy.createUndefined).toHaveBeenCalledWith(expect.anything());
       });
     });