fix(recommendations): update callers missed by ServiceSavingsPlans->All rename

Rebase onto feat/multicloud-web-frontend brought in three files that still
referenced the old common.ServiceSavingsPlans sentinel (renamed to
ServiceSavingsPlansAll in the prior commit). Update the two production call
sites and one test file so go vet and go build pass on the merged PR view.

Author: cristim

providers/aws/recommendations/client.go

@@ -346,7 +346,7 @@ func (c *Client) GetAllRecommendations(ctx context.Context) ([]common.Recommenda
 		return nil
 	})
 	g.Go(func() error {
-		spRecs, spErr = c.GetRecommendationsForService(gctx, common.ServiceSavingsPlans)
+		spRecs, spErr = c.GetRecommendationsForService(gctx, common.ServiceSavingsPlansAll)
 		return nil
 	})
 

providers/azure/recommendations.go

@@ -134,7 +134,7 @@ func (r *RecommendationsClientAdapter) GetRecommendations(ctx context.Context, p
 	// The call returns an empty slice so the service appears in the fan-out
 	// and will start returning data once the API stabilises without requiring
 	// a scheduler change.
-	if shouldIncludeService(params, common.ServiceSavingsPlans) {
+	if shouldIncludeService(params, common.ServiceSavingsPlansAll) {
 		goService(&spErr, func() {
 			spClient := savingsplans.NewClient(r.cred, r.subscriptionID, "")
 			spRecs, spErr = spClient.GetRecommendations(gctx, params)

providers/azure/recommendations_test.go

@@ -218,8 +218,8 @@ func TestRecommendationsClientAdapter_GetAllRecommendations(t *testing.T) {
 }
 
 // TestGetRecommendations_SavingsPlansServiceIncluded pins that shouldIncludeService
-// allows ServiceSavingsPlans through both when params.Service is empty (all-services
-// sweep) and when explicitly set to ServiceSavingsPlans, and does not include it
+// allows ServiceSavingsPlansAll through both when params.Service is empty (all-services
+// sweep) and when explicitly set to ServiceSavingsPlansAll, and does not include it
 // when a different service is requested. This ensures the SP goroutine added to the
 // fan-out in GetRecommendations is exercised on every scheduler collection run.
 func TestGetRecommendations_SavingsPlansServiceIncluded(t *testing.T) {
@@ -235,7 +235,7 @@ func TestGetRecommendations_SavingsPlansServiceIncluded(t *testing.T) {
 		},
 		{
 			name:     "explicit savingsplans service is included",
-			params:   common.RecommendationParams{Service: common.ServiceSavingsPlans},
+			params:   common.RecommendationParams{Service: common.ServiceSavingsPlansAll},
 			expected: true,
 		},
 		{
@@ -246,7 +246,7 @@ func TestGetRecommendations_SavingsPlansServiceIncluded(t *testing.T) {
 	}
 	for _, tt := range tests {
 		t.Run(tt.name, func(t *testing.T) {
-			got := shouldIncludeService(tt.params, common.ServiceSavingsPlans)
+			got := shouldIncludeService(tt.params, common.ServiceSavingsPlansAll)
 			assert.Equal(t, tt.expected, got)
 		})
 	}
@@ -431,7 +431,7 @@ func TestMergeServiceResults_OrderIsStable(t *testing.T) {
 	dbRec := mkRec(common.ServiceRelationalDB, "database")
 	cacheRec := mkRec(common.ServiceCache, "cache")
 	cosmosRec := mkRec(common.ServiceNoSQL, "cosmosdb")
-	spRec := mkRec(common.ServiceSavingsPlans, "savingsplans")
+	spRec := mkRec(common.ServiceSavingsPlansAll, "savingsplans")
 	advisorRec := mkRec(common.ServiceCompute, "advisor") // Advisor produces Compute recs
 
 	// Replicate the exact call order from GetRecommendations.