Repository navigation
Commit dadf637
committed
sec(auth): refuse a partial actor resolution that widens the grant ceiling
grantCeilingAccounts closed only TOTAL resolution failure, on the premise that
partial resolution under-reports the actor's scope and is therefore stricter.
That premise is false for AllowedAccounts, which is a UNION in which the empty
set means EVERYTHING: dropping a contributing group does not narrow it. The
union of [] and ["acct-A"] is restricted; lose the group carrying ["acct-A"]
and it collapses to [], and the actor may then widen any group to ["*"].
Verified by execution against the write path:
baseline (both groups resolve) REFUSED widening to [*]
PARTIAL (scoping group ErrNoRows) ACCEPTED widening to [*]
The configuration needs TWO groups -- one granting update:groups with no
allowed_accounts, one carrying the restriction -- which is why the earlier
six-case single-group verification could not find it.
The guard is now: refuse when the union is empty AND at least one group was
skipped. The emptiness test is len(AllowedAccounts) == 0, deliberately NOT
IsUnrestrictedAccess: a union containing "*" was already maximally wide at
baseline, so no loss can widen it, and refusing it would be zero security
benefit and pure availability cost. All seven seeded groups ship
allowed_accounts = ARRAY['*'], so the broader predicate would have refused
every seeded-group member with one stale membership.
Both directions are mutation-verified and each is guarded by exactly one test:
widening the predicate kills only WildcardActorToleratesSkippedGroup; removing
the guard kills only PartialActorResolutionThatWidensIsRefused. Neither would
catch the other's defect.
The total-failure case is the degenerate partial one -- every group skipped --
so it is now caught by the skipped-group guard and carries that message. The
existing test asserted the other guard's exact wording; its assertion is
relaxed to the sentinel plus a substring true of both.
NOTE ON OVERLAP: AuthContext.SkippedGroups and the counting in
collectGroupsAndAccounts are also added by PR #1752 for the read path. The two
changes are identical; whichever merges second should see no divergence.
Refs #1550, #1748.1 parent 386b316 commit dadf637
2 files changed
Lines changed: 134 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
322 | 322 | | |
323 | 323 | | |
324 | 324 | | |
325 | | - | |
| 325 | + | |
| 326 | + | |
| 327 | + | |
| 328 | + | |
| 329 | + | |
326 | 330 | | |
327 | 331 | | |
328 | 332 | | |
329 | 333 | | |
| 334 | + | |
| 335 | + | |
| 336 | + | |
| 337 | + | |
| 338 | + | |
| 339 | + | |
| 340 | + | |
| 341 | + | |
| 342 | + | |
| 343 | + | |
| 344 | + | |
| 345 | + | |
| 346 | + | |
| 347 | + | |
| 348 | + | |
| 349 | + | |
| 350 | + | |
| 351 | + | |
| 352 | + | |
| 353 | + | |
| 354 | + | |
| 355 | + | |
| 356 | + | |
| 357 | + | |
| 358 | + | |
| 359 | + | |
| 360 | + | |
| 361 | + | |
| 362 | + | |
| 363 | + | |
| 364 | + | |
| 365 | + | |
| 366 | + | |
| 367 | + | |
| 368 | + | |
| 369 | + | |
| 370 | + | |
| 371 | + | |
| 372 | + | |
| 373 | + | |
| 374 | + | |
| 375 | + | |
| 376 | + | |
| 377 | + | |
| 378 | + | |
| 379 | + | |
| 380 | + | |
| 381 | + | |
| 382 | + | |
| 383 | + | |
| 384 | + | |
| 385 | + | |
| 386 | + | |
| 387 | + | |
| 388 | + | |
| 389 | + | |
| 390 | + | |
| 391 | + | |
| 392 | + | |
| 393 | + | |
| 394 | + | |
| 395 | + | |
| 396 | + | |
| 397 | + | |
| 398 | + | |
| 399 | + | |
| 400 | + | |
| 401 | + | |
| 402 | + | |
| 403 | + | |
| 404 | + | |
| 405 | + | |
| 406 | + | |
| 407 | + | |
| 408 | + | |
| 409 | + | |
| 410 | + | |
| 411 | + | |
| 412 | + | |
| 413 | + | |
| 414 | + | |
| 415 | + | |
| 416 | + | |
| 417 | + | |
| 418 | + | |
| 419 | + | |
| 420 | + | |
| 421 | + | |
| 422 | + | |
| 423 | + | |
| 424 | + | |
| 425 | + | |
| 426 | + | |
| 427 | + | |
| 428 | + | |
| 429 | + | |
| 430 | + | |
| 431 | + | |
| 432 | + | |
| 433 | + | |
| 434 | + | |
| 435 | + | |
| 436 | + | |
| 437 | + | |
| 438 | + | |
| 439 | + | |
| 440 | + | |
| 441 | + | |
| 442 | + | |
| 443 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
155 | 155 | | |
156 | 156 | | |
157 | 157 | | |
| 158 | + | |
| 159 | + | |
| 160 | + | |
| 161 | + | |
| 162 | + | |
| 163 | + | |
| 164 | + | |
| 165 | + | |
| 166 | + | |
| 167 | + | |
| 168 | + | |
| 169 | + | |
| 170 | + | |
| 171 | + | |
| 172 | + | |
| 173 | + | |
| 174 | + | |
| 175 | + | |
| 176 | + | |
158 | 177 | | |
159 | 178 | | |
160 | 179 | | |
| |||
0 commit comments