fix(rebase): restore saveExecutionStatusBestEffort; update param-23 guard test

Two issues introduced when rebasing onto main (which added ladder_execution_enabled
in parallel):

1. saveExecutionStatusBestEffort helper was dropped during conflict resolution of
   the applyAccountOutcome refactor commit; restored from the pre-rebase branch.

2. TestSaveGlobalConfig_OfferingClassBindsAt22 expected 22 args; with
   ladder_execution_enabled now at $22, offering_class moved to $23. Renamed
   the test to TestSaveGlobalConfig_OfferingClassBindsAt23 and added the
   $22 AnyArg placeholder.

Author: cristim

internal/config/store_postgres_coverage_test.go

@@ -538,16 +538,17 @@ func TestPostgresStore_GetAllPurchaseHistory_NilDB(t *testing.T) {
 	assert.True(t, panicked, "expected panic with nil db connection")
 }
 
-// TestSaveGlobalConfig_OfferingClassBindsAt22 is the HOLE 2 regression guard
+// TestSaveGlobalConfig_OfferingClassBindsAt23 is the HOLE 2 regression guard
 // (issue #694): the real PostgresStore.SaveGlobalConfig must bind offering_class
-// as the 22nd positional argument ($22), with laddering_enabled at $21.
+// as the 23rd positional argument ($23), with laddering_enabled at $21 and
+// ladder_execution_enabled at $22.
 // The testablePostgresStore in store_postgres_mock_test.go is a hand-maintained
 // copy that omits the field entirely, so no fast test guarded the placeholder
 // count until now.
 //
 // Using pgxmock directly against the real PostgresStore (not the hand-maintained
 // testablePostgresStore wrapper) ensures the live query is tested, not a stale copy.
-func TestSaveGlobalConfig_OfferingClassBindsAt22(t *testing.T) {
+func TestSaveGlobalConfig_OfferingClassBindsAt23(t *testing.T) {
 	ctx := context.Background()
 	mock, err := pgxmock.NewPool()
 	require.NoError(t, err)
@@ -569,8 +570,9 @@ func TestSaveGlobalConfig_OfferingClassBindsAt22(t *testing.T) {
 		OfferingClass:       "standard",
 	}
 
-	// Expect exactly 22 args; pgxmock validates arg count and types.
-	// The 21st arg is laddering_enabled; the 22nd arg must be "standard" (offering_class).
+	// Expect exactly 23 args; pgxmock validates arg count and types.
+	// The 21st arg is laddering_enabled; the 22nd is ladder_execution_enabled;
+	// the 23rd arg must be "standard" (offering_class).
 	// If the real query regresses to a different arg count, pgxmock
 	// will return an unexpected-call error and the test will fail.
 	mock.ExpectExec(`INSERT INTO global_config`).
@@ -596,13 +598,14 @@ func TestSaveGlobalConfig_OfferingClassBindsAt22(t *testing.T) {
 			pgxmock.AnyArg(), // $19 recommendations_lookback_days
 			pgxmock.AnyArg(), // $20 purchase_delay_hours
 			pgxmock.AnyArg(), // $21 laddering_enabled
-			"standard",       // $22 offering_class -- the field this test guards
+			pgxmock.AnyArg(), // $22 ladder_execution_enabled
+			"standard",       // $23 offering_class -- the field this test guards
 		).
 		WillReturnResult(pgxmock.NewResult("INSERT", 1))
 
 	err = store.SaveGlobalConfig(ctx, cfg)
-	require.NoError(t, err, "SaveGlobalConfig must succeed when the DB accepts all 22 args")
+	require.NoError(t, err, "SaveGlobalConfig must succeed when the DB accepts all 23 args")
 
 	require.NoError(t, mock.ExpectationsWereMet(),
-		"offering_class must be bound as the 22nd argument to SaveGlobalConfig")
+		"offering_class must be bound as the 23rd argument to SaveGlobalConfig")
 }

internal/purchase/execution.go

@@ -201,6 +201,15 @@ func (m *Manager) executeMultiAccount(ctx context.Context, baseExec *config.Purc
 	return fmt.Errorf("%w: %s", errAllAccountsFailed, strings.Join(errs, "; "))
 }
 
+// saveExecutionStatusBestEffort saves the execution record and logs any error.
+// Used in error paths where we need to persist the failure status but cannot
+// propagate the save error (the original error is already being returned).
+func (m *Manager) saveExecutionStatusBestEffort(ctx context.Context, exec *config.PurchaseExecution) {
+	if err := m.config.SavePurchaseExecution(ctx, exec); err != nil {
+		logging.Warnf("execution: failed to persist error status for account %v: %v", exec.CloudAccountID, err)
+	}
+}
+
 // executeForAccount runs a single plan execution for one cloud account.
 // It creates a new PurchaseExecution record tagged with cloud_account_id, resolves
 // per-account credentials, executes purchases, and saves the result.