fix(purchases): cite #625 in cancelled-KPI regression tests

summarizePurchaseHistory already excludes cancelled rows from dollar
totals (landed in #737 against #736). Issue #625 describes the same
bug -- this commit updates the two existing regression-test comments
and assertion messages to cite both issues so the PR can formally
close #625.

Closes #625

Author: cristim

internal/api/handler_history_test.go

@@ -1350,8 +1350,8 @@ func TestHandler_getHistory_CompletedExecutionNotDuplicated(t *testing.T) {
 }
 
 // TestSummarizePurchaseHistory_CancelledExcludedFromKPIs is the regression
-// test for issue #736. Cancelling a pending purchase must not add its upfront
-// cost or savings to the KPI totals. Specifically:
+// test for issues #625 and #736. Cancelling a pending purchase must not add
+// its upfront cost or savings to the KPI totals. Specifically:
 //   - TotalUpfront, TotalMonthlySavings, TotalAnnualSavings must reflect only
 //     the approved/completed rows.
 //   - TotalCompleted must not include cancelled rows.
@@ -1377,17 +1377,17 @@ func TestSummarizePurchaseHistory_CancelledExcludedFromKPIs(t *testing.T) {
 	assert.Equal(t, 1, summary.TotalPending)
 
 	assert.InDelta(t, 350.0, summary.TotalUpfront, 0.001,
-		"cancelled upfront cost must not be included in TotalUpfront (issue #736)")
+		"cancelled upfront cost must not be included in TotalUpfront (issues #625, #736)")
 	assert.InDelta(t, 35.0, summary.TotalMonthlySavings, 0.001,
-		"cancelled savings must not be included in TotalMonthlySavings (issue #736)")
+		"cancelled savings must not be included in TotalMonthlySavings (issues #625, #736)")
 	assert.InDelta(t, 420.0, summary.TotalAnnualSavings, 0.001,
-		"TotalAnnualSavings = TotalMonthlySavings * 12 and must exclude cancelled (issue #736)")
+		"TotalAnnualSavings = TotalMonthlySavings * 12 and must exclude cancelled (issues #625, #736)")
 }
 
 // TestSummarizePurchaseHistory_CancelPendingDoesNotChangeKPIs mirrors the
-// QA reproduction scenario from issue #736: start with N approved purchases,
-// observe KPI totals, then add a cancelled execution and assert the totals
-// are unchanged.
+// QA reproduction scenario from issues #625 and #736: start with N approved
+// purchases, observe KPI totals, then add a cancelled execution and assert the
+// totals are unchanged.
 func TestSummarizePurchaseHistory_CancelPendingDoesNotChangeKPIs(t *testing.T) {
 	// Baseline: three approved (completed) rows.
 	baseline := []config.PurchaseHistoryRecord{
@@ -1406,11 +1406,11 @@ func TestSummarizePurchaseHistory_CancelPendingDoesNotChangeKPIs(t *testing.T) {
 	after := summarizePurchaseHistory(withCancelled)
 
 	assert.Equal(t, before.TotalUpfront, after.TotalUpfront,
-		"cancelling a pending purchase must not change TotalUpfront (issue #736)")
+		"cancelling a pending purchase must not change TotalUpfront (issues #625, #736)")
 	assert.Equal(t, before.TotalMonthlySavings, after.TotalMonthlySavings,
-		"cancelling a pending purchase must not change TotalMonthlySavings (issue #736)")
+		"cancelling a pending purchase must not change TotalMonthlySavings (issues #625, #736)")
 	assert.Equal(t, before.TotalAnnualSavings, after.TotalAnnualSavings,
-		"cancelling a pending purchase must not change TotalAnnualSavings (issue #736)")
+		"cancelling a pending purchase must not change TotalAnnualSavings (issues #625, #736)")
 	assert.Equal(t, before.TotalCompleted, after.TotalCompleted,
-		"cancelling a pending purchase must not change TotalCompleted (issue #736)")
+		"cancelling a pending purchase must not change TotalCompleted (issues #625, #736)")
 }