Repository navigation
Commit ac140fc
committed
PR #792 added the "Monthly Cost" column to two history tables and to the
active-commitments table, but the skeleton-loader call sites + their
explanatory comments still referenced the pre-#792 column counts. The
shimmer placeholders therefore render with one fewer cell than the real
table on first paint, and the comments are out of sync with the
rendered <th> lists.
- history.ts:217 — purchase-history skeleton: showSkeletonRows
3rd arg 11 -> 12; comment lists the 12 rendered columns
(adds "Monthly Cost").
- history.ts:224 — pending-approval queue skeleton: showSkeletonRows
3rd arg 8 -> 12; comment lists the 12 rendered columns
(Date / Account / Provider / Service / Count / Term / Payment /
Monthly Cost / Upfront Cost / Monthly Savings / Created by / Actions).
- inventory.ts:86 — active-commitments skeleton comment: "10 cols" ->
"11 cols" to match ACTIVE_COMMITMENTS_COLS (the call site already
uses the constant, so this is comment-only).
Verified against the rendered <th> lists in renderHistoryList
(history.ts:650-663), the pending-approval queue (history.ts:946-959),
and renderActiveCommitmentsTable's headers array
(inventory.ts:156). Test suite (10 suites / 202 tests) and
tsc --noEmit both pass.
1 parent 74148ec commit ac140fc
2 files changed
Lines changed: 11 additions & 10 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
210 | 210 | | |
211 | 211 | | |
212 | 212 | | |
213 | | - | |
| 213 | + | |
214 | 214 | | |
215 | | - | |
| 215 | + | |
216 | 216 | | |
217 | | - | |
218 | | - | |
219 | | - | |
220 | | - | |
221 | | - | |
222 | | - | |
| 217 | + | |
| 218 | + | |
| 219 | + | |
| 220 | + | |
| 221 | + | |
| 222 | + | |
| 223 | + | |
223 | 224 | | |
224 | | - | |
| 225 | + | |
225 | 226 | | |
226 | 227 | | |
227 | 228 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
110 | 110 | | |
111 | 111 | | |
112 | 112 | | |
113 | | - | |
| 113 | + | |
114 | 114 | | |
115 | 115 | | |
116 | 116 | | |
| |||
0 commit comments