fix(db): renumber cancelled->canceled migration 000082 to 000084

Main now tops at migration 000083 (ladder_execution_enabled, PR #1396).
golang-migrate applies only versions strictly greater than the current
schema version, so a 000082 migration would be silently skipped on any
DB already advanced to 000083 (prod / staging): the cancelled->canceled
rename would never run.

Renumber to 000084, the next free slot above main's max (PR #808 is
taking 000085, so use 000084 exactly). Renames the up/down SQL and the
integration test file, bumps the pinned version constants
(renameCanceledVersion 82->84, renameCanceledPrevVersion 81->83, the
version immediately below now that 000083 sits directly beneath), and
updates every 000082 reference in comments, OpenAPI, the frontend
history/riexchange notes, and the .golangci.yml misspell exemption path.

Collision-checked: no 000084 exists on origin/main. Verified on a fresh
testcontainer PG that the full chain migrates cleanly through 000084
(Database migrations completed successfully (version: 84)) and the
expand/rollback integration tests pass.

Author: cristim

.golangci.yml

@@ -135,7 +135,7 @@ linters:
         text: "cancelled|initialised"
       - linters:
           - misspell
-        path: internal/database/postgres/migrations/000082_rename_cancelled_to_canceled_test\.go
+        path: internal/database/postgres/migrations/000084_rename_cancelled_to_canceled_test\.go
     paths:
       - third_party$
       - builtin$

frontend/src/__tests__/history.test.ts

@@ -403,15 +403,15 @@ describe('History Module', () => {
       });
     });
 
-    // Migration 000082 (expand-contract rename cancelled -> canceled): during
+    // Migration 000084 (expand-contract rename cancelled -> canceled): during
     // the rolling deploy window the backend returns BOTH spellings on
     // /api/history. Each must render as the muted "Cancelled" badge, be
     // counted under the Cancelled chip, and be visible when that chip is
     // clicked. Pre-fix the FE only matched 'cancelled', so 'canceled' rows
     // fell through to the green Completed badge and were silently bucketed
     // into the Completed total -- a user-facing regression that defeats the
     // purpose of the rename.
-    test('Cancelled badge + chip surface BOTH spellings during deploy window (migration 000082)', async () => {
+    test('Cancelled badge + chip surface BOTH spellings during deploy window (migration 000084)', async () => {
       (api.getHistory as jest.Mock).mockResolvedValue({
         summary: {},
         purchases: [

frontend/src/history.ts

@@ -380,7 +380,7 @@ function statusBadgeHTML(status: string): string {
       return '<span class="badge badge-warning">In Progress</span>';
     case 'canceled':
     case 'cancelled':
-      // Migration 000082 (expand-contract rename): the backend may return
+      // Migration 000084 (expand-contract rename): the backend may return
       // either the new US spelling ('canceled') or the legacy British
       // spelling ('cancelled') during the rolling deploy window. Match both
       // so a row written by EITHER old or new code renders the muted Cancelled
@@ -414,7 +414,7 @@ function buildStatusChipRowHTML(purchases: HistoryPurchase[], active: StatusFilt
   for (const p of purchases) {
     const s = normalizeStatus(p).toLowerCase();
     if (s === 'pending' || s === 'notified' || isInFlightStatus(s)) counts.pending++;
-    // Migration 000082 (expand-contract rename): the backend may return
+    // Migration 000084 (expand-contract rename): the backend may return
     // either spelling during the rolling deploy window. Counting only the
     // British spelling would silently bucket new 'canceled' rows into the
     // Completed total, hiding them from the user.
@@ -745,7 +745,7 @@ function renderHistoryList(purchases: HistoryPurchase[]): void {
     const s = normalizeStatus(p).toLowerCase();
     if (activeStatusFilter === 'pending') return s === 'pending' || s === 'notified' || isInFlightStatus(s);
     if (activeStatusFilter === 'completed') return s === 'completed' || s === 'partially_completed' || !p.status;
-    // Migration 000082: the Cancelled chip key is 'cancelled' (British, kept
+    // Migration 000084: the Cancelled chip key is 'cancelled' (British, kept
     // stable for URL/state compatibility) but it must surface BOTH spellings
     // during the expand-contract deploy window so new 'canceled' rows aren't
     // hidden from the filter.
@@ -765,7 +765,7 @@ function renderHistoryList(purchases: HistoryPurchase[]): void {
     const s = normalizeStatus(p).toLowerCase();
     if (activeStatusFilter === 'pending') return s === 'pending' || s === 'notified' || isInFlightStatus(s);
     if (activeStatusFilter === 'completed') return s === 'completed' || s === 'partially_completed' || !p.status;
-    // Migration 000082: surface BOTH spellings under the Cancelled chip during
+    // Migration 000084: surface BOTH spellings under the Cancelled chip during
     // the expand-contract deploy window (see the equivalent guard above).
     if (activeStatusFilter === 'cancelled') return s === 'cancelled' || s === 'canceled';
     return s === activeStatusFilter;

frontend/src/riexchange.ts

@@ -1796,7 +1796,7 @@ function getStatusBadgeClass(status: string): string {
     case 'pending': return 'status-badge pending';
     case 'processing': return 'status-badge running';
     case 'failed': return 'status-badge failed';
-    // Migration 000082 (expand-contract rename, ri_exchange_history.status):
+    // Migration 000084 (expand-contract rename, ri_exchange_history.status):
     // backend may return either spelling during the rolling deploy window.
     // Match both so a row written by EITHER old or new code keeps the muted
     // "disabled" visual treatment instead of falling through to the default

internal/api/handler_history.go

@@ -116,7 +116,7 @@ func (h *Handler) getHistory(ctx context.Context, req *events.LambdaFunctionURLR
 // the Revoke button unreachable (issue #290, second-wave CR Finding E).
 // Both the US-spelling status (config.StatusCanceled) and the legacy British
 // spelling (config.LegacyStatusCanceled) are listed: during the expand-contract
-// rename (migration 000082) old code may still write the legacy value before
+// rename (migration 000084) old code may still write the legacy value before
 // the rolling deploy completes. The contract migration (#1278) normalizes the
 // data once the deploy is verified stable; drop the legacy entry here then.
 var historyExecutionStatuses = []string{"pending", "notified", "scheduled", "approved", "running", "paused", "completed", "partially_completed", "failed", "expired", config.StatusCanceled, config.LegacyStatusCanceled}
@@ -336,7 +336,7 @@ func annotateHistoryRowByStatus(row *config.PurchaseHistoryRecord, exec config.P
 		row.StatusDescription = "approval link expired (not approved within 7 days)"
 	case config.StatusCanceled, config.LegacyStatusCanceled:
 		// The legacy British spelling is still matched during the
-		// expand-contract rename (migration 000082) until the contract
+		// expand-contract rename (migration 000084) until the contract
 		// migration (#1278) normalizes and drops it.
 		annotateCancelled(row, exec, approver)
 	default:
@@ -1019,7 +1019,7 @@ func summarizePurchaseHistory(purchases []config.PurchaseHistoryRecord) HistoryS
 			// realized savings (issue #736). Exclude from all dollar KPIs and
 			// from TotalCompleted -- the money was never committed. The legacy
 			// British spelling is matched alongside the US one during the
-			// expand-contract rename (migration 000082) so legacy rows can't
+			// expand-contract rename (migration 000084) so legacy rows can't
 			// inflate KPIs mid-deploy; the contract migration (#1278) drops it
 			// once the deploy is stable.
 			continue

internal/api/handler_history_test.go

@@ -1712,7 +1712,7 @@ func TestSummarizePurchaseHistory_CancelledExcludedFromKPIs(t *testing.T) {
 		// appear in the dollar KPIs or TotalCompleted. One uses the new US
 		// spelling (config.StatusCanceled) and one the legacy British spelling
 		// (config.LegacyStatusCanceled): during the expand-contract rename
-		// (migration 000082) a mixed fleet still emits the legacy spelling, so
+		// (migration 000084) a mixed fleet still emits the legacy spelling, so
 		// the dual-spelling read path must exclude BOTH. The constant carries
 		// the legacy value without a literal the US-locale misspell linter would
 		// flag (and without a nolint). Drop the legacy fixture once the contract

internal/api/handler_purchases.go

@@ -398,7 +398,7 @@ func (h *Handler) cancelOrRecoverExecution(ctx context.Context, executionID stri
 		return nil, fmt.Errorf("disable plan: failed to get execution %s after conflict: %w", executionID, getErr)
 	}
 	// Accept both spellings: during the expand-contract rename (migration
-	// 000082) a concurrent legacy cancel may have written the legacy value
+	// 000084) a concurrent legacy cancel may have written the legacy value
 	// before the rolling deploy completes. The contract migration (#1278)
 	// normalizes the data, after which LegacyStatusCanceled can be removed.
 	if existing.Status != config.StatusCanceled && existing.Status != config.LegacyStatusCanceled {

internal/api/openapi.yaml

@@ -2441,7 +2441,7 @@ components:
           type: string
         status:
           type: string
-          # Migration 000082 (expand-contract rename, cancelled -> canceled):
+          # Migration 000084 (expand-contract rename, cancelled -> canceled):
           # both spellings are valid during the rolling deploy window. New code
           # writes "canceled" (US); rows written by old code retain "cancelled"
           # until the CONTRACT migration (#1278) normalizes them, at which

internal/config/types.go

@@ -287,7 +287,7 @@ type PurchaseExecution struct {
 	// endpoint). Nil on legacy token-only approve/cancel paths; the
 	// handler / History UI falls back to the notification email as the
 	// accountable party in that case. Nullable TEXT in Postgres.
-	// DB column: canceled_by (migration 000082 adds it alongside the legacy
+	// DB column: canceled_by (migration 000084 adds it alongside the legacy
 	// British-spelled column; reads COALESCE the two during EXPAND).
 	ApprovedBy *string `json:"approved_by,omitempty" dynamodbav:"approved_by,omitempty"`
 	CanceledBy *string `json:"canceled_by,omitempty" dynamodbav:"canceled_by,omitempty"`
@@ -370,7 +370,7 @@ type PurchaseExecution struct {
 const StatusCanceled = "canceled"
 
 // LegacyStatusCanceled is the British-spelling status value old code writes
-// during the expand-contract rename (migration 000082). It is constructed by
+// during the expand-contract rename (migration 000084). It is constructed by
 // concatenation rather than a single literal so the US-locale misspell linter
 // does not flag it -- this lets the dual-spelling read paths reference the
 // legacy value without a //nolint:misspell directive. The CONTRACT migration

…82_rename_cancelled_to_canceled.down.sql …84_rename_cancelled_to_canceled.down.sqlinternal/database/postgres/migrations/000082_rename_cancelled_to_canceled.down.sql renamed to internal/database/postgres/migrations/000084_rename_cancelled_to_canceled.down.sql internal/database/postgres/migrations/000082_rename_cancelled_to_canceled.down.sql renamed to internal/database/postgres/migrations/000084_rename_cancelled_to_canceled.down.sql

@@ -1,4 +1,4 @@
--- Rollback 000082: reverse the EXPAND migration.
+-- Rollback 000084: reverse the EXPAND migration.
 --
 -- Restores the single-spelling constraints (British 'cancelled' only),
 -- removes the canceled_by column added in the up migration, and converts any