Skip to content

Commit 5cd3490

Browse files
committed
chore(deploy): remove orphaned internal/deploy package
The internal/deploy package (Docker build/push, ECR login/repo management, frontend S3+CloudFront upload, deployment profiles) has zero importers outside its own test files. Actual deployment is handled by the GitHub workflows and terraform/. The dead code was still compiled, tested in CI, and re-assessed in every security scan for no benefit (ARCH-13, P3). Verification that the package is orphaned: - repo-wide grep for the import path "internal/deploy" across all file types (Go, workflows, scripts, docs, Makefiles): zero hits outside the package itself - repo-wide grep for distinctive exported identifiers (NewDockerService, NewECRService, NewFrontendService, DeploymentConfig, LoginToPublicECR, BuildAndUpload, ...): zero hits outside the package itself Also runs go mod tidy: the cloudfront, ecr, ecrpublic and s3 AWS SDK modules were only used by this package and drop out of go.mod. go build ./..., go vet ./... and go test ./internal/... all pass after removal. Closes #1202
1 parent 4108e51 commit 5cd3490

13 files changed

Lines changed: 1 addition & 2799 deletions

‎go.mod‎

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@ require (
7979
google.golang.org/genproto/googleapis/rpc v0.0.0-20260401001100-f93e5f3e9f0f // indirect
8080
google.golang.org/grpc v1.80.0
8181
google.golang.org/protobuf v1.36.11
82-
gopkg.in/yaml.v3 v3.0.1
82+
gopkg.in/yaml.v3 v3.0.1 // indirect
8383
)
8484

8585
require (
@@ -94,13 +94,9 @@ require (
9494
github.com/LeanerCloud/CUDly/providers/azure v0.0.0
9595
github.com/LeanerCloud/CUDly/providers/gcp v0.0.0
9696
github.com/aws/aws-lambda-go v1.47.0
97-
github.com/aws/aws-sdk-go-v2/service/cloudfront v1.58.2
98-
github.com/aws/aws-sdk-go-v2/service/ecr v1.54.2
99-
github.com/aws/aws-sdk-go-v2/service/ecrpublic v1.38.7
10097
github.com/aws/aws-sdk-go-v2/service/kms v1.50.4
10198
github.com/aws/aws-sdk-go-v2/service/lambda v1.89.0
10299
github.com/aws/aws-sdk-go-v2/service/organizations v1.45.3
103-
github.com/aws/aws-sdk-go-v2/service/s3 v1.93.0
104100
github.com/aws/aws-sdk-go-v2/service/secretsmanager v1.40.3
105101
github.com/aws/aws-sdk-go-v2/service/sesv2 v1.42.0
106102
github.com/aws/aws-sdk-go-v2/service/sns v1.34.0
@@ -135,8 +131,6 @@ require (
135131
github.com/Microsoft/go-winio v0.6.2 // indirect
136132
github.com/aws/aws-sdk-go-v2/aws/protocol/eventstream v1.7.8 // indirect
137133
github.com/aws/aws-sdk-go-v2/internal/v4a v1.4.15 // indirect
138-
github.com/aws/aws-sdk-go-v2/service/internal/checksum v1.9.6 // indirect
139-
github.com/aws/aws-sdk-go-v2/service/internal/s3shared v1.19.15 // indirect
140134
github.com/cenkalti/backoff/v4 v4.3.0 // indirect
141135
github.com/cespare/xxhash/v2 v2.3.0 // indirect
142136
github.com/cncf/xds/go v0.0.0-20251210132809-ee656c7534f5 // indirect

‎go.sum‎

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -116,26 +116,16 @@ github.com/aws/aws-sdk-go-v2/internal/ini v1.7.2 h1:GrSw8s0Gs/5zZ0SX+gX4zQjRnRsM
116116
github.com/aws/aws-sdk-go-v2/internal/ini v1.7.2/go.mod h1:6fQQgfuGmw8Al/3M2IgIllycxV7ZW7WCdVSqfBeUiCY=
117117
github.com/aws/aws-sdk-go-v2/internal/v4a v1.4.15 h1:NLYTEyZmVZo0Qh183sC8nC+ydJXOOeIL/qI/sS3PdLY=
118118
github.com/aws/aws-sdk-go-v2/internal/v4a v1.4.15/go.mod h1:Z803iB3B0bc8oJV8zH2PERLRfQUJ2n2BXISpsA4+O1M=
119-
github.com/aws/aws-sdk-go-v2/service/cloudfront v1.58.2 h1:Sm/sQAe/54oCaXj5/xOtMkMvpDafNZhQ38DsyarIBR0=
120-
github.com/aws/aws-sdk-go-v2/service/cloudfront v1.58.2/go.mod h1:SxEwhpfvzjK0vR8LfHeOkHeIcpaFU5ZgVbuBo3J4w2A=
121119
github.com/aws/aws-sdk-go-v2/service/costexplorer v1.61.0 h1:T9Ms/lReZ3iRFdAtXS9IlhLbWoM2fKUOjJwcgmjT7ig=
122120
github.com/aws/aws-sdk-go-v2/service/costexplorer v1.61.0/go.mod h1:AFQ/jaLX9hhiVPxyNKowOchXlpwIYSfYg8bzuXi2gBA=
123121
github.com/aws/aws-sdk-go-v2/service/ec2 v1.251.2 h1:6TssXFfLHcwUS5E3MdYKkCFeOrYVBlDhJjs5kRJp0ic=
124122
github.com/aws/aws-sdk-go-v2/service/ec2 v1.251.2/go.mod h1:MXJiLJZtMqb2dVXgEIn35d5+7MqLd4r8noLen881kpk=
125-
github.com/aws/aws-sdk-go-v2/service/ecr v1.54.2 h1:2Mdcg3Rphkj48toLpLrckQ9T0ce08GrMfaL0l2anzLY=
126-
github.com/aws/aws-sdk-go-v2/service/ecr v1.54.2/go.mod h1:gwUKatMqrynzKA8L0MDAlvAvGB7LIzmTm6uFRqD+4CU=
127-
github.com/aws/aws-sdk-go-v2/service/ecrpublic v1.38.7 h1:NHy1+Jq8gVp8fSLF6Z8SazA+R4Qzsbla/0SbHHReH4Y=
128-
github.com/aws/aws-sdk-go-v2/service/ecrpublic v1.38.7/go.mod h1:KxsaVRXo+DeRMHVp65WqyM49XZiS6n74lEGQindkdgA=
129123
github.com/aws/aws-sdk-go-v2/service/elasticache v1.50.3 h1:uiWSUtTWqpvhP7KSEpVpIm0LqOtXtzOx049rmukP/gI=
130124
github.com/aws/aws-sdk-go-v2/service/elasticache v1.50.3/go.mod h1:igTRxVYuxplMPKS5J1AEThtbeFJQhUz845YtDRDzJhY=
131125
github.com/aws/aws-sdk-go-v2/service/internal/accept-encoding v1.13.4 h1:0ryTNEdJbzUCEWkVXEXoqlXV72J5keC1GvILMOuD00E=
132126
github.com/aws/aws-sdk-go-v2/service/internal/accept-encoding v1.13.4/go.mod h1:HQ4qwNZh32C3CBeO6iJLQlgtMzqeG17ziAA/3KDJFow=
133-
github.com/aws/aws-sdk-go-v2/service/internal/checksum v1.9.6 h1:P1MU/SuhadGvg2jtviDXPEejU3jBNhoeeAlRadHzvHI=
134-
github.com/aws/aws-sdk-go-v2/service/internal/checksum v1.9.6/go.mod h1:5KYaMG6wmVKMFBSfWoyG/zH8pWwzQFnKgpoSRlXHKdQ=
135127
github.com/aws/aws-sdk-go-v2/service/internal/presigned-url v1.13.15 h1:3/u/4yZOffg5jdNk1sDpOQ4Y+R6Xbh+GzpDrSZjuy3U=
136128
github.com/aws/aws-sdk-go-v2/service/internal/presigned-url v1.13.15/go.mod h1:4Zkjq0FKjE78NKjabuM4tRXKFzUJWXgP0ItEZK8l7JU=
137-
github.com/aws/aws-sdk-go-v2/service/internal/s3shared v1.19.15 h1:wsSQ4SVz5YE1crz0Ap7VBZrV4nNqZt4CIBBT8mnwoNc=
138-
github.com/aws/aws-sdk-go-v2/service/internal/s3shared v1.19.15/go.mod h1:I7sditnFGtYMIqPRU1QoHZAUrXkGp4SczmlLwrNPlD0=
139129
github.com/aws/aws-sdk-go-v2/service/kms v1.50.4 h1:PgD1y0ZagPokGIZPmejCBUySBzOFDN+leZxCOfb1OEQ=
140130
github.com/aws/aws-sdk-go-v2/service/kms v1.50.4/go.mod h1:FfXDb5nXrsoGgxsBFxwxr3vdHXheC2tV+6lmuLghhjQ=
141131
github.com/aws/aws-sdk-go-v2/service/lambda v1.89.0 h1:e4NAllPs/ygQ7W4dTlAuP5N7QpCT+rTij3S8UOv2DD4=
@@ -150,8 +140,6 @@ github.com/aws/aws-sdk-go-v2/service/rds v1.97.3 h1:YBcCzc0S/DQN6Mg1sUtcyd8TY6T3
150140
github.com/aws/aws-sdk-go-v2/service/rds v1.97.3/go.mod h1:Xe+NMlf/DY/XTXSevASAjGRika9Qt2LnuCDLtos03ms=
151141
github.com/aws/aws-sdk-go-v2/service/redshift v1.58.3 h1:rXoN3hvwUimq8Z6uu2lsYncGPDQS+i70Rp1G0c0C/zk=
152142
github.com/aws/aws-sdk-go-v2/service/redshift v1.58.3/go.mod h1:OfB6wMvsEozZQbEjgqe6J68wF5u7wXNEAdG4FLKLk/Y=
153-
github.com/aws/aws-sdk-go-v2/service/s3 v1.93.0 h1:IrbE3B8O9pm3lsg96AXIN5MXX4pECEuExh/A0Du3AuI=
154-
github.com/aws/aws-sdk-go-v2/service/s3 v1.93.0/go.mod h1:/sJLzHtiiZvs6C1RbxS/anSAFwZD6oC6M/kotQzOiLw=
155143
github.com/aws/aws-sdk-go-v2/service/savingsplans v1.31.0 h1:cGxQBpfDQZNtMjGlCd2ALGnKJCjPskOTdCRR+dZceRU=
156144
github.com/aws/aws-sdk-go-v2/service/savingsplans v1.31.0/go.mod h1:Osfg3coILx7t46vKS5OWoov989SA4fCoGwSuYrztNEg=
157145
github.com/aws/aws-sdk-go-v2/service/secretsmanager v1.40.3 h1:QYBY43OlvzRPww1gSZ1kihyqzXg32rweA3fql5ubSLA=

‎internal/deploy/coverage_extra_test.go‎

Lines changed: 0 additions & 211 deletions
This file was deleted.

‎internal/deploy/docker.go‎

Lines changed: 0 additions & 114 deletions
This file was deleted.

0 commit comments

Comments
 (0)