Converting macros within RTEs (not block list RTEs)

[jplatfordquba]

I am currently attempting to upgrade from Umbraco 13 -> Umbraco 17. I found your package and it works great for macros in block lists - which is fantastic!

However, we have 140+ pages to convert and around half are just RTEs on pages (not within block lists).

The best enhancement would be to also handle macros within page field RTEs.

However, if not possible, a smaller enhancement would be a setting that allows converting of all pages even when one (or more) error. So in my example, running the conversion would successfully convert macros within block lists, but flag pages with macros in page RTEs that it cannot currently convert.

Thanks!

[Lantzify]

Hello @jplatfordquba ! Thank you for creating this issue!

---

It should already do that! It looks for all datatypes that has alias of Umbraco.TinyMCE.
If you take a look here at my screenshots. I've got a regular page with just a RTE and no block list. And it gets detected the package!

If it doesn't find yours. Make sure you have the latest version installed.
Make sure that the data type has Umbraco.TinyMCE as alias.
If it still doesn't show for you. Please let me know.
(Also, please provide screenshots. They help me a lot to understand the issue!)

---

That's a great! Idea! I'll implement that as soon as possible! 😀

[jplatfordquba]

Hi,

Just to clarify, it does find these pages, but it errors when converting them (sorry should have provided more detail first time round!). Here's some further info:

Here you can see it finds two document types (one has macros in block list RTEs and one has macros in a page prop RTEs):

Attempting to convert one with macros in a page prop RTE:

Converting three pages with macros in block list RTEs:

Here's the message output to the log viewer:

Here's the macro in the page prop RTE that I showed erroring, as you can see, nothing out of the ordinary:

Here's a macro in a block list RTE (almost exactly the same, this has now been converted as expected):

Hopefully this helpful!

I can confirm that the data type is Umbraco.TinyMCE. For ref, I have installed the latest version of the package (2.1.0) and am on Umbraco 13.13.0.

[Lantzify]

Gotcha! Thank you for clarifying!

I think I see the issue! Ive gone ahead and made a new release 2.1.1 that should fix this!
In that release also, I've made it so if 1 fails. It still processes the other items! Thank you for suggesting it! #H5YR

Try it out and let me know if that fixed it! 😀

[jplatfordquba]

Hi,

Thanks for this, I've just tested it and unfortunately it still doesn't convert the macros (same error as before).

The other change, to process macros even if one (or more) fail, does seem to work though :)

[Lantzify]

I've gone ahead and released 2.1.2 which I believe will address this!

Try it out and let me know if that fixed it! 😀