Skip to content

Profile angle calculations #182

@vidanovic

Description

@vidanovic

Profile angle calculations should not depend on Incoming/Outgoing direction. Coordinate system is entirely changing and Theta and Phi are calculated in the same way for either Incoming or Outgoing directions.
Should be this:

double BSDFDirections::correctPhiForOutgoingDirection(double currentPhi)
{
return (currentPhi > 360) ? currentPhi - 360 : currentPhi;
}

instead of:
double BSDFDirections::correctPhiForOutgoingDireciton(const BSDFDirection & t_Side,
const size_t nPhis,
double currentPhi)
{
double correctedPhi =
(t_Side == BSDFDirection::Outgoing && nPhis != 1) ? currentPhi + 180 : currentPhi;
return (correctedPhi > 360) ? correctedPhi - 360 : correctedPhi;
}

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions