Remove leftover EXPIRATION_PERMANENT field from FormData

Author: Defective4

src/main/java/net/discordjug/javabot/systems/staff_commands/forms/FormInteractionManager.java

@@ -223,9 +223,8 @@ public static Modal createFormModal(FormData form) {
 	 * Gets expiration time from the slash comamnd event.
 	 *
 	 * @param event slash event to get expiration from.
-	 * @return an optional containing expiration time,
-	 *         {@link FormData#EXPIRATION_PERMANENT} if none given, or an empty
-	 *         optional if it's invalid.
+	 * @return an optional containing expiration time, or an empty optional if it's
+	 *         not present.
 	 * @throws IllegalArgumentException if the date doesn't follow the format.
 	 */
 	public static Optional<Instant> parseExpiration(SlashCommandInteractionEvent event)

src/main/java/net/discordjug/javabot/systems/staff_commands/forms/model/FormData.java

@@ -5,6 +5,7 @@
 import java.util.List;
 import java.util.Objects;
 import java.util.Optional;
+
 import net.discordjug.javabot.systems.staff_commands.forms.FormInteractionManager;
 import net.dv8tion.jda.api.components.label.Label;
 
@@ -35,12 +36,6 @@
 public record FormData(long id, List<FormField> fields, String title, long submitChannel, String submitMessage,
 		Long messageId, Long messageChannel, Instant expiration, boolean closed, boolean onetime) {
 
-	/**
-	 * Setting {@link FormData#expiration} to this value indicates, that the form
-	 * will never expire.
-	 */
-	public static final long EXPIRATION_PERMANENT = -1;
-
 	/**
 	 * The main constructor.
 	 */