From 8f5a28acaa71ca72d44cd68148c626844981bf64 Mon Sep 17 00:00:00 2001
From: Johannes Meyer <johannes.meyer@icinga.com>
Date: Wed, 6 May 2026 08:52:14 +0200
Subject: [PATCH] js: Add and utilize function `isSpecialKeypress`
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

This is a way better implementation instead of just checking
whether the pressed key's label starts with an uppercase char.
(e.g. `Escape`) Problem is, uppercase single chars also match…

This could previously be observed when trying to type a value
inside an operator input in the search bar. Normally this
switches to the value input automatically, but an uppercase
char was tried to identify as operator.

In the `Completer` implementation this uncovered dead code
on the other hand. `onKeyPress` seems to have had the job to
hide the suggestions in case the user typed one manually.
Upon testing this now with an corrected check (`event.key`
alone does not match a suggestion as it's only single char)
this worked but the suggestions appeared immediately again.
I've removed it now as it was broken prior and doesn't make
any sense either nowadays, suggestions need to be always
visible in order to confirm the validity of the input.
---
 asset/js/functions.js          | 21 +++++++++++++++++++++
 asset/js/widget/BaseInput.js   |  4 ++--
 asset/js/widget/Completer.js   | 12 ------------
 asset/js/widget/FilterInput.js |  4 ++--
 4 files changed, 25 insertions(+), 16 deletions(-)
 create mode 100644 asset/js/functions.js

diff --git a/asset/js/functions.js b/asset/js/functions.js
new file mode 100644
index 000000000..359720d63
--- /dev/null
+++ b/asset/js/functions.js
@@ -0,0 +1,21 @@
+(function (root, factory) {
+    "use strict";
+
+    if (typeof define === "function" && define.icinga) {
+        define(["exports"], factory);
+    } else {
+        factory(root.iplWebFunctions = root.iplWebFunctions || {});
+    }
+}(self, function (exports) {
+    /**
+     * Checks if the given keyboard event represents a special key press.
+     *
+     * @param {KeyboardEvent} event - The keyboard event to check.
+     * @returns {boolean} True if the event represents a special key press, false otherwise.
+     */
+    function isSpecialKeyPress(event) {
+        return event.key.length > 1 || event.ctrlKey || event.metaKey;
+    }
+
+    exports.isSpecialKeyPress = isSpecialKeyPress;
+}));
diff --git a/asset/js/widget/BaseInput.js b/asset/js/widget/BaseInput.js
index 360d50267..87598e034 100644
--- a/asset/js/widget/BaseInput.js
+++ b/asset/js/widget/BaseInput.js
@@ -1,4 +1,4 @@
-define(["../notjQuery", "Completer"], function ($, Completer) {
+define(["../notjQuery", "../functions", "Completer"], function ($, functions, Completer) {
 
     "use strict";
 
@@ -803,7 +803,7 @@ define(["../notjQuery", "Completer"], function ($, Completer) {
             let input = event.target;
             let termIndex = Number(input.parentNode.dataset.index);
 
-            if (this.hasSyntaxError(input) && ! (/[A-Z]/.test(event.key.charAt(0)) || event.ctrlKey || event.metaKey)) {
+            if (this.hasSyntaxError(input) && ! functions.isSpecialKeyPress(event)) {
                 // Clear syntax error flag if the user types entirely new input after having selected the entire input
                 // (This way the input isn't empty but switches from input to input immediately, causing the clearing
                 // in onInput to not work)
diff --git a/asset/js/widget/Completer.js b/asset/js/widget/Completer.js
index a11548a3f..d6d36b0d1 100644
--- a/asset/js/widget/Completer.js
+++ b/asset/js/widget/Completer.js
@@ -695,18 +695,6 @@ define(["../notjQuery"], function ($) {
                         event.preventDefault();
                         this.moveToSuggestion();
                     }
-
-                    break;
-                default:
-                    if (/[A-Z]/.test(event.key.charAt(0)) || event.key === '"') {
-                        // Ignore control keys not resulting in new input data
-                        break;
-                    }
-
-                    let typedSuggestion = this.termSuggestions.querySelector(`[value="${ event.key }"]`);
-                    if (typedSuggestion !== null) {
-                        this.hideSuggestions();
-                    }
             }
         }
 
diff --git a/asset/js/widget/FilterInput.js b/asset/js/widget/FilterInput.js
index 3f1d94783..51cb0f78e 100644
--- a/asset/js/widget/FilterInput.js
+++ b/asset/js/widget/FilterInput.js
@@ -1,4 +1,4 @@
-define(["../notjQuery", "BaseInput"], function ($, BaseInput) {
+define(["../notjQuery", "../functions", "BaseInput"], function ($, functions, BaseInput) {
 
     "use strict";
 
@@ -1350,7 +1350,7 @@ define(["../notjQuery", "BaseInput"], function ($, BaseInput) {
             } else if (input.selectionStart !== input.selectionEnd) {
                 // In case the user selected a range of text, do nothing
                 return;
-            } else if (/[A-Z]/.test(event.key.charAt(0)) || event.ctrlKey || event.metaKey) {
+            } else if (functions.isSpecialKeyPress(event)) {
                 // Ignore control keys not resulting in new input data
                 // TODO: Remove this and move the entire block into `onInput`
                 //       once Safari supports `InputEvent.data`