From c0dc346ae5016d207d280a9569b0fa50b3866b32 Mon Sep 17 00:00:00 2001 From: "Alexander A. Klimov" Date: Thu, 12 Mar 2026 16:59:58 +0100 Subject: [PATCH 1/2] Don't upload 32 bit MSIs to Chocolatey Precisely speaking, `tools/win32/build-choco.ps1` creates a PS script that downloads our MSIs from packages.icinga.com - to be uploaded to Chocolatey. This PS script now omits 32 bit MSIs. Despite being a niche, 32-bit MSIs currently get uploaded to Chocolatey. Their antiviruses block our whole releases due to the 32-bit MSIs being fishy. --- choco/chocolateyInstall.ps1.template.cmake | 4 ---- tools/win32/build-choco.ps1 | 8 -------- 2 files changed, 12 deletions(-) diff --git a/choco/chocolateyInstall.ps1.template.cmake b/choco/chocolateyInstall.ps1.template.cmake index 424a737789c..531b56145d4 100644 --- a/choco/chocolateyInstall.ps1.template.cmake +++ b/choco/chocolateyInstall.ps1.template.cmake @@ -1,18 +1,14 @@ $packageName= 'icinga2' $toolsDir = "$(Split-Path -Parent $MyInvocation.MyCommand.Definition)" -$url = 'https://packages.icinga.com/windows/Icinga2-v${CHOCO_VERSION_SHORT}-x86.msi' $url64 = 'https://packages.icinga.com/windows/Icinga2-v${CHOCO_VERSION_SHORT}-x86_64.msi' $packageArgs = @{ packageName = $packageName fileType = 'msi' - url = $url url64bit = $url64 silentArgs = "/qn /norestart" validExitCodes= @(0) softwareName = 'Icinga 2*' - checksum = '%CHOCO_32BIT_CHECKSUM%' - checksumType = 'sha256' checksum64 = '%CHOCO_64BIT_CHECKSUM%' checksumType64= 'sha256' } diff --git a/tools/win32/build-choco.ps1 b/tools/win32/build-choco.ps1 index 32138bdf272..c2bf428d238 100644 --- a/tools/win32/build-choco.ps1 +++ b/tools/win32/build-choco.ps1 @@ -15,13 +15,6 @@ if(-not (Test-Path "$($env:ICINGA2_BUILDPATH)\choco\chocolateyInstall.ps1.templa $chocoInstallScriptTemplatePath = "$($env:ICINGA2_BUILDPATH)\choco\chocolateyInstall.ps1.template" $chocoInstallScript = Get-Content $chocoInstallScriptTemplatePath -if(-not (Test-Path "$($env:ICINGA2_BUILDPATH)\*-x86.msi")) { - throw "Could not find Icinga 2 32 bit MSI package. Abort." -} - -$hashMSIpackage32 = Get-FileHash "$($env:ICINGA2_BUILDPATH)\*-x86.msi" -Write-Output "File Hash for 32 bit MSI package: $($hashMSIpackage32.Hash)." - if(-not (Test-Path "$($env:ICINGA2_BUILDPATH)\*-x86_64.msi")) { throw "Could not find Icinga 2 64 bit MSI package. Abort." } @@ -29,7 +22,6 @@ if(-not (Test-Path "$($env:ICINGA2_BUILDPATH)\*-x86_64.msi")) { $hashMSIpackage64 = Get-FileHash "$($env:ICINGA2_BUILDPATH)\*-x86_64.msi" Write-Output "File Hash for 32 bit MSI package: $($hashMSIpackage64.Hash)" -$chocoInstallScript = $chocoInstallScript.Replace("%CHOCO_32BIT_CHECKSUM%", "$($hashMSIpackage32.Hash)") $chocoInstallScript = $chocoInstallScript.Replace("%CHOCO_64BIT_CHECKSUM%", "$($hashMSIpackage64.Hash)") Write-Output $chocoInstallScript From c55e171f4b4933bcdfe3b074dbd66227527c9e24 Mon Sep 17 00:00:00 2001 From: "Alexander A. Klimov" Date: Fri, 13 Mar 2026 14:16:25 +0100 Subject: [PATCH 2/2] Fix copy and paste error in build log message --- tools/win32/build-choco.ps1 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/win32/build-choco.ps1 b/tools/win32/build-choco.ps1 index c2bf428d238..2ee0f075c78 100644 --- a/tools/win32/build-choco.ps1 +++ b/tools/win32/build-choco.ps1 @@ -20,7 +20,7 @@ if(-not (Test-Path "$($env:ICINGA2_BUILDPATH)\*-x86_64.msi")) { } $hashMSIpackage64 = Get-FileHash "$($env:ICINGA2_BUILDPATH)\*-x86_64.msi" -Write-Output "File Hash for 32 bit MSI package: $($hashMSIpackage64.Hash)" +Write-Output "File Hash for 64 bit MSI package: $($hashMSIpackage64.Hash)" $chocoInstallScript = $chocoInstallScript.Replace("%CHOCO_64BIT_CHECKSUM%", "$($hashMSIpackage64.Hash)") Write-Output $chocoInstallScript