SWAPI: proton moments are inconsistent with other spacecraft

[hafarooki]

Description of the issue

Due to incorrect normalization of the response function, the densities reported by the L3 code are consistently too high compared to other spacecraft. Additionally, the spin phase variation is not handled correctly by the current algorithm.

Steps to reproduce the issue

Compare SWAPI L3 moments to moments from another spacecraft side-by-side, and the difference is obvious.

Expected vs Actual behavior

There should be a reasonable level of agreement.

Code Snippet (If applicable)

Code

Additional notes, affected areas, and suggested fixes

We (the SWAPI team) are close to completing a new fitting algorithm that fixes these problems, for which I intend to open a pull request soon.

[jtniehof]

Marking as feature since it's essentially a change in desired behavior / algorithm (although that's totally a matter of taste).

Is this for all products (l3a_proton-sw, l3a_alpha-sw, l3a_pui-he) or just one product / species?

[hafarooki]

I agree it does make sense to treat this as a feature request instead of a bug report.

I'd say particular issue is for protons, since WIND proton measurements are very reliable, and this issue stems from comparing protons with WIND. However, the changes needed to fix the proton issue will ultimately affect all of the above.

[jtniehof]

...I just noticed proton was in the title. Thanks! 😅