Skip to content

Commit 37620aa

Browse files
committed
Say what plain npm audit still reports, and why the gate omits dev
8 dev-only advisories remain, including the same nanoid one via vite -> postcss (that advisory covers <3.3.16 too). None reaches the shipped bundle. Measured on a fresh clone of the pushed tree.
1 parent d1fdf7e commit 37620aa

1 file changed

Lines changed: 5 additions & 0 deletions

File tree

docs/codebase/CONCERNS.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -60,6 +60,11 @@ carries `"nanoid@^5.0.0": "5.1.16"` in `overrides`, next to the existing
6060
`@assistant-ui` asks for, and the range key leaves `postcss`'s CommonJS
6161
`nanoid@3` alone (forcing ESM 5.x on it would break the Vite build).
6262

63+
Plain `npm audit`, without `--omit=dev`, still reports 8 advisories including
64+
that same `nanoid` one — it also covers `<3.3.16`, and `vite → postcss` pulls
65+
`nanoid@3.3.12`. Every one of those is dev-only and none reaches the shipped
66+
bundle, which is why the gate scopes itself to production dependencies.
67+
6368
The pin is the concern. It is our number, not the upstream's, so when
6469
`@assistant-ui` bumps its own `nanoid` this override can silently hold the tree
6570
back. Delete it, run `npm install && npm audit --omit=dev`, and if that is clean

0 commit comments

Comments
 (0)