From b711fdce5ee891445c21b24ad5dc4934ef178559 Mon Sep 17 00:00:00 2001 From: "google-labs-jules[bot]" <161369871+google-labs-jules[bot]@users.noreply.github.com> Date: Fri, 20 Mar 2026 06:29:58 +0000 Subject: [PATCH 1/2] =?UTF-8?q?=F0=9F=A7=AA=20Add=20missing=20username=20v?= =?UTF-8?q?alidation=20edge=20case=20tests?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Co-authored-by: is0692vs <135803462+is0692vs@users.noreply.github.com> --- src/lib/__tests__/validators.test.ts | 25 +++++++++++++++++++++++++ 1 file changed, 25 insertions(+) diff --git a/src/lib/__tests__/validators.test.ts b/src/lib/__tests__/validators.test.ts index 2c03998..283a714 100644 --- a/src/lib/__tests__/validators.test.ts +++ b/src/lib/__tests__/validators.test.ts @@ -77,4 +77,29 @@ describe("isValidGitHubUsername", () => { it("SQLインジェクション的な文字列は無効", () => { expect(isValidGitHubUsername("'; DROP TABLE users; --")).toBe(false); }); + + it("マルチバイト文字(日本語や絵文字)を含むユーザー名は無効", () => { + expect(isValidGitHubUsername("テスト")).toBe(false); + expect(isValidGitHubUsername("user😀")).toBe(false); + expect(isValidGitHubUsername("déjà-vu")).toBe(false); + }); + + it("空白文字や制御文字を含むユーザー名は無効", () => { + expect(isValidGitHubUsername(" testuser")).toBe(false); + expect(isValidGitHubUsername("testuser ")).toBe(false); + expect(isValidGitHubUsername("test\nuser")).toBe(false); + expect(isValidGitHubUsername("test\tuser")).toBe(false); + expect(isValidGitHubUsername("test\0user")).toBe(false); + }); + + it("ハイフンのみのユーザー名は無効", () => { + expect(isValidGitHubUsername("-")).toBe(false); + expect(isValidGitHubUsername("--")).toBe(false); + expect(isValidGitHubUsername("---")).toBe(false); + }); + + it("極端に長い文字列は無効 (ReDoS防止の確認)", () => { + expect(isValidGitHubUsername("a".repeat(1000))).toBe(false); + }); + }); From efd02a28a3833efcfdfc4f5b1ca76655943776ee Mon Sep 17 00:00:00 2001 From: is0692vs Date: Sat, 21 Mar 2026 13:35:31 +0900 Subject: [PATCH 2/2] test: tighten username validator review fixes --- src/lib/__tests__/validators.test.ts | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/src/lib/__tests__/validators.test.ts b/src/lib/__tests__/validators.test.ts index 283a714..1566421 100644 --- a/src/lib/__tests__/validators.test.ts +++ b/src/lib/__tests__/validators.test.ts @@ -92,13 +92,7 @@ describe("isValidGitHubUsername", () => { expect(isValidGitHubUsername("test\0user")).toBe(false); }); - it("ハイフンのみのユーザー名は無効", () => { - expect(isValidGitHubUsername("-")).toBe(false); - expect(isValidGitHubUsername("--")).toBe(false); - expect(isValidGitHubUsername("---")).toBe(false); - }); - - it("極端に長い文字列は無効 (ReDoS防止の確認)", () => { + it("極端に長い文字列は無効 (長さ上限の確認)", () => { expect(isValidGitHubUsername("a".repeat(1000))).toBe(false); });