Dead/duplicate interest-rate and storage-accessor code in logic.rs and storage.rs

[abayomicornelius]

Area

Project Registry / Code Quality

Complexity

Easy

File(s)

project_registry/src/logic.rs:61-75 (calculate_interest_rate), project_registry/src/storage.rs:4-35 (all six functions), vs. project_registry/src/lib.rs:1214-1218 (compute_rate)

Problem

logic::calculate_interest_rate implements the same rate formula as the private compute_rate in lib.rs, but with an added underflow guard that compute_rate lacks. A grep shows calculate_interest_rate is never called from lib.rs — it's defined but dead. Similarly, storage.rs's read_project/write_project/read_proposal/write_proposal/read_whitelist/write_whitelist are never referenced from lib.rs, which inlines env.storage() calls directly everywhere instead. Both modules are effectively dead abstractions that have drifted from what the contract actually does, risking a future storage/rate change being made in the "live" copy in lib.rs but not mirrored.

Scope

In:

• Either delete the unused functions, or refactor lib.rs to actually call through storage.rs/logic.rs.

Out:

• Any behavior change to the rate formula itself.

Acceptance Criteria

• No unused public functions remain in logic.rs/storage.rs, either because they're deleted or because lib.rs now calls them
• compute_rate and calculate_interest_rate are unified into one implementation

[cybermax4200]

@cybermax4200 has applied to work on this issue as part of the Stellar Wave Program's 7th wave.

Hello, I'm interested in resolving this issue.

ℹ️ Repo Maintainers: To accept this application, review their application or assign @cybermax4200 to this issue.

[Bilalishaq7]

@Bilalishaq7 has applied to work on this issue as part of the Stellar Wave Program's 7th wave.

Gooday maintainer,I'd love to take on this task, I can fix this and i'll submit a PR shortly after Assignment

ℹ️ Repo Maintainers: To accept this application, review their application or assign @Bilalishaq7 to this issue.

[ogaziedaniel80-droid]

@ogaziedaniel80-droid has applied to work on this issue as part of the Stellar Wave Program's 7th wave.

Hi maintainer, I would love to contribute to this issue

ℹ️ Repo Maintainers: To accept this application, review their application or assign @ogaziedaniel80-droid to this issue.

[temisan0x]

@temisan0x has applied to work on this issue as part of the Stellar Wave Program's 7th wave.

Hi! I'd like to take this issue. I've gone through the requirements and I'm confident I can implement a solution. ETA: 12 hours.

ℹ️ Repo Maintainers: To accept this application, review their application or assign @temisan0x to this issue.

[elijahbok14-sudo]

@elijahbok14-sudo has applied to work on this issue as part of the Stellar Wave Program's 7th wave.

Hi maintainer can i work on this issue

ℹ️ Repo Maintainers: To accept this application, review their application or assign @elijahbok14-sudo to this issue.