From 4fc117f32fec3938e6bda0d5de2fec998f52223b Mon Sep 17 00:00:00 2001 From: Larry Knox Date: Mon, 1 Jun 2026 08:55:58 -0500 Subject: [PATCH 1/7] Replace deprecated dsaltares/fetch-gh-release-asset with robinraju/release-downloader MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Fixes DEP0040/DEP0169 deprecation warnings and "Could not find asset id" error caused by the unmaintained dsaltares action. Replaces all 25 usages across 5 workflow files with robinraju/release-downloader@v1, mapping repo→repository, version tags/TAG→tag TAG, file→fileName, and target→out-file-path. Co-Authored-By: Claude Sonnet 4.6 --- .github/workflows/cmake-bintest.yml | 54 +++++++++------- .github/workflows/cmake-ctest.yml | 54 +++++++++------- .github/workflows/cmake-script.yml | 90 +++++++++++++++------------ .github/workflows/daily-build.yml | 18 +++--- .github/workflows/publish-release.yml | 12 ++-- 5 files changed, 126 insertions(+), 102 deletions(-) diff --git a/.github/workflows/cmake-bintest.yml b/.github/workflows/cmake-bintest.yml index ea83352b..8d15f405 100644 --- a/.github/workflows/cmake-bintest.yml +++ b/.github/workflows/cmake-bintest.yml @@ -48,19 +48,21 @@ jobs: - name: Get hdf5 snapshot if: ${{ (inputs.use_environ == 'snapshots') }} - uses: dsaltares/fetch-gh-release-asset@master + uses: robinraju/release-downloader@v1 with: - repo: 'HDFGroup/hdf5' - version: 'tags/snapshot' - file: '${{ inputs.use_hdf }}-win-vs2022_cl.zip' + repository: 'HDFGroup/hdf5' + tag: 'snapshot' + fileName: '${{ inputs.use_hdf }}-win-vs2022_cl.zip' + token: ${{ github.token }} - name: Get hdf5 release if: ${{ (inputs.use_environ == 'release') }} - uses: dsaltares/fetch-gh-release-asset@master + uses: robinraju/release-downloader@v1 with: - repo: 'HDFGroup/hdf5' - version: 'tags/${{ inputs.use_hdf }}' - file: '${{ inputs.use_hdf }}-win-vs2022_cl.zip' + repository: 'HDFGroup/hdf5' + tag: '${{ inputs.use_hdf }}' + fileName: '${{ inputs.use_hdf }}-win-vs2022_cl.zip' + token: ${{ github.token }} - name: Uncompress gh binary (Win) run: 7z x ${{ github.workspace }}/${{ inputs.use_hdf }}-win-vs2022_cl.zip @@ -159,19 +161,21 @@ jobs: - name: Get hdf5 snapshot if: ${{ (inputs.use_environ == 'snapshots') }} - uses: dsaltares/fetch-gh-release-asset@master + uses: robinraju/release-downloader@v1 with: - repo: 'HDFGroup/hdf5' - version: 'tags/snapshot' - file: '${{ inputs.use_hdf }}-ubuntu-2404_gcc.tar.gz' + repository: 'HDFGroup/hdf5' + tag: 'snapshot' + fileName: '${{ inputs.use_hdf }}-ubuntu-2404_gcc.tar.gz' + token: ${{ github.token }} - name: Get hdf5 release if: ${{ (inputs.use_environ == 'release') }} - uses: dsaltares/fetch-gh-release-asset@master + uses: robinraju/release-downloader@v1 with: - repo: 'HDFGroup/hdf5' - version: 'tags/${{ inputs.use_hdf }}' - file: '${{ inputs.use_hdf }}-ubuntu-2404_gcc.tar.gz' + repository: 'HDFGroup/hdf5' + tag: '${{ inputs.use_hdf }}' + fileName: '${{ inputs.use_hdf }}-ubuntu-2404_gcc.tar.gz' + token: ${{ github.token }} - name: Uncompress gh binary (Linux) run: tar -zxvf ${{ github.workspace }}/${{ inputs.use_hdf }}-ubuntu-2404_gcc.tar.gz @@ -260,19 +264,21 @@ jobs: - name: Get hdf5 snapshot if: ${{ (inputs.use_environ == 'snapshots') }} - uses: dsaltares/fetch-gh-release-asset@master + uses: robinraju/release-downloader@v1 with: - repo: 'HDFGroup/hdf5' - version: 'tags/snapshot' - file: '${{ inputs.use_hdf }}-macos14_clang.tar.gz' + repository: 'HDFGroup/hdf5' + tag: 'snapshot' + fileName: '${{ inputs.use_hdf }}-macos14_clang.tar.gz' + token: ${{ github.token }} - name: Get hdf5 release if: ${{ (inputs.use_environ == 'release') }} - uses: dsaltares/fetch-gh-release-asset@master + uses: robinraju/release-downloader@v1 with: - repo: 'HDFGroup/hdf5' - version: 'tags/${{ inputs.use_hdf }}' - file: '${{ inputs.use_hdf }}-macos14_clang.tar.gz' + repository: 'HDFGroup/hdf5' + tag: '${{ inputs.use_hdf }}' + fileName: '${{ inputs.use_hdf }}-macos14_clang.tar.gz' + token: ${{ github.token }} - name: Uncompress gh binary (MacOS_latest) run: tar -zxvf ${{ github.workspace }}/${{ inputs.use_hdf }}-macos14_clang*.tar.gz diff --git a/.github/workflows/cmake-ctest.yml b/.github/workflows/cmake-ctest.yml index 999f7ab2..de21cb54 100644 --- a/.github/workflows/cmake-ctest.yml +++ b/.github/workflows/cmake-ctest.yml @@ -120,19 +120,21 @@ jobs: - name: Get hdf5 snapshot if: ${{ (inputs.use_environ == 'snapshots') }} - uses: dsaltares/fetch-gh-release-asset@master + uses: robinraju/release-downloader@v1 with: - repo: 'HDFGroup/hdf5' - version: 'tags/snapshot' - file: '${{ inputs.use_hdf }}-win-vs2022_cl.zip' + repository: 'HDFGroup/hdf5' + tag: 'snapshot' + fileName: '${{ inputs.use_hdf }}-win-vs2022_cl.zip' + token: ${{ github.token }} - name: Get hdf5 release if: ${{ (inputs.use_environ == 'release') }} - uses: dsaltares/fetch-gh-release-asset@master + uses: robinraju/release-downloader@v1 with: - repo: 'HDFGroup/hdf5' - version: 'tags/${{ inputs.use_hdf }}' - file: '${{ inputs.use_hdf }}-win-vs2022_cl.zip' + repository: 'HDFGroup/hdf5' + tag: '${{ inputs.use_hdf }}' + fileName: '${{ inputs.use_hdf }}-win-vs2022_cl.zip' + token: ${{ github.token }} - name: Uncompress gh binary (Win) run: 7z x ${{ github.workspace }}/${{ inputs.use_hdf }}-win-vs2022_cl.zip @@ -311,19 +313,21 @@ jobs: - name: Get hdf5 snapshot if: ${{ (inputs.use_environ == 'snapshots') }} - uses: dsaltares/fetch-gh-release-asset@master + uses: robinraju/release-downloader@v1 with: - repo: 'HDFGroup/hdf5' - version: 'tags/snapshot' - file: '${{ inputs.use_hdf }}-ubuntu-2404_gcc.tar.gz' + repository: 'HDFGroup/hdf5' + tag: 'snapshot' + fileName: '${{ inputs.use_hdf }}-ubuntu-2404_gcc.tar.gz' + token: ${{ github.token }} - name: Get hdf5 release if: ${{ (inputs.use_environ == 'release') }} - uses: dsaltares/fetch-gh-release-asset@master + uses: robinraju/release-downloader@v1 with: - repo: 'HDFGroup/hdf5' - version: 'tags/${{ inputs.use_hdf }}' - file: '${{ inputs.use_hdf }}-ubuntu-2404_gcc.tar.gz' + repository: 'HDFGroup/hdf5' + tag: '${{ inputs.use_hdf }}' + fileName: '${{ inputs.use_hdf }}-ubuntu-2404_gcc.tar.gz' + token: ${{ github.token }} - name: List files for the space (Linux) run: | @@ -490,19 +494,21 @@ jobs: - name: Get hdf5 snapshot if: ${{ (inputs.use_environ == 'snapshots') }} - uses: dsaltares/fetch-gh-release-asset@master + uses: robinraju/release-downloader@v1 with: - repo: 'HDFGroup/hdf5' - version: 'tags/snapshot' - file: '${{ inputs.use_hdf }}-macos14_clang.tar.gz' + repository: 'HDFGroup/hdf5' + tag: 'snapshot' + fileName: '${{ inputs.use_hdf }}-macos14_clang.tar.gz' + token: ${{ github.token }} - name: Get hdf5 release if: ${{ (inputs.use_environ == 'release') }} - uses: dsaltares/fetch-gh-release-asset@master + uses: robinraju/release-downloader@v1 with: - repo: 'HDFGroup/hdf5' - version: 'tags/${{ inputs.use_hdf }}' - file: '${{ inputs.use_hdf }}-macos14_clang.tar.gz' + repository: 'HDFGroup/hdf5' + tag: '${{ inputs.use_hdf }}' + fileName: '${{ inputs.use_hdf }}-macos14_clang.tar.gz' + token: ${{ github.token }} - name: List files for the space (MacOS_latest) run: | diff --git a/.github/workflows/cmake-script.yml b/.github/workflows/cmake-script.yml index 5518903c..f7c5f309 100644 --- a/.github/workflows/cmake-script.yml +++ b/.github/workflows/cmake-script.yml @@ -74,19 +74,21 @@ jobs: - name: Get hdf5 snapshot if: ${{ (inputs.use_environ == 'snapshots') }} - uses: dsaltares/fetch-gh-release-asset@master + uses: robinraju/release-downloader@v1 with: - repo: 'HDFGroup/hdf5' - version: 'tags/snapshot' - file: '${{ inputs.use_hdf }}-win-vs2022_cl.zip' + repository: 'HDFGroup/hdf5' + tag: 'snapshot' + fileName: '${{ inputs.use_hdf }}-win-vs2022_cl.zip' + token: ${{ github.token }} - name: Get hdf5 release if: ${{ (inputs.use_environ == 'release') }} - uses: dsaltares/fetch-gh-release-asset@master + uses: robinraju/release-downloader@v1 with: - repo: 'HDFGroup/hdf5' - version: 'tags/${{ inputs.use_hdf }}' - file: '${{ inputs.use_hdf }}-win-vs2022_cl.zip' + repository: 'HDFGroup/hdf5' + tag: '${{ inputs.use_hdf }}' + fileName: '${{ inputs.use_hdf }}-win-vs2022_cl.zip' + token: ${{ github.token }} - name: Uncompress gh binary (Win) run: 7z x ${{ github.workspace }}/${{ inputs.use_hdf }}-win-vs2022_cl.zip @@ -219,19 +221,21 @@ jobs: - name: Get hdf5 release if: ${{ (inputs.use_environ == 'snapshots') }} - uses: dsaltares/fetch-gh-release-asset@master + uses: robinraju/release-downloader@v1 with: - repo: 'HDFGroup/hdf5' - version: 'tags/snapshot' - file: '${{ inputs.use_hdf }}-ubuntu-2404_gcc.tar.gz' + repository: 'HDFGroup/hdf5' + tag: 'snapshot' + fileName: '${{ inputs.use_hdf }}-ubuntu-2404_gcc.tar.gz' + token: ${{ github.token }} - name: Get hdf5 release if: ${{ (inputs.use_environ == 'release') }} - uses: dsaltares/fetch-gh-release-asset@master + uses: robinraju/release-downloader@v1 with: - repo: 'HDFGroup/hdf5' - version: 'tags/${{ inputs.use_hdf }}' - file: '${{ inputs.use_hdf }}-ubuntu-2404_gcc.tar.gz' + repository: 'HDFGroup/hdf5' + tag: '${{ inputs.use_hdf }}' + fileName: '${{ inputs.use_hdf }}-ubuntu-2404_gcc.tar.gz' + token: ${{ github.token }} - name: List files for the space (Linux) run: | @@ -356,19 +360,21 @@ jobs: - name: Get hdf5 snapshot if: ${{ (inputs.use_environ == 'snapshots') }} - uses: dsaltares/fetch-gh-release-asset@master + uses: robinraju/release-downloader@v1 with: - repo: 'HDFGroup/hdf5' - version: 'tags/snapshot' - file: '${{ inputs.use_hdf }}-macos14_clang.tar.gz' + repository: 'HDFGroup/hdf5' + tag: 'snapshot' + fileName: '${{ inputs.use_hdf }}-macos14_clang.tar.gz' + token: ${{ github.token }} - name: Get hdf5 release if: ${{ (inputs.use_environ == 'release') }} - uses: dsaltares/fetch-gh-release-asset@master + uses: robinraju/release-downloader@v1 with: - repo: 'HDFGroup/hdf5' - version: 'tags/${{ inputs.use_hdf }}' - file: '${{ inputs.use_hdf }}-macos14_clang.tar.gz' + repository: 'HDFGroup/hdf5' + tag: '${{ inputs.use_hdf }}' + fileName: '${{ inputs.use_hdf }}-macos14_clang.tar.gz' + token: ${{ github.token }} - name: List files for the space (MacOS_latest) run: | @@ -491,19 +497,21 @@ jobs: - name: Get hdf5 snapshot(Windows_intel) if: ${{ (inputs.use_environ == 'snapshots') }} - uses: dsaltares/fetch-gh-release-asset@master + uses: robinraju/release-downloader@v1 with: - repo: 'HDFGroup/hdf5' - version: 'tags/snapshot' - file: '${{ inputs.use_hdf }}-win-vs2022_intel.zip' + repository: 'HDFGroup/hdf5' + tag: 'snapshot' + fileName: '${{ inputs.use_hdf }}-win-vs2022_intel.zip' + token: ${{ github.token }} - name: Get hdf5 release(Windows_intel) if: ${{ (inputs.use_environ == 'release') }} - uses: dsaltares/fetch-gh-release-asset@master + uses: robinraju/release-downloader@v1 with: - repo: 'HDFGroup/hdf5' - version: 'tags/${{ inputs.use_hdf }}' - file: '${{ inputs.use_hdf }}-win-vs2022_intel.zip' + repository: 'HDFGroup/hdf5' + tag: '${{ inputs.use_hdf }}' + fileName: '${{ inputs.use_hdf }}-win-vs2022_intel.zip' + token: ${{ github.token }} - name: Uncompress gh binary (Windows_intel) run: 7z x ${{ github.workspace }}/${{ inputs.use_hdf }}-win-vs2022_intel.zip @@ -647,19 +655,21 @@ jobs: - name: Get hdf5 release (Linux_intel) if: ${{ (inputs.use_environ == 'snapshots') }} - uses: dsaltares/fetch-gh-release-asset@master + uses: robinraju/release-downloader@v1 with: - repo: 'HDFGroup/hdf5' - version: 'tags/snapshot' - file: '${{ inputs.use_hdf }}-ubuntu-2404_intel.tar.gz' + repository: 'HDFGroup/hdf5' + tag: 'snapshot' + fileName: '${{ inputs.use_hdf }}-ubuntu-2404_intel.tar.gz' + token: ${{ github.token }} - name: Get hdf5 release (Linux_intel) if: ${{ (inputs.use_environ == 'release') }} - uses: dsaltares/fetch-gh-release-asset@master + uses: robinraju/release-downloader@v1 with: - repo: 'HDFGroup/hdf5' - version: 'tags/${{ inputs.use_hdf }}' - file: '${{ inputs.use_hdf }}-ubuntu-2404_intel.tar.gz' + repository: 'HDFGroup/hdf5' + tag: '${{ inputs.use_hdf }}' + fileName: '${{ inputs.use_hdf }}-ubuntu-2404_intel.tar.gz' + token: ${{ github.token }} - name: List files for the space (Linux_intel) run: | diff --git a/.github/workflows/daily-build.yml b/.github/workflows/daily-build.yml index 77e8e579..bd0fbdb4 100644 --- a/.github/workflows/daily-build.yml +++ b/.github/workflows/daily-build.yml @@ -30,11 +30,12 @@ jobs: - uses: actions/checkout@v6.0.2 - name: Get hdf5 release base name - uses: dsaltares/fetch-gh-release-asset@master + uses: robinraju/release-downloader@v1 with: - repo: 'HDFGroup/hdf5' - version: 'tags/snapshot' - file: 'last-file.txt' + repository: 'HDFGroup/hdf5' + tag: 'snapshot' + fileName: 'last-file.txt' + token: ${{ github.token }} - name: Read HDF5 base-name file id: gethdf5base @@ -43,11 +44,12 @@ jobs: - run: echo "hdf5 base name is ${{ steps.gethdf5base.outputs.HDF5_NAME_BASE }}." - name: Get plugin release base name - uses: dsaltares/fetch-gh-release-asset@master + uses: robinraju/release-downloader@v1 with: - repo: 'HDFGroup/hdf5_plugins' - version: 'tags/snapshot' - file: 'last-file.txt' + repository: 'HDFGroup/hdf5_plugins' + tag: 'snapshot' + fileName: 'last-file.txt' + token: ${{ github.token }} - name: Read base-name file id: getpluginbase diff --git a/.github/workflows/publish-release.yml b/.github/workflows/publish-release.yml index 4bd2ce66..4b17729e 100644 --- a/.github/workflows/publish-release.yml +++ b/.github/workflows/publish-release.yml @@ -31,13 +31,13 @@ jobs: ref: '${{ github.head_ref || github.ref_name }}' - name: Get plugins release - uses: dsaltares/fetch-gh-release-asset@master + uses: robinraju/release-downloader@v1 with: - repo: 'HDFGroup/hdf5_plugins' - version: 'tags/${{ inputs.use_tag }}' - regex: true - target: 'PLUGINS/' - file: '${{ inputs.use_hdf }}-*.*' + repository: 'HDFGroup/hdf5_plugins' + tag: '${{ inputs.use_tag }}' + fileName: '${{ inputs.use_hdf }}-*.*' + out-file-path: 'PLUGINS' + token: ${{ github.token }} - name: Setup AWS CLI uses: aws-actions/configure-aws-credentials@v6 From 7ee4fc7ec666f8185173d11bb2b8f328b3eee492 Mon Sep 17 00:00:00 2001 From: Larry Knox Date: Mon, 1 Jun 2026 17:01:11 -0500 Subject: [PATCH 2/7] Fix HDF5 release tag/filename mismatch after hdf5- prefix removal HDF5 release tags changed from hdf5-x.y.z to x.y.z, but release filenames still use the hdf5- prefix (e.g. hdf5-2.1.1-win-vs2022_cl.zip). - release.yml: prefix use_hdf with hdf5- so filenames resolve correctly; pass new hdf_tag for the bare version number used in git tag lookup - cmake-ctest.yml, cmake-bintest.yml: add hdf_tag input and use it for the release asset tag: field, keeping use_hdf for filename construction Co-Authored-By: Claude Sonnet 4.6 --- .github/workflows/cmake-bintest.yml | 11 ++++++++--- .github/workflows/cmake-ctest.yml | 11 ++++++++--- .github/workflows/release.yml | 6 ++++-- 3 files changed, 20 insertions(+), 8 deletions(-) diff --git a/.github/workflows/cmake-bintest.yml b/.github/workflows/cmake-bintest.yml index 8d15f405..f1779606 100644 --- a/.github/workflows/cmake-bintest.yml +++ b/.github/workflows/cmake-bintest.yml @@ -8,6 +8,11 @@ on: description: "The hdf5 base name of the binaries" required: true type: string + hdf_tag: + description: "The hdf5 release tag for asset download (version only, without hdf5- prefix)" + required: false + type: string + default: '' file_base: description: "The common base name of the source tarballs" required: true @@ -60,7 +65,7 @@ jobs: uses: robinraju/release-downloader@v1 with: repository: 'HDFGroup/hdf5' - tag: '${{ inputs.use_hdf }}' + tag: '${{ inputs.hdf_tag }}' fileName: '${{ inputs.use_hdf }}-win-vs2022_cl.zip' token: ${{ github.token }} @@ -173,7 +178,7 @@ jobs: uses: robinraju/release-downloader@v1 with: repository: 'HDFGroup/hdf5' - tag: '${{ inputs.use_hdf }}' + tag: '${{ inputs.hdf_tag }}' fileName: '${{ inputs.use_hdf }}-ubuntu-2404_gcc.tar.gz' token: ${{ github.token }} @@ -276,7 +281,7 @@ jobs: uses: robinraju/release-downloader@v1 with: repository: 'HDFGroup/hdf5' - tag: '${{ inputs.use_hdf }}' + tag: '${{ inputs.hdf_tag }}' fileName: '${{ inputs.use_hdf }}-macos14_clang.tar.gz' token: ${{ github.token }} diff --git a/.github/workflows/cmake-ctest.yml b/.github/workflows/cmake-ctest.yml index de21cb54..1a815aa1 100644 --- a/.github/workflows/cmake-ctest.yml +++ b/.github/workflows/cmake-ctest.yml @@ -8,6 +8,11 @@ on: description: "The hdf5 base name of the binaries" required: true type: string + hdf_tag: + description: "The hdf5 release tag for asset download (version only, without hdf5- prefix)" + required: false + type: string + default: '' snap_name: description: 'The name in the source tarballs' type: string @@ -132,7 +137,7 @@ jobs: uses: robinraju/release-downloader@v1 with: repository: 'HDFGroup/hdf5' - tag: '${{ inputs.use_hdf }}' + tag: '${{ inputs.hdf_tag }}' fileName: '${{ inputs.use_hdf }}-win-vs2022_cl.zip' token: ${{ github.token }} @@ -325,7 +330,7 @@ jobs: uses: robinraju/release-downloader@v1 with: repository: 'HDFGroup/hdf5' - tag: '${{ inputs.use_hdf }}' + tag: '${{ inputs.hdf_tag }}' fileName: '${{ inputs.use_hdf }}-ubuntu-2404_gcc.tar.gz' token: ${{ github.token }} @@ -506,7 +511,7 @@ jobs: uses: robinraju/release-downloader@v1 with: repository: 'HDFGroup/hdf5' - tag: '${{ inputs.use_hdf }}' + tag: '${{ inputs.hdf_tag }}' fileName: '${{ inputs.use_hdf }}-macos14_clang.tar.gz' token: ${{ github.token }} diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index b59711d5..82be727c 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -48,7 +48,8 @@ jobs: cmake_version: "latest" preset_name: ci-StdShar file_base: ${{ needs.call-workflow-tarball.outputs.file_base }} - use_hdf: ${{ needs.log-the-inputs.outputs.hdf_tag }} + use_hdf: hdf5-${{ needs.log-the-inputs.outputs.hdf_tag }} + hdf_tag: ${{ needs.log-the-inputs.outputs.hdf_tag }} snap_name: hdf5_plugins-${{ needs.call-workflow-tarball.outputs.source_base }} use_environ: release secrets: @@ -68,7 +69,8 @@ jobs: uses: ./.github/workflows/cmake-bintest.yml with: preset_name: ci-StdShar - use_hdf: ${{ needs.log-the-inputs.outputs.hdf_tag }} + use_hdf: hdf5-${{ needs.log-the-inputs.outputs.hdf_tag }} + hdf_tag: ${{ needs.log-the-inputs.outputs.hdf_tag }} file_base: ${{ needs.call-workflow-tarball.outputs.file_base }} use_environ: release From a4ac941b175a08618b2b0d159530315f9f7f4c10 Mon Sep 17 00:00:00 2001 From: Larry Knox Date: Tue, 9 Jun 2026 13:40:12 -0500 Subject: [PATCH 3/7] Update cmake-script.yml to match changes in cmake-bintest.yml and cmake-ctest.yml. --- .github/workflows/cmake-script.yml | 15 ++++++++++----- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/.github/workflows/cmake-script.yml b/.github/workflows/cmake-script.yml index f7c5f309..4959a43a 100644 --- a/.github/workflows/cmake-script.yml +++ b/.github/workflows/cmake-script.yml @@ -8,6 +8,11 @@ on: description: "The hdf5 base name of the binaries" required: true type: string + hdf_tag: + description: "The hdf5 release tag for asset download (version only, without hdf5- prefix)" + required: false + type: string + default: '' snap_name: description: 'The name in the source tarballs' type: string @@ -86,7 +91,7 @@ jobs: uses: robinraju/release-downloader@v1 with: repository: 'HDFGroup/hdf5' - tag: '${{ inputs.use_hdf }}' + tag: '${{ inputs.hdf_tag }}' fileName: '${{ inputs.use_hdf }}-win-vs2022_cl.zip' token: ${{ github.token }} @@ -233,7 +238,7 @@ jobs: uses: robinraju/release-downloader@v1 with: repository: 'HDFGroup/hdf5' - tag: '${{ inputs.use_hdf }}' + tag: '${{ inputs.hdf_tag }}' fileName: '${{ inputs.use_hdf }}-ubuntu-2404_gcc.tar.gz' token: ${{ github.token }} @@ -372,7 +377,7 @@ jobs: uses: robinraju/release-downloader@v1 with: repository: 'HDFGroup/hdf5' - tag: '${{ inputs.use_hdf }}' + tag: '${{ inputs.hdf_tag }}' fileName: '${{ inputs.use_hdf }}-macos14_clang.tar.gz' token: ${{ github.token }} @@ -510,7 +515,7 @@ jobs: with: repository: 'HDFGroup/hdf5' tag: '${{ inputs.use_hdf }}' - fileName: '${{ inputs.use_hdf }}-win-vs2022_intel.zip' + fileName: '${{ inputs.hdf_tag }}-win-vs2022_intel.zip' token: ${{ github.token }} - name: Uncompress gh binary (Windows_intel) @@ -667,7 +672,7 @@ jobs: uses: robinraju/release-downloader@v1 with: repository: 'HDFGroup/hdf5' - tag: '${{ inputs.use_hdf }}' + tag: '${{ inputs.hdf_tag }}' fileName: '${{ inputs.use_hdf }}-ubuntu-2404_intel.tar.gz' token: ${{ github.token }} From 4ede4a00509a2653aa601980fe732733febaa79f Mon Sep 17 00:00:00 2001 From: Larry Knox Date: Tue, 9 Jun 2026 14:16:40 -0500 Subject: [PATCH 4/7] Replace undeclared identifier BLOSC2_MAX_DIM with B2ND_MAX_DIM. --- BLOSC2/src/H5Zblosc2.c | 21 ++++++++++----------- 1 file changed, 10 insertions(+), 11 deletions(-) diff --git a/BLOSC2/src/H5Zblosc2.c b/BLOSC2/src/H5Zblosc2.c index 243af9b9..1b9019ba 100644 --- a/BLOSC2/src/H5Zblosc2.c +++ b/BLOSC2/src/H5Zblosc2.c @@ -99,14 +99,14 @@ * - 4: compression level * - 5: shuffle method * - 6: compressor code - * - 7: chunk rank (number of dimensions) (present if 1 < rank <= BLOSC2_MAX_DIM, for B2ND) + * - 7: chunk rank (number of dimensions) (present if 1 < rank <= B2ND_MAX_DIM, for B2ND) * - 8 + i: length of chunk dimension i (0 <= i < rank) * * If a value is specified, all values before it must be specified too. * * If the chunk rank is specified, chunk dimensions must follow. */ -#define MAX_FILTER_VALUES (8 + BLOSC2_MAX_DIM) +#define MAX_FILTER_VALUES (8 + B2ND_MAX_DIM) /* Compression level default */ #define DEFAULT_CLEVEL 5 /* Shuffle default */ @@ -168,7 +168,7 @@ H5PLget_plugin_info(void) * * 3. Compute the chunk size in bytes and store it in slot 3. * - * 4. If 1 < rank <= BLOSC2_MAX_DIM, store it in slot 7, and chunk dimensions in the following slots. + * 4. If 1 < rank <= B2ND_MAX_DIM, store it in slot 7, and chunk dimensions in the following slots. */ herr_t blosc2_set_local(hid_t dcpl, hid_t type, hid_t space) @@ -244,7 +244,7 @@ blosc2_set_local(hid_t dcpl, hid_t type, hid_t space) fprintf(stderr, "Blosc2: Computed buffer size %d\n", bufsize); #endif - if (1 < ndim && ndim <= BLOSC2_MAX_DIM) { + if (1 < ndim && ndim <= B2ND_MAX_DIM) { if (nelements < 5) { values[4] = DEFAULT_CLEVEL; } @@ -267,7 +267,7 @@ blosc2_set_local(hid_t dcpl, hid_t type, hid_t space) * so convey some information when tracing. */ BLOSC_TRACE_WARNING("Chunk rank %d exceeds B2ND build limit %d, " "using plain Blosc2 instead", - ndim, BLOSC2_MAX_DIM); + ndim, B2ND_MAX_DIM); } r = H5Pmodify_filter(dcpl, FILTER_BLOSC2, flags, nelements, values); @@ -410,7 +410,7 @@ blosc2_filter_function(unsigned int flags, size_t cd_nelmts, const unsigned int /* Filter params that are only set for B2ND */ int ndim = -1; - int32_t chunkshape[BLOSC2_MAX_DIM]; + int32_t chunkshape[B2ND_MAX_DIM]; if (cd_nelmts >= 8) { /* Get chunk shape for B2ND */ ndim = cd_values[7]; @@ -419,8 +419,8 @@ blosc2_filter_function(unsigned int flags, size_t cd_nelmts, const unsigned int PUSH_ERR("blosc2_filter", H5E_CALLBACK, errmsg); goto failed; } - if (ndim > BLOSC2_MAX_DIM) { - sprintf(errmsg, "Chunk rank %d (filter value) exceeds B2ND build limit %d", ndim, BLOSC2_MAX_DIM); + if (ndim > B2ND_MAX_DIM) { + sprintf(errmsg, "Chunk rank %d (filter value) exceeds B2ND build limit %d", ndim, B2ND_MAX_DIM); PUSH_ERR("blosc2_filter", H5E_CALLBACK, errmsg); goto failed; } @@ -489,10 +489,10 @@ blosc2_filter_function(unsigned int flags, size_t cd_nelmts, const unsigned int } blocksize = sugg_blocksize; } - int32_t blockdims[BLOSC2_MAX_DIM]; + int32_t blockdims[B2ND_MAX_DIM]; cparams.blocksize = compute_b2nd_block_shape(blocksize, typesize, ndim, chunkshape, blockdims); - int64_t chunkshape_l[BLOSC2_MAX_DIM]; + int64_t chunkshape_l[B2ND_MAX_DIM]; for (int i = 0; i < ndim; i++) { chunkshape_l[i] = chunkshape[i]; } @@ -596,7 +596,6 @@ blosc2_filter_function(unsigned int flags, size_t cd_nelmts, const unsigned int PUSH_ERR("blosc2_filter", H5E_CALLBACK, errmsg); goto b2nd_decomp_out; } - int64_t start[BLOSC2_MAX_DIM], stop[BLOSC2_MAX_DIM], size = typesize; for (int i = 0; i < array->ndim; i++) { start[i] = 0; stop[i] = array->shape[i]; From e4c289ca41f7f617505312aab0e8b50d195f3f5c Mon Sep 17 00:00:00 2001 From: Larry Knox Date: Tue, 9 Jun 2026 14:49:56 -0500 Subject: [PATCH 5/7] Add missing variable declarations. --- BLOSC2/src/H5Zblosc2.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/BLOSC2/src/H5Zblosc2.c b/BLOSC2/src/H5Zblosc2.c index 1b9019ba..dad3c951 100644 --- a/BLOSC2/src/H5Zblosc2.c +++ b/BLOSC2/src/H5Zblosc2.c @@ -398,7 +398,7 @@ blosc2_filter_function(unsigned int flags, size_t cd_nelmts, const unsigned int char errmsg[256]; if (cd_nelmts < 4) { - sprintf(errmsg, "Too few filter parameters for B2ND: %d", cd_nelmts); + sprintf(errmsg, "Too few filter parameters for B2ND: %lu", cd_nelmts); PUSH_ERR("blosc2_filter", H5E_CALLBACK, errmsg); goto failed; } @@ -597,9 +597,9 @@ blosc2_filter_function(unsigned int flags, size_t cd_nelmts, const unsigned int goto b2nd_decomp_out; } for (int i = 0; i < array->ndim; i++) { - start[i] = 0; - stop[i] = array->shape[i]; - size *= array->shape[i]; + size_t start[i] = 0; + size_t stop[i] = array->shape[i]; + size_t size *= array->shape[i]; if (ndim >= 0 && array->shape[i] != chunkshape[i]) { /* The HDF5 filter pipeline needs the filter to always return full chunks, * even for margin chunks where data does not fill the whole chunk From e250d560c1381c1cc29c5526b8ed9169e6d44e02 Mon Sep 17 00:00:00 2001 From: Larry Knox Date: Tue, 9 Jun 2026 15:14:43 -0500 Subject: [PATCH 6/7] Restore deleted line. --- BLOSC2/src/H5Zblosc2.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/BLOSC2/src/H5Zblosc2.c b/BLOSC2/src/H5Zblosc2.c index dad3c951..f87818a0 100644 --- a/BLOSC2/src/H5Zblosc2.c +++ b/BLOSC2/src/H5Zblosc2.c @@ -596,10 +596,11 @@ blosc2_filter_function(unsigned int flags, size_t cd_nelmts, const unsigned int PUSH_ERR("blosc2_filter", H5E_CALLBACK, errmsg); goto b2nd_decomp_out; } + int64_t start[B2ND_MAX_DIM], stop[B2ND_MAX_DIM], size = typesize; for (int i = 0; i < array->ndim; i++) { - size_t start[i] = 0; - size_t stop[i] = array->shape[i]; - size_t size *= array->shape[i]; + start[i] = 0; + stop[i] = array->shape[i]; + size *= array->shape[i]; if (ndim >= 0 && array->shape[i] != chunkshape[i]) { /* The HDF5 filter pipeline needs the filter to always return full chunks, * even for margin chunks where data does not fill the whole chunk From 0adec2600082a795d261f17fb22f0304730b71ff Mon Sep 17 00:00:00 2001 From: Larry Knox Date: Wed, 10 Jun 2026 11:34:07 -0500 Subject: [PATCH 7/7] ddress findings in brtnfld 6/9/2026 comment. --- .github/workflows/cmake-script.yml | 4 ++-- .github/workflows/publish-release.yml | 2 +- BLOSC2/src/H5Zblosc2.c | 6 +++--- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/.github/workflows/cmake-script.yml b/.github/workflows/cmake-script.yml index 4959a43a..9ee5c6fc 100644 --- a/.github/workflows/cmake-script.yml +++ b/.github/workflows/cmake-script.yml @@ -514,8 +514,8 @@ jobs: uses: robinraju/release-downloader@v1 with: repository: 'HDFGroup/hdf5' - tag: '${{ inputs.use_hdf }}' - fileName: '${{ inputs.hdf_tag }}-win-vs2022_intel.zip' + tag: '${{ inputs.hdf_tag }}' + fileName: '${{ inputs.use_hdf }}-win-vs2022_intel.zip' token: ${{ github.token }} - name: Uncompress gh binary (Windows_intel) diff --git a/.github/workflows/publish-release.yml b/.github/workflows/publish-release.yml index 4b17729e..47547873 100644 --- a/.github/workflows/publish-release.yml +++ b/.github/workflows/publish-release.yml @@ -35,7 +35,7 @@ jobs: with: repository: 'HDFGroup/hdf5_plugins' tag: '${{ inputs.use_tag }}' - fileName: '${{ inputs.use_hdf }}-*.*' + fileName: '${{ inputs.use_tag }}-*.*' out-file-path: 'PLUGINS' token: ${{ github.token }} diff --git a/BLOSC2/src/H5Zblosc2.c b/BLOSC2/src/H5Zblosc2.c index f87818a0..c8e66a43 100644 --- a/BLOSC2/src/H5Zblosc2.c +++ b/BLOSC2/src/H5Zblosc2.c @@ -398,7 +398,7 @@ blosc2_filter_function(unsigned int flags, size_t cd_nelmts, const unsigned int char errmsg[256]; if (cd_nelmts < 4) { - sprintf(errmsg, "Too few filter parameters for B2ND: %lu", cd_nelmts); + sprintf(errmsg, "Too few filter parameters for B2ND: %zu", cd_nelmts); PUSH_ERR("blosc2_filter", H5E_CALLBACK, errmsg); goto failed; } @@ -425,7 +425,7 @@ blosc2_filter_function(unsigned int flags, size_t cd_nelmts, const unsigned int goto failed; } if (cd_nelmts < (size_t)(8 + ndim)) { - sprintf(errmsg, "Too few dimensions for B2ND in filter values (%z/%d)", cd_nelmts - 8, ndim); + sprintf(errmsg, "Too few dimensions for B2ND in filter values (%zu/%d)", cd_nelmts - 8, ndim); PUSH_ERR("blosc2_filter", H5E_CALLBACK, errmsg); goto failed; } @@ -440,7 +440,7 @@ blosc2_filter_function(unsigned int flags, size_t cd_nelmts, const unsigned int /* We're compressing */ if (cd_nelmts < 6) { - sprintf(errmsg, "Too few filter parameters for Blosc2 compression: %d", cd_nelmts); + sprintf(errmsg, "Too few filter parameters for Blosc2 compression: %zu", cd_nelmts); PUSH_ERR("blosc2_filter", H5E_CALLBACK, errmsg); goto failed; }