From 5361e2916a9db27bb69f7fbe6f50bd93b0a6d895 Mon Sep 17 00:00:00 2001 From: GhosTnever <286396892+GhosTnever-lkm@users.noreply.github.com> Date: Mon, 12 Oct 2026 09:11:13 +0400 Subject: [PATCH] fix: report the package version --- CHANGELOG.md | 5 +++++ package.json | 2 +- src/scan.mjs | 5 +++-- test/scan.test.mjs | 1 + 4 files changed, 10 insertions(+), 3 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 5dd36dd..f91efba 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,5 +1,10 @@ # Changelog +## v1.0.4 + +- Keep the report's tool version synchronized with `package.json` rather than a stale hard-coded value. +- Add a regression assertion that verifies the generated report version matches package metadata. + ## v1.0.3 - Fix Markdown spacing so the license headings render correctly after the wallet details blocks in both README languages. diff --git a/package.json b/package.json index 8eccbf9..eb42716 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "diffshield-action", - "version": "1.0.3", + "version": "1.0.4", "private": true, "description": "Read-only GitHub pull request risk review action", "type": "module", diff --git a/src/scan.mjs b/src/scan.mjs index 70213e4..44adeb8 100644 --- a/src/scan.mjs +++ b/src/scan.mjs @@ -1,11 +1,12 @@ import { execFileSync } from 'node:child_process'; -import { appendFileSync, writeFileSync } from 'node:fs'; +import { appendFileSync, readFileSync, writeFileSync } from 'node:fs'; const SEVERITY = { critical: 4, high: 3, medium: 2, low: 1, info: 0 }; const BASE = process.env.DIFFSHIELD_BASE_SHA ?? ''; const HEAD = process.env.DIFFSHIELD_HEAD_SHA ?? ''; const failOn = (process.env.DIFFSHIELD_FAIL_ON ?? 'high').toLowerCase(); const maxFindings = Number.parseInt(process.env.DIFFSHIELD_MAX_FINDINGS ?? '100', 10); +const packageVersion = JSON.parse(readFileSync(new URL('../package.json', import.meta.url), 'utf8')).version; const findings = []; function add(severity, category, path, line, message, recommendation) { @@ -151,7 +152,7 @@ function main() { const score = riskScore(findings); const counts = Object.fromEntries(Object.keys(SEVERITY).map(level => [level, findings.filter(item => item.severity === level).length])); - const report = { tool: 'DiffShield', version: '1.0.0', base: BASE, head: HEAD, riskScore: score, counts, findings }; + const report = { tool: 'DiffShield', version: packageVersion, base: BASE, head: HEAD, riskScore: score, counts, findings }; const summary = []; summary.push('## 🛡️ DiffShield analysis'); summary.push(''); diff --git a/test/scan.test.mjs b/test/scan.test.mjs index 52f1a20..82bb5ac 100644 --- a/test/scan.test.mjs +++ b/test/scan.test.mjs @@ -28,6 +28,7 @@ function fixture(files, options = {}) { test('clean changes produce a zero-risk report', t => { const f = fixture({ 'src/app.js': 'export const value = 42;\n' }); t.after(() => rmSync(f.dir, { recursive: true, force: true })); assert.equal(f.result.status, 0); assert.equal(f.report.riskScore, 0); assert.equal(f.report.findings.length, 0); + assert.equal(f.report.version, JSON.parse(readFileSync(path.join(repository, 'package.json'), 'utf8')).version); }); test('English and Russian README examples pin the same immutable Action release', () => {