From 20b3066075a423f51c0e5bc026a733ce70775027 Mon Sep 17 00:00:00 2001
From: GermanCoding <github@germancoding.com>
Date: Sun, 21 Jun 2026 12:17:28 +0200
Subject: [PATCH] feat(installer): Stop all SyncTrayzor processes during v1
 upgrades

Old SyncTrayzor versions (< 1.1.29) did not stop themselves upon
uninstall. This causes a number of problems for v2 (uninstaller cannot
clean all files from v1 dir, ghost processes, locked CEF cache).

To improve this, manually stop all SyncTrayzor processes during a v1
upgrade. This isn't bulletproof: If the user manually uninstalled v1
beforehand, we may still have the processes open, but uninstaller
information is already gone. Thus, this isn't a perfect solution but it
can help some users on a direct upgrade path.
---
 installer/common.iss | 30 ++++++++++++++++++++++++++----
 1 file changed, 26 insertions(+), 4 deletions(-)

diff --git a/installer/common.iss b/installer/common.iss
index f257d4eb..73601125 100644
--- a/installer/common.iss
+++ b/installer/common.iss
@@ -350,6 +350,26 @@ begin
   end;
 end;
 
+function StopRunningSyncTrayzorProcesses(): Boolean;
+var
+  ResultCode: Integer;
+begin
+  Result := True;
+
+  if not Exec(ExpandConstant('{sys}\taskkill.exe'), '/IM SyncTrayzor.exe /F /T', '', SW_HIDE, ewWaitUntilTerminated, ResultCode) then
+  begin
+    Log('Failed to launch taskkill for SyncTrayzor.exe processes; continuing setup');
+  end
+  else if ResultCode = 0 then
+  begin
+    Log('Requested termination of SyncTrayzor.exe processes');
+  end
+  else
+  begin
+    Log('taskkill exited with code ' + IntToStr(ResultCode) + '; continuing setup');
+  end;
+end;
+
 // -------------------------------------------------------------------
 // APPDATA BACKUP  ----------------------------------------------------
 // -------------------------------------------------------------------
@@ -399,6 +419,7 @@ end;
 function InitializeSetup(): Boolean;
 begin
   Result := True;
+
   if not EnsureNoLegacyX86() then
   begin
     Result := False;
@@ -441,17 +462,18 @@ begin
 
   if Assigned(InfoPage) and (CurPageID = InfoPage.ID) and OldVersionDetected then
   begin
-    // 1) Backup
+    // 1) Ensure SyncTrayzor is stopped (versions < 1.1.29 did not handle this gracefully)
+    StopRunningSyncTrayzorProcesses();
+    // 2) Backup
     if not PgCheckbox.Checked then
     begin
       BackupAppData();
       BackupAutostartRegistry();
     end;
-
-    // 2) Run uninstaller
+    // 3) Run uninstaller
     if (Exec('>', OldUninstString, '', SW_SHOWNORMAL, ewWaitUntilTerminated, ResultCode)) then
     begin
-      // 3) Restore
+      // 4) Restore
       if not PgCheckbox.Checked then
         RestoreAppData();
     end