Encore Support?

[WowItsOnlyConnor]

So Encore is a game similar to Festival, which it supports gamepad charts, which is in INI format as PAD [instrument], (Pad Drums, Pad Bass, Pad Guitar, Pad Vocals, and Pad Keys. Unlike festival, pad keys is a separate instrument chart),
It also supports regular plastic charts, called Classic [instrument] in-game. Encore can also load Festival JSON formatted songs but the thing doesn't parse Encore's version of the json format for metadata and also doesn't account for Keys, making using the Festival path generation less than ideal.

[GenericMadScientist]

First I've heard of this game. I see it's still new so I'm concerned about spending too much time on adding support at this stage in case there are radical changes (hence why I didn't add YARG initially, but at this point I should really go do that).

If I were to add support for Encore's file formats then would the Festival path generation be good enough, or are there subtle differences to take account of?

[WowItsOnlyConnor]

Sorry for the late response but Encore does have slightly different scoring to my understanding, but it's not too different from Festival; there isn't any whammy (yet anyway), hitting a good grants 25 points, perfect is 50, the main difference is how band score and sustains are done I think.

[solamint]

ok hi, encore lead dev here

it's not too different from festival, but also has a midi format that tries to comply with YARG and Clone Hero, where pad instruments are not prefixed PART, but PAD.

as far as i'm concerned, there arent radical changes to be made from festival scoring, except for a sustains scoring bug. (sustains not caring about completion, hitting sustains early gives more points, hitting sustains late gives less)

https://github.com/Encore-Developers/Encore/blob/indev/Encore/src/song/scoring.h
https://github.com/Encore-Developers/Encore/blob/indev/Encore/src/timingvalues.h

although there is a correction to be made: perfects are not 50, but 30. (1.2x multiplier), and the game is significantly tighter than festival
also im not sure how festival od drain works, if its like rock band then it should be the same lol

and you'd be right, i feel like i might have to tweak some of the values for leniencies, as i dont have many playtesters for the newer versions, it might be a good idea to wait until this version is finalized

[GenericMadScientist]

I'm going to prioritise YARG support over Encore, but I'll keep the issue open as I am interested in this.