make it so a collectibles spawn bucket is add if external config doesn't include.

Author: Waterpicker

common/src/main/java/generations/gg/generations/core/generationscore/common/mixin/BestSpawnConfigMixin.java

@@ -0,0 +1,20 @@
+package generations.gg.generations.core.generationscore.common.mixin;
+
+import com.cobblemon.mod.common.api.spawning.SpawnBucket;
+import com.cobblemon.mod.common.api.spawning.preset.BestSpawnerConfig;
+import org.spongepowered.asm.mixin.Mixin;
+import org.spongepowered.asm.mixin.injection.At;
+import org.spongepowered.asm.mixin.injection.Inject;
+import org.spongepowered.asm.mixin.injection.callback.CallbackInfoReturnable;
+
+@Mixin(BestSpawnerConfig.Companion.class)
+public class BestSpawnConfigMixin {
+    @Inject(method = "load", at = @At("RETURN"))
+    public void appendLoad(CallbackInfoReturnable<BestSpawnerConfig> cir) {
+        var buckets = cir.getReturnValue().getBuckets();
+
+        if(buckets.stream().noneMatch(a -> a.name.equals("collectibles"))) {
+            buckets.add(new SpawnBucket("collectibles", 0.2f));
+        }
+    }
+}

common/src/main/resources/GenerationsCore-common.mixins.json

@@ -7,6 +7,7 @@
     "AbilityChangerMixin",
     "AbstractCauldronBlockMixin",
     "AbstractFurnaceBlockEntityMixin",
+    "BestSpawnConfigMixin",
     "FishingHookMixin",
     "PokemonBattleMixin",
     "RecordItemMixin",

common/src/main/resources/data/generations_core/spawn_pool_world/zygrade_cell.json

@@ -3,27 +3,15 @@
   "neededInstalledMods": [],
   "neededUninstalledMods": [],
   "spawns": [
-    {
-      "id": "zygardecell-1",
-      "type": "zygarde",
-      "context": "grounded",
-      "bucket": "rare",
-      "weight": 3.5
-    },
     {
       "id": "zygardecell-2",
       "presets": [
         "natural"
       ],
       "type": "zygarde",
       "context": "grounded",
-      "bucket": "common",
-      "weight": 10.0,
-      "condition": {
-        "biomes": [
-          "#cobblemon:is_plains"
-        ]
-      }
+      "bucket": "collectibles",
+      "weight": 1.0
     }
   ]
 }