From 3373e076ac1428953bf86a8b55c454e9592dc8f7 Mon Sep 17 00:00:00 2001
From: capsule <valentin.rudloff.perso@gmail.com>
Date: Tue, 7 Dec 2021 18:33:11 +0000
Subject: [PATCH 1/5] add list devices on network

---
 .../administrative/wifi/list_devices_on_network.json        | 6 ++++++
 1 file changed, 6 insertions(+)
 create mode 100644 servers/script-server/conf/runners/administrative/wifi/list_devices_on_network.json

diff --git a/servers/script-server/conf/runners/administrative/wifi/list_devices_on_network.json b/servers/script-server/conf/runners/administrative/wifi/list_devices_on_network.json
new file mode 100644
index 0000000..aac37c1
--- /dev/null
+++ b/servers/script-server/conf/runners/administrative/wifi/list_devices_on_network.json
@@ -0,0 +1,6 @@
+{
+  "name": "List devices",
+  "script_path": "./scripts/network/list_devices.py",
+  "description": "List the devices connected to the network we also are connected (you choose the network interface)",
+  "group": "\ud83d\udcf6Wifi Management",
+}
\ No newline at end of file

From fb516c144b02cdc4f6147b23e8b60033d37d80bf Mon Sep 17 00:00:00 2001
From: capsule <valentin.rudloff.perso@gmail.com>
Date: Tue, 7 Dec 2021 18:33:46 +0000
Subject: [PATCH 2/5] fix json

---
 .../runners/administrative/wifi/list_devices_on_network.json    | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/servers/script-server/conf/runners/administrative/wifi/list_devices_on_network.json b/servers/script-server/conf/runners/administrative/wifi/list_devices_on_network.json
index aac37c1..3def359 100644
--- a/servers/script-server/conf/runners/administrative/wifi/list_devices_on_network.json
+++ b/servers/script-server/conf/runners/administrative/wifi/list_devices_on_network.json
@@ -2,5 +2,5 @@
   "name": "List devices",
   "script_path": "./scripts/network/list_devices.py",
   "description": "List the devices connected to the network we also are connected (you choose the network interface)",
-  "group": "\ud83d\udcf6Wifi Management",
+  "group": "\ud83d\udcf6Wifi Management"
 }
\ No newline at end of file

From ee556baef10ec621f0eb0e07ea1b62048ce8e5b4 Mon Sep 17 00:00:00 2001
From: capsule <valentin.rudloff.perso@gmail.com>
Date: Tue, 7 Dec 2021 19:21:58 +0000
Subject: [PATCH 3/5] add rudloff allowed user and list of interface

---
 .../wifi/list_devices_on_network.json            | 16 +++++++++++++++-
 1 file changed, 15 insertions(+), 1 deletion(-)

diff --git a/servers/script-server/conf/runners/administrative/wifi/list_devices_on_network.json b/servers/script-server/conf/runners/administrative/wifi/list_devices_on_network.json
index 3def359..126380d 100644
--- a/servers/script-server/conf/runners/administrative/wifi/list_devices_on_network.json
+++ b/servers/script-server/conf/runners/administrative/wifi/list_devices_on_network.json
@@ -2,5 +2,19 @@
   "name": "List devices",
   "script_path": "./scripts/network/list_devices.py",
   "description": "List the devices connected to the network we also are connected (you choose the network interface)",
-  "group": "\ud83d\udcf6Wifi Management"
+  "group": "\ud83d\udcf6Wifi Management",
+  "allowed_users": [
+    "rudloff"
+  ],
+  "parameters": [
+    {
+      "name": "interface",
+      "type": "list",
+      "required": true,
+      "param": "INTERFACE",
+      "env_var": "INTERFACE",
+      "description": "List of network interfaces to scan",
+      "values": { "script": "ls /sys/class/net | egrep -v '^br|^veth|^lo|^docker|^tun'", "shell": true }
+    }
+  ]
 }
\ No newline at end of file

From 931206be0d392da3b0f92ba36722aee18561fc3a Mon Sep 17 00:00:00 2001
From: capsule <valentin.rudloff.perso@gmail.com>
Date: Tue, 7 Dec 2021 20:03:12 +0000
Subject: [PATCH 4/5] add list device shell

---
 servers/script-server/scripts/network/list_devices.sh | 4 ++++
 1 file changed, 4 insertions(+)
 create mode 100755 servers/script-server/scripts/network/list_devices.sh

diff --git a/servers/script-server/scripts/network/list_devices.sh b/servers/script-server/scripts/network/list_devices.sh
new file mode 100755
index 0000000..9cb8e87
--- /dev/null
+++ b/servers/script-server/scripts/network/list_devices.sh
@@ -0,0 +1,4 @@
+#!/bin/bash
+
+INTERFACE_IP=/sbin/ifconfig $INTERFACE | egrep -o '([0-9]+[.]){3}[0-9]+' | head -n 1
+nmap -sn $INTERFACE_IP/24

From d79d8bd631b3f7f628cee75187b40591651f39c6 Mon Sep 17 00:00:00 2001
From: capsule <valentin.rudloff.perso@gmail.com>
Date: Tue, 7 Dec 2021 21:19:41 +0000
Subject: [PATCH 5/5] fix instance of viarable

---
 servers/script-server/scripts/network/list_devices.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/servers/script-server/scripts/network/list_devices.sh b/servers/script-server/scripts/network/list_devices.sh
index 9cb8e87..eb72241 100755
--- a/servers/script-server/scripts/network/list_devices.sh
+++ b/servers/script-server/scripts/network/list_devices.sh
@@ -1,4 +1,4 @@
 #!/bin/bash
 
-INTERFACE_IP=/sbin/ifconfig $INTERFACE | egrep -o '([0-9]+[.]){3}[0-9]+' | head -n 1
+INTERFACE_IP=$(/sbin/ifconfig $INTERFACE | egrep -o '([0-9]+[.]){3}[0-9]+' | head -n 1)
 nmap -sn $INTERFACE_IP/24