Skip to content

Not being able to drink mayDrinkWhenFull=true drinkables from flasks when player water is full #41

@Ujhik

Description

@Ujhik

Flasks are not checking mayDrinkWhenFull () from the drinkable here:

//Try to Drink
FoodData stats = player.getFoodData();
if (!ConfigFlasks.THIRSTY_DRINK.get() && stats instanceof TFCFoodData && ((TFCFoodData) stats).getThirst() >= MAX_THIRST) {
// Don't drink if not thirsty
return InteractionResultHolder.fail(player.getItemInHand(hand));
}

TFC checks it in flasks and jugs so players are able to drink some drinkables mainly for buffs:

https://github.com/TerraFirmaCraft/TerraFirmaCraft/blob/34c444f35ba59b0b8ec04192505d88e2048fdce6/src/main/java/net/dries007/tfc/common/items/JugItem.java#L97-L100

Im working on bug solving in terrafirmaGreg modpack, if you agree i can make a PR solving this

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions