Skip to content

Commit a67f199

Browse files
committed
ci: fail lint on warnings
universe sets most of its rules to `warn`, so `yarn lint` exits 0 no matter what eslint reports. src is clean as of the commit before this one, so `--max-warnings 0` starts from zero.
1 parent 4cd6b35 commit a67f199

2 files changed

Lines changed: 4 additions & 2 deletions

File tree

.github/workflows/ci.yml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,9 @@ jobs:
2727
# `prepare` runs `expo-module prepare`, so this already builds once.
2828
- run: yarn install --frozen-lockfile
2929

30-
- run: yarn lint
30+
# universe sets most of its rules to `warn`, so without this the step
31+
# passes no matter what eslint finds.
32+
- run: yarn lint --max-warnings 0
3133

3234
- run: yarn test
3335

.github/workflows/release.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ jobs:
4141

4242
- run: yarn install --frozen-lockfile
4343

44-
- run: yarn lint
44+
- run: yarn lint --max-warnings 0
4545

4646
- run: yarn test
4747

0 commit comments

Comments
 (0)