Skip to content

Commit 39242cc

Browse files
committed
docs(tooling): refresh the config comments for 1.2.0
Both configs are already the shapes 1.2.0 documents, so this is comments only. The oxlint one cited `--print-config` as the check that `extends` drops `ignorePatterns`; 1.2.0 says that command renders an `extends` config pre-merge and is not a valid audit of one. The reason survives it: oxlint has no per-override ignore, which is why `extends` is undocumented now and why `extendConfig` is what this repo uses. The oxfmt one notes why `withoutIgnorePatterns` does not apply here — this changelog is generated by @release-it/conventional-changelog, so the preset's `**/CHANGELOG.md` ignore is the wanted behaviour. Claude-Session: https://claude.ai/code/session_01Fe92vvdc4R3F4BDBFoLcw1
1 parent 39b11d7 commit 39242cc

2 files changed

Lines changed: 9 additions & 6 deletions

File tree

oxfmt.config.mts

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1-
// magic-oxfmt-config 1.1.0 ignores `**/CHANGELOG.md` itself, so the local
2-
// re-declaration this file used to carry is gone.
1+
// magic-oxfmt-config ignores `**/CHANGELOG.md` itself, so the local
2+
// re-declaration this file used to carry is gone. The `withoutIgnorePatterns`
3+
// opt-out 1.2.0 added is for repos that hand-write their changelog; this one's
4+
// is generated by @release-it/conventional-changelog, so the default is right.
35
export { default } from "magic-oxfmt-config";

oxlint.config.mts

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,10 +2,11 @@ import { extendConfig } from "magic-oxlint-config";
22
import base from "magic-oxlint-config/base";
33

44
// `extendConfig` flattens the preset into a single config rather than going
5-
// through oxlint's `extends`, which still drops `ignorePatterns` on oxlint
6-
// 1.75.0 + magic-oxlint-config 1.1.0 — verified with `oxlint --print-config`
7-
// and by linting a probe file under `**/generated/**`. Flattening means there
8-
// is no re-declared ignore list here to drift from the preset's.
5+
// through oxlint's `extends`, which is the only other supported shape and
6+
// cannot carry `ignorePatterns` — oxlint has no per-override ignore, so
7+
// magic-oxlint-config 1.2.0 stopped documenting `extends` entirely. Flattening
8+
// carries the ignore list and the preset's `env`/`globals` by construction,
9+
// with nothing local to drift from the preset.
910
export default extendConfig(base, {
1011
overrides: [
1112
{

0 commit comments

Comments
 (0)