From 1f48d79b32e6becaa2c06f67c936fe19d32f6af9 Mon Sep 17 00:00:00 2001 From: George Kastanis Date: Wed, 15 Jul 2026 14:43:27 +0300 Subject: [PATCH] fix: run the clone command in the web container, not a nonexistent nodejs service commands/nodejs/clone requires a 'nodejs' service that nothing in the current stack defines: this add-on ships no docker-compose service, DDEV-Canvas names its node service 'storybook', and this README states the pipeline runs in the web container. 'ddev clone' therefore fails on every current install with 'service nodejs does not exist'. Move the command to commands/web/ (the web container has node and the pipeline deps via the post-start daemon) and update the two comments that referenced the nodejs container. Co-Authored-By: Claude Fable 5 --- README.md | 2 +- commands/{nodejs => web}/clone | 2 +- install.yaml | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) rename commands/{nodejs => web}/clone (92%) diff --git a/README.md b/README.md index bb85860..7b8f989 100644 --- a/README.md +++ b/README.md @@ -84,4 +84,4 @@ The local OAuth scope is `canvas:asset_library canvas:js_component` (the `member scope is remote/Acquia-only and is invalid locally). `ddev clone` reminds you to run it; because it cannot call a host command from -inside the nodejs container, it does not run bootstrap inline. +inside the web container, it does not run bootstrap inline. diff --git a/commands/nodejs/clone b/commands/web/clone similarity index 92% rename from commands/nodejs/clone rename to commands/web/clone index f57f337..1df8134 100755 --- a/commands/nodejs/clone +++ b/commands/web/clone @@ -16,7 +16,7 @@ shift # remaining args passed through to run.js # NOTE: permission bootstrap runs as the HOST command `ddev canvas-bootstrap` # (it needs drush — which lives in the web container — and writes the host -# storybook/.env). This `clone` command runs in the nodejs container and cannot +# storybook/.env). This `clone` command runs in the web container and cannot # invoke a host command, so bootstrap is not called inline here. The reminder # below points users at it; it is idempotent and safe to re-run. echo "==> If local permissions are not bootstrapped yet, run from the host first: ddev canvas-bootstrap" diff --git a/install.yaml b/install.yaml index 0b04576..31fcb22 100644 --- a/install.yaml +++ b/install.yaml @@ -1,7 +1,7 @@ name: canvas-migration project_files: - config.canvas-migration.yaml - - commands/nodejs/clone + - commands/web/clone - commands/host/canvas-bootstrap - web-build/Dockerfile.canvas-migration - website-to-components