Fail if metrics are missing for a query in yaml-tests#4194
Open
hazefully wants to merge 4 commits into
Open
Conversation
📊 Metrics Diff Analysis ReportSummary
ℹ️ About this analysisThis automated analysis compares query planner metrics between the base branch and this PR. It categorizes changes into:
The last category in particular may indicate planner regressions that should be investigated. New QueriesCount of new queries by file:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue in the yaml-tests planner metrics checking logic which was introduced in #4128, which makes the yaml-test pass if no planner metrics are already present in the corresponding yamsql metrics files.
In addition, e19905d fixes an issue where the tests for adding result metadata and explain expectations to YAML files was cleaning up the existing
explain:andresultMetadata:lines from the input yamsql files, but this cleanup was ineffective because the files were already loaded and copied as resources to the javaclasspathas part of building yaml-tests, meaning that the yaml-tests framework didn't find that anyexplains orresultMetadatas need to be added to the file. This meant that running the test locally would fail for the first time if the yamsql files already had theexplain/resultMetadataexpectation in them, and would then oscillate between passing and failing in each run.